scsi: isci: Remove redundant initialization of variable 'status'
Subsystems (2)
PATCH 1/1 scsi: isci: Remove redundant initialization of variable 'status'
This patch removes unneeded return variables.
It fixes the following warning detected by coccinelle:
./drivers/scsi/isci/request.c:1483:17-23: Unneeded variable: "status". Return "SCI_SUCCESS" on line 1503 ./drivers/scsi/isci/request.c:2157:17-23: Unneeded variable: "status". Return "SCI_SUCCESS" on line 2177
Reported-by Abaci Robot <[email protected]>
Signed-off-by Yang Li <[email protected]>
--- drivers/scsi/isci/request.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-)
drivers/scsi/isci/request.c +2 -6
@@ -1480,8 +1480,6 @@ static enum sci_status sci_stp_request_pio_data_in_copy_data( stp_request_pio_await_h2d_completion_tc_event(struct isci_request *ireq, u32 completion_code) { -enum sci_status status =SCI_SUCCESS ; - switch (SCU_GET_COMPLETION_TL_STATUS(completion_code)) {case SCU_MAKE_COMPLETION_STATUS (SCU_TASK_DONE_GOOD ): ireq->scu_status =SCU_TASK_DONE_GOOD ;
@@ -1500,7 +1498,7 @@ static enum sci_status sci_stp_request_pio_data_in_copy_data(break ; } -return status; +return SCI_SUCCESS ; } static enum sci_status
@@ -2154,8 +2152,6 @@ static enum sci_status stp_request_udma_await_tc_event(struct isci_request *ireqstatic enum sci_status atapi_raw_completion (struct isci_request *ireq,u32 completion_code,enum sci_base_request_states next) { -enum sci_status status =SCI_SUCCESS ; -switch (SCU_GET_COMPLETION_TL_STATUS (completion_code)) {case SCU_MAKE_COMPLETION_STATUS (SCU_TASK_DONE_GOOD ): ireq->scu_status =SCU_TASK_DONE_GOOD ;
@@ -2174,7 +2170,7 @@ static enum sci_status atapi_raw_completion(struct isci_request *ireq, u32 complbreak ; } -return status; +return SCI_SUCCESS ; } static enum sci_status atapi_data_tc_completion_handler(struct isci_request *ireq,
Signature · 1 line
1.8.3.1