scsi: qla4xxx: turn qla4xxx_copy_from_fwddb_param() into void
Subsystems (2)
PATCH 1/1 scsi: qla4xxx: turn qla4xxx_copy_from_fwddb_param() into void
This function always return '0' and no callers use the return value. So make it a void function.
This eliminates the following coccicheck warning:
./drivers/scsi/qla4xxx/ql4_os.c:3642:5-7: Unneeded variable: "rc". Return "0" on line 3741
Reported-by Abaci Robot <[email protected]>
Signed-off-by Yang Li <[email protected]>
--- drivers/scsi/qla4xxx/ql4_os.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/scsi/qla4xxx/ql4_os.c +2 -3
@@ -3634,12 +3634,11 @@ static int qla4xxx_copy_from_fwddb_param(struct iscsi_bus_flash_session *sess,return rc; } -static int qla4xxx_copy_to_fwddb_param (struct iscsi_bus_flash_session *sess, +static void qla4xxx_copy_to_fwddb_param (struct iscsi_bus_flash_session *sess,struct iscsi_bus_flash_conn *conn,struct dev_db_entry *fw_ddb_entry) {uint16_t options; -int rc =0 ; options =le16_to_cpu (fw_ddb_entry->options);SET_BITVAL (conn->is_fw_assigned_ipv6, options,BIT_11 );
@@ -3738,7 +3737,7 @@ static int qla4xxx_copy_to_fwddb_param(struct iscsi_bus_flash_session *sess,COPY_ISID (fw_ddb_entry->isid, sess->isid); -return rc; +return ; } static void qla4xxx_copy_to_sess_conn_params(struct iscsi_conn *conn,
Signature · 1 line
1.8.3.1