nilfs2: make splice write available again
Ryusuke Konishi
maintainerPATCH 1/1 nilfs2: make splice write available again
From: Joachim Henke <[email protected]>
Since 5.10, splice() or sendfile() to NILFS2 return EINVAL. This was caused by commit 36e2c7421f02 ("fs: don't allow splice read/write without explicit ops").
This patch initializes the splice_write field in file_operations, like most file systems do, to restore the functionality.
--- fs/nilfs2/file.c | 1 + 1 file changed, 1 insertion(+)
fs/nilfs2/file.c +1 -0
@@ -141,6 +141,7 @@ static int nilfs_file_mmap(struct file *file, struct vm_area_struct *vma)/* .release = nilfs_release_file, */ .fsync = nilfs_sync_file, .splice_read = generic_file_splice_read, + .splice_write = iter_file_splice_write, };const struct inode_operations nilfs_file_inode_operations = {
Signature · 1 line
1.8.3.1
Ryusuke Konishi
maintainerHi Andrew,
Please send this to upstream. This fixes a regression of splice() on nilfs2.
Thanks,
Ryusuke Konishi
Quoted 33 lines · Ryusuke Konishi
From: Joachim Henke <[email protected]>
Since 5.10,
splice()orsendfile()to NILFS2 return EINVAL. This was caused by commit36e2c7421f02("fs: don't allow splice read/write without explicit ops").This patch initializes the
splice_writefield infile_operations, like most file systems do, to restore the functionality.Signed-off-by Joachim Henke <[email protected]>Signed-off-by Ryusuke Konishi <[email protected]>Tested-by Ryusuke Konishi <[email protected]>Cc [email protected] # 5.10+--- fs/nilfs2/file.c | 1 + 1 file changed, 1 insertion(+)fs/nilfs2/file.c +1
-1@@ -141,6 +141,7 @@ static int nilfs_file_mmap(struct file *file, struct vm_area_struct *vma)/* .release = nilfs_release_file, */ .fsync = nilfs_sync_file, .splice_read = generic_file_splice_read, + .splice_write = iter_file_splice_write, };const struct inode_operations nilfs_file_inode_operations = { --1.8.3.1