mm: compaction: update the COMPACT[STALL|FAIL] events properly
Subsystems (2)
PATCH v2 1/1 mm: compaction: update the COMPACT[STALL|FAIL] events properly
By definition, COMPACT[STALL|FAIL] events needs to be counted when there is 'At least in one zone compaction wasn't deferred or skipped from the direct compaction'. And when compaction is skipped or deferred, COMPACT_SKIPPED will be returned but it will still go and update these compaction events which is wrong in the sense that COMPACT[STALL|FAIL] is counted without even trying the compaction.
Correct this by skipping the counting of these events when COMPACT_SKIPPED is returned for compaction. This indirectly also avoid the unnecessary try into the get_page_from_freelist() when compaction is not even tried.
There is a corner case where compaction is skipped but still count COMPACTSTALL event, which is that IRQ came and freed the page and the same is captured in capture_control.
---
changes in V1: https://lore.kernel.org/patchwork/patch/1373665/
mm/compaction.c | 8 ++++++++ mm/page_alloc.c | 2 ++ 2 files changed, 10 insertions(+)
mm/compaction.c +8 -0
@@ -2487,6 +2487,14 @@ static enum compact_result compact_zone_order(struct zone *zone, int order,*/ WRITE_ONCE (current->capture_control,NULL ); *capture =READ_ONCE (capc.page); +/* +* Technically, it is also possible that compaction is skipped but +* the page is still captured out of luck(IRQ came and freed the page). +* Returning COMPACT_SUCCESS in such cases helps in properly accounting +* the COMPACT[STALL|FAIL] when compaction is skipped. +*/ +if (*capture) + ret =COMPACT_SUCCESS ;return ret; }
mm/page_alloc.c +2 -0
@@ -4152,6 +4152,8 @@ __alloc_pages_direct_compact(gfp_t gfp_mask, unsigned int order,memalloc_noreclaim_restore (noreclaim_flag);psi_memstall_leave (&pflags); +if (*compact_result ==COMPACT_SKIPPED ) +return NULL ;/* * At least in one zone compaction wasn't deferred or skipped, so let's * count a compaction stall
Signature · 2 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation
Quoted 12 lines · Charan Teja Reddy
By definition, COMPACT[STALL|FAIL] events needs to be counted when there is 'At least in one zone compaction wasn't deferred or skipped from the direct compaction'. And when compaction is skipped or deferred,
COMPACT_SKIPPEDwill be returned but it will still go and update these compaction events which is wrong in the sense that COMPACT[STALL|FAIL] is counted without even trying the compaction.Correct this by skipping the counting of these events when
COMPACT_SKIPPEDis returned for compaction. This indirectly also avoid the unnecessary try into theget_page_from_freelist()when compaction is not even tried.
Quoted 5 lines
There is a corner case where compaction is skipped but still count COMPACTSTALL event, which is that IRQ came and freed the page and the same is captured in
capture_control.Signed-off-by Charan Teja Reddy <[email protected]>
Thanks!
Quoted 41 lines
---
changes in V1: https://lore.kernel.org/patchwork/patch/1373665/
mm/compaction.c | 8 ++++++++ mm/page_alloc.c | 2 ++ 2 files changed, 10 insertions(+)mm/compaction.c +8
-0@@ -2487,6 +2487,14 @@ static enum compact_result compact_zone_order(struct zone *zone, int order,*/ WRITE_ONCE (current->capture_control,NULL ); *capture =READ_ONCE (capc.page); +/* +* Technically, it is also possible that compaction is skipped but +* the page is still captured out of luck(IRQ came and freed the page). +* Returning COMPACT_SUCCESS in such cases helps in properly accounting +* the COMPACT[STALL|FAIL] when compaction is skipped. +*/ +if (*capture) + ret =COMPACT_SUCCESS ;return ret; }mm/page_alloc.c +2
-0@@ -4152,6 +4152,8 @@ __alloc_pages_direct_compact(gfp_t gfp_mask, unsigned int order,memalloc_noreclaim_restore (noreclaim_flag);psi_memstall_leave (&pflags); +if (*compact_result ==COMPACT_SKIPPED ) +return NULL ;/* * At least in one zone compaction wasn't deferred or skipped, so let's * count a compaction stall
Quoted 12 lines · Charan Teja Reddy
By definition, COMPACT[STALL|FAIL] events needs to be counted when there is 'At least in one zone compaction wasn't deferred or skipped from the direct compaction'. And when compaction is skipped or deferred,
COMPACT_SKIPPEDwill be returned but it will still go and update these compaction events which is wrong in the sense that COMPACT[STALL|FAIL] is counted without even trying the compaction.Correct this by skipping the counting of these events when
COMPACT_SKIPPEDis returned for compaction. This indirectly also avoid the unnecessary try into theget_page_from_freelist()when compaction is not even tried.
Quoted 5 lines
There is a corner case where compaction is skipped but still count COMPACTSTALL event, which is that IRQ came and freed the page and the same is captured in
capture_control.Signed-off-by Charan Teja Reddy <[email protected]>