scsi: iscsi: Switch to using the new API kobj_to_dev()
PATCH 1/1 scsi: iscsi: Switch to using the new API kobj_to_dev()
fixed the following coccicheck:
./drivers/scsi/scsi_transport_iscsi.c:436:60-61: WARNING opportunity for kobj_to_dev() ./drivers/scsi/scsi_transport_iscsi.c:1128:60-61: WARNING opportunity for kobj_to_dev() ./drivers/scsi/scsi_transport_iscsi.c:4043:61-62: WARNING opportunity for kobj_to_dev() ./drivers/scsi/scsi_transport_iscsi.c:4312:61-62: WARNING opportunity for kobj_to_dev() ./drivers/scsi/scsi_transport_iscsi.c:4456:61-62: WARNING opportunity for kobj_to_dev()
--- drivers/scsi/scsi_transport_iscsi.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
drivers/scsi/scsi_transport_iscsi.c +5 -5
@@ -433,7 +433,7 @@ struct device_attribute dev_attr_##_prefix##_##_name = \static umode_t iscsi_iface_attr_is_visible (struct kobject *kobj,struct attribute *attr,int i) { - struct device *dev = container_of(kobj, struct device, kobj); +struct device *dev =kobj_to_dev (kobj);struct iscsi_iface *iface =iscsi_dev_to_iface (dev);struct iscsi_transport *t = iface->transport;int param;
@@ -1125,7 +1125,7 @@ static umode_t iscsi_flashnode_conn_attr_is_visible(struct kobject *kobj, struct attribute *attr, int i) { - struct device *dev = container_of(kobj, struct device, kobj); +struct device *dev =kobj_to_dev (kobj);struct iscsi_bus_flash_conn *fnode_conn =iscsi_dev_to_flash_conn (dev);struct iscsi_transport *t = fnode_conn->transport;int param;
@@ -4040,7 +4040,7 @@ static ISCSI_CLASS_ATTR(conn, field, S_IRUGO, \static umode_t iscsi_conn_attr_is_visible (struct kobject *kobj,struct attribute *attr,int i) { - struct device *cdev = container_of(kobj, struct device, kobj); +struct device *cdev =kobj_to_dev (kobj);struct iscsi_cls_conn *conn =transport_class_to_conn (cdev);struct iscsi_transport *t = conn->transport;int param;
@@ -4309,7 +4309,7 @@ static ISCSI_CLASS_ATTR(priv_sess, field, S_IRUGO | S_IWUSR, \static umode_t iscsi_session_attr_is_visible (struct kobject *kobj,struct attribute *attr,int i) { - struct device *cdev = container_of(kobj, struct device, kobj); +struct device *cdev =kobj_to_dev (kobj);struct iscsi_cls_session *session =transport_class_to_session (cdev);struct iscsi_transport *t = session->transport;int param;
@@ -4453,7 +4453,7 @@ static ISCSI_CLASS_ATTR(host, field, S_IRUGO, show_host_param_##param, \static umode_t iscsi_host_attr_is_visible (struct kobject *kobj,struct attribute *attr,int i) { - struct device *cdev = container_of(kobj, struct device, kobj); +struct device *cdev =kobj_to_dev (kobj);struct Scsi_Host *shost =transport_class_to_shost (cdev);struct iscsi_internal *priv =to_iscsi_internal (shost->transportt);int param;
Signature · 1 line
1.8.3.1
Quoted 11 lines · Yang Li
fixed the following coccicheck:
./drivers/scsi/scsi_transport_iscsi.c:436:60-61: WARNING opportunity forkobj_to_dev()./drivers/scsi/scsi_transport_iscsi.c:1128:60-61: WARNING opportunity forkobj_to_dev()./drivers/scsi/scsi_transport_iscsi.c:4043:61-62: WARNING opportunity forkobj_to_dev()./drivers/scsi/scsi_transport_iscsi.c:4312:61-62: WARNING opportunity forkobj_to_dev()./drivers/scsi/scsi_transport_iscsi.c:4456:61-62: WARNING opportunity forkobj_to_dev()
that API is not new, so please in future stop writing that. And 'new' is a time-dependent term, and not appropriate to use anyway.
Thanks,
John
Quoted 3 lines
Reported-by Abaci Robot<[email protected]>Signed-off-by Yang Li<[email protected]>