Skip to contentSkip to conversation

usb: dwc3: core: don't enable wakeup for runtime PM

PATCH Superseded Li Jun 2 participants 3 messages Mar 4, 2021 – Mar 24, 2021

Subsystems (2)
USB DesignWare USB3 DRD IP driver

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Li Jun

author
#0 lore raw

PATCH 1/1 usb: dwc3: core: don't enable wakeup for runtime PM

Don't enable dwc3 core to wakeup system by default if runtime suspended, this will make the power domain of dwc3 core or its parent device can't be off while system sleep even system wakeup by usb is not required.

Signed-off-by Li Jun <[email protected]>
---
 drivers/usb/dwc3/core.c | 4 ----
 1 file changed, 4 deletions(-)
drivers/usb/dwc3/core.c +0 -4
index 6969196..a8466f6 100644
@@ -1788,8 +1788,6 @@ static int dwc3_runtime_suspend(struct device *dev)
 	if (ret)
 		return ret;
 
-	device_init_wakeup(dev, true);
-
 	return 0;
 }
 

@@ -1798,8 +1796,6 @@ static int dwc3_runtime_resume(struct device *dev)
 	struct dwc3     *dwc = dev_get_drvdata(dev);
 	int		ret;
 
-	device_init_wakeup(dev, false);
-
 	ret = dwc3_resume_common(dwc, PMSG_AUTO_RESUME);
 	if (ret)
 		return ret;
Signature · 1 line
2.7.4
maintainer
#1 lore raw
Quoted 6 lines · Li Jun

Don't enable dwc3 core to wakeup system by default if runtime suspended, this will make the power domain of dwc3 core or its parent device can't be off while system sleep even system wakeup by usb is not required.

Signed-off-by Li Jun <[email protected]>

---

What commit does this fix? Does it need to go to stable kernels? If so, how far back?

Please add that information to the signed-off-by area when resending.

thanks,

greg k-h

author
#2 lore raw
Quoted 14 lines

-----Original Message-----
From: Greg KH <[email protected]>
Sent: Tuesday, March 23, 2021 7:52 PM
To: Jun Li <[email protected]>
Cc: [email protected]; [email protected]
Subject: Re: [PATCH] usb: dwc3: core: don't enable wakeup for runtime PM

Quoted 3 lines · Li Jun

Don't enable dwc3 core to wakeup system by default if runtime suspended, this will make the power domain of dwc3 core or its parent device can't be off while system sleep even system wakeup by usb is not

required.

Quoted 1 line
Quoted 7 lines
Quoted 2 lines
Signed-off-by Li Jun <[email protected]>

---

What commit does this fix? Does it need to go to stable kernels? If so, how far back?

Please add that information to the signed-off-by area when resending.

Just sent out v2 with fix tag and cc to stable kernel.

Thanks
Li Jun

Quoted 4 lines

thanks,

greg k-h