patch "usb: dwc3: qcom: Add missing DWC3 OF node refcount decrement" added to usb-linus
This is a note to let you know that I've just added the patch titled
usb: dwc3: qcom: Add missing DWC3 OF node refcount decrement
to my usb git tree which can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
in the usb-linus branch.
The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.)
The patch will hopefully also be merged in Linus's tree for the next -rc kernel release.
If you have any questions about this process, please let me know.
From 58f3367b2359e88b83bcfca5b77d48b609eb2123 Mon Sep 17 00:00:00 2001
From: Serge Semin <[email protected]>
Date: Fri, 12 Feb 2021 23:55:19 +0300
Subject: usb: dwc3: qcom: Add missing DWC3 OF node refcount decrement
of_get_child_by_name() increments the reference counter of the OF node it managed to find. So after the code is done using the device node, the refcount must be decremented. Add missing of_node_put() invocation then to the dwc3_qcom_of_register_core() method, since DWC3 OF node is being used only there.
--- drivers/usb/dwc3/dwc3-qcom.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-)
drivers/usb/dwc3/dwc3-qcom.c +6 -3
@@ -653,16 +653,19 @@ static int dwc3_qcom_of_register_core(struct platform_device *pdev) ret =of_platform_populate (np,NULL ,NULL , dev);if (ret) {dev_err (dev,"failed to register dwc3 core - %d\n" , ret); -return ret; + goto node_put; } qcom->dwc3 =of_find_device_by_node (dwc3_np);if (!qcom->dwc3) { + ret = -ENODEV ;dev_err (dev,"failed to get dwc3 platform device\n" ); -return -ENODEV ; } -return 0 ; +node_put: +of_node_put (dwc3_np); + +return ret; } static struct platform_device *
Signature · 1 line
2.30.1