Skip to contentSkip to conversation

uml: remove unneeded variable 'ret'

PATCH In review Yang Li 2 participants 2 messages Mar 10, 2021 User-mode Linux (UML)

lore
Share & tools
lore

Yang Li

author
#0 lore raw

PATCH 1/1 uml: remove unneeded variable 'ret'

Fix the following coccicheck warning:
./arch/um/drivers/hostaudio_kern.c:125:10-14: Unneeded variable: "mask". Return "0" on line 131

---
 arch/um/drivers/hostaudio_kern.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
arch/um/drivers/hostaudio_kern.c +1 -3
index d35d3f3..5b064d3 100644
@@ -122,13 +122,11 @@ static ssize_t hostaudio_write(struct file *file, const char __user *buffer,
 static __poll_t hostaudio_poll(struct file *file,
 				struct poll_table_struct *wait)
 {
-	__poll_t mask = 0;
-
 #ifdef DEBUG
 	printk(KERN_DEBUG "hostaudio: poll called (unimplemented)\n");
 #endif
 
-	return mask;
+	return 0;
 }
 
 static long hostaudio_ioctl(struct file *file,
Signature · 7 lines
1.8.3.1


_______________________________________________
linux-um mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-um
maintainer
#1 lore raw
Quoted 3 lines · Yang Li

Fix the following coccicheck warning:
./arch/um/drivers/hostaudio_kern.c:125:10-14: Unneeded variable: "mask". Return "0" on line 131

Word of caution to you:

You've already managed to be in various people's block list due to sending patches such as

https://lore.kernel.org/linuxppc-dev/[email protected]/

You might want to stop for a while, and *really* carefully look at each and every patch you send out.

In this case, you messed up the subject.

johannes

_______________________________________________
linux-um mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-um