io_uring: don't iterate ctx list to update sq_thread_idle
PATCH 1/1 io_uring: don't iterate ctx list to update sq_thread_idle
sqd->sq_thread_idle can be updated by a simple max(), rather than iterating the whole ctx list to get the max one.
--- fs/io_uring.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
fs/io_uring.c +1 -1
@@ -7871,7 +7871,7 @@ static int io_sq_offload_create(struct io_ring_ctx *ctx, ret = -ENXIO ; }else {list_add (&ctx->sqd_list, &sqd->ctx_list); -io_sqd_update_thread_idle (sqd); + sqd->sq_thread_idle =max (sqd->sq_thread_idle, ctx->sq_thread_idle); }io_sq_thread_unpark (sqd);
Signature · 1 line
1.8.3.1
Quoted 2 lines · Hao Xu
sqd->sq_thread_idlecan be updated by a simplemax(), rather than iterating the whole ctx list to get the max one.
I left it as a more fool proof option. Do you have a performance issue with it? E.g. dozens rings sharing a single SQPOLL and constantly adding new ones.
Quoted 20 lines
Signed-off-by Hao Xu <[email protected]>--- fs/io_uring.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)fs/io_uring.c +1
-1@@ -7871,7 +7871,7 @@ static int io_sq_offload_create(struct io_ring_ctx *ctx, ret = -ENXIO ; }else {list_add (&ctx->sqd_list, &sqd->ctx_list); -io_sqd_update_thread_idle (sqd); + sqd->sq_thread_idle =max (sqd->sq_thread_idle, ctx->sq_thread_idle); }io_sq_thread_unpark (sqd);
Signature · 1 line
Pavel Begunkov
Quoted 7 lines · Pavel Begunkov
Quoted 2 lines · Hao Xu
sqd->sq_thread_idlecan be updated by a simplemax(), rather than iterating the whole ctx list to get the max one.I left it as a more fool proof option. Do you have a performance issue with it? E.g. dozens rings sharing a single SQPOLL and constantly adding new ones.
Currently no performance cases, just happen to see this and make the code change.
Quoted 22 lines
Quoted 21 lines
Signed-off-by Hao Xu <[email protected]>--- fs/io_uring.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)fs/io_uring.c +1
-1@@ -7871,7 +7871,7 @@ static int io_sq_offload_create(struct io_ring_ctx *ctx, ret = -ENXIO ; }else {list_add (&ctx->sqd_list, &sqd->ctx_list); -io_sqd_update_thread_idle (sqd); + sqd->sq_thread_idle =max (sqd->sq_thread_idle, ctx->sq_thread_idle); }io_sq_thread_unpark (sqd);