Skip to contentSkip to conversation

nvme-pci: add another device ID with stripe quirk

PATCH In review Zheng Wu 4 participants 5 messages Mar 16, 2021 – Mar 17, 2021 NVMe

lore
Share & tools
lore

Zheng Wu

author
#0 lore raw

PATCH 1/1 nvme-pci: add another device ID with stripe quirk

From: Wu Zheng <[email protected]>

Adds the Intel controller of P5510 which has the "stripe" quirk.

---
 drivers/nvme/host/pci.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/nvme/host/pci.c +3 -0
index 7249ae7..46b872d 100644
@@ -3221,6 +3221,9 @@ static const struct pci_device_id nvme_id_table[] = {
 	{ PCI_VDEVICE(INTEL, 0x0a55),	/* Dell Express Flash P4600 */
 		.driver_data = NVME_QUIRK_STRIPE_SIZE |
 				NVME_QUIRK_DEALLOCATE_ZEROES, },
+	{ PCI_VDEVICE(INTEL, 0x0b60),   /* Intel P5510 */
+		.driver_data = NVME_QUIRK_STRIPE_SIZE |
+				NVME_QUIRK_DEALLOCATE_ZEROES, },
 	{ PCI_VDEVICE(INTEL, 0xf1a5),	/* Intel 600P/P3100 */
 		.driver_data = NVME_QUIRK_NO_DEEPEST_PS |
 				NVME_QUIRK_MEDIUM_PRIO_SQ |
Signature · 7 lines
2.7.4


_______________________________________________
Linux-nvme mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-nvme
#1 lore raw
Quoted 6 lines · Zheng Wu

From: Wu Zheng <[email protected]>

Adds the Intel controller of P5510 which has the "stripe" quirk.

I'm pretty sure we said we're not going add more of these years after there has been a standard way to communicate this performance preference using the noiob field.

_______________________________________________
Linux-nvme mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-nvme

maintainer
#2 lore raw
Quoted 11 lines · Christoph Hellwig
Quoted 6 lines · Zheng Wu

From: Wu Zheng <[email protected]>

Adds the Intel controller of P5510 which has the "stripe" quirk.

I'm pretty sure we said we're not going add more of these years after there has been a standard way to communicate this performance preference using the noiob field.

P5510 was a Q4'20 release and NOIOB is 4 years older than that!

Jinhe, is it possible to reiterate to the development side how painful this non-standard behavior is to the nvme ecosystem? The spec compliant method is a simple and harmless f/w change that will make all your Linux customers better off.

_______________________________________________
Linux-nvme mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-nvme

#3 lore raw

Checked P5510 and it supports noiob field.
nvme id-ns /dev/nvme0n1 |grep noiob
noiob : 256

The purpose of the patch is for customers who are using old kernels. May I know from which kernel will support "stripe" quirk by noiob field checking? Thank you!

-----Original Message-----
From: Keith Busch <[email protected]>
Sent: Wednesday, March 17, 2021 5:09 AM
To: Christoph Hellwig <[email protected]>
Cc: Zheng, Wu <[email protected]>; [email protected]; Ye, Jinhe <[email protected]>
Subject: Re: [PATCH] nvme-pci: add another device ID with stripe quirk

Quoted 11 lines · Christoph Hellwig
Quoted 6 lines · Zheng Wu

From: Wu Zheng <[email protected]>

Adds the Intel controller of P5510 which has the "stripe" quirk.

I'm pretty sure we said we're not going add more of these years after there has been a standard way to communicate this performance preference using the noiob field.

P5510 was a Q4'20 release and NOIOB is 4 years older than that!

Jinhe, is it possible to reiterate to the development side how painful this non-standard behavior is to the nvme ecosystem? The spec compliant method is a simple and harmless f/w change that will make all your Linux customers better off.

_______________________________________________
Linux-nvme mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-nvme

maintainer
#4 lore raw
Quoted 3 lines · Jinhe

Checked P5510 and it supports noiob field.
nvme id-ns /dev/nvme0n1 |grep noiob
noiob : 256

Awesome! So you don't need the quirk. :)

Quoted 1 line

The purpose of the patch is for customers who are using old kernels. May I know from which kernel will support "stripe" quirk by noiob field checking? Thank you!

Linux initially supported noiob since v4.13, which was released 9/2017. If you need to go older than that, I think backporting noiob support is a better option adding more quirks.

_______________________________________________
Linux-nvme mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-nvme