Skip to contentSkip to conversation

mmc: moxart: Remove unused variable 'dma_time' and 'pio_time'

PATCH In review Yang Li 2 participants 2 messages Apr 2, 2021 – Apr 12, 2021 MMC, SD and SDIO

lore
Share & tools
lore

Yang Li

author
#0 lore raw

PATCH 1/1 mmc: moxart: Remove unused variable 'dma_time' and 'pio_time'

Fixes the following W=1 kernel build warning(s):

drivers/mmc/host/moxart-mmc.c:257:7: warning: variable ‘dma_time’ set but not used
drivers/mmc/host/moxart-mmc.c:395:7: warning: variable ‘pio_time’ set but not used

---
 drivers/mmc/host/moxart-mmc.c | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)
drivers/mmc/host/moxart-mmc.c +4 -6
index 89bff4e..bde2988 100644
@@ -257,7 +257,6 @@ static void moxart_dma_complete(void *param)
 static void moxart_transfer_dma(struct mmc_data *data, struct moxart_host *host)
 {
 	u32 len, dir_slave;
-	long dma_time;
 	struct dma_async_tx_descriptor *desc = NULL;
 	struct dma_chan *dma_chan;
 
@@ -294,8 +293,8 @@ static void moxart_transfer_dma(struct mmc_data *data, struct moxart_host *host)
 
 	data->bytes_xfered += host->data_remain;
 
-	dma_time = wait_for_completion_interruptible_timeout(
-		   &host->dma_complete, host->timeout);
+	wait_for_completion_interruptible_timeout(&host->dma_complete,
+						  host->timeout);
 
 	dma_unmap_sg(dma_chan->device->dev,
 		     data->sg, data->sg_len,
@@ -395,7 +394,6 @@ static void moxart_prepare_data(struct moxart_host *host)
 static void moxart_request(struct mmc_host *mmc, struct mmc_request *mrq)
 {
 	struct moxart_host *host = mmc_priv(mmc);
-	long pio_time;
 	unsigned long flags;
 	u32 status;
 
@@ -431,8 +429,8 @@ static void moxart_request(struct mmc_host *mmc, struct mmc_request *mrq)
 			spin_unlock_irqrestore(&host->lock, flags);
 
 			/* PIO transfers start from interrupt. */
-			pio_time = wait_for_completion_interruptible_timeout(
-				   &host->pio_complete, host->timeout);
+			wait_for_completion_interruptible_timeout(&host->pio_complete,
+								  host->timeout);
 
 			spin_lock_irqsave(&host->lock, flags);
 		}
Signature · 1 line
1.8.3.1
#1 lore raw
Quoted 10 lines · Yang Li

Fixes the following W=1 kernel build warning(s):

drivers/mmc/host/moxart-mmc.c:257:7: warning: variable ‘dma_time’ set but not used
drivers/mmc/host/moxart-mmc.c:395:7: warning: variable ‘pio_time’ set but not used

Applied for next, thanks!

Kind regards
Uffe

Quoted 49 lines
---
 drivers/mmc/host/moxart-mmc.c | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)
drivers/mmc/host/moxart-mmc.c +4 -7
index 89bff4e..bde2988 100644
@@ -257,7 +257,6 @@ static void moxart_dma_complete(void *param)
 static void moxart_transfer_dma(struct mmc_data *data, struct moxart_host *host)
 {
        u32 len, dir_slave;
-       long dma_time;
        struct dma_async_tx_descriptor *desc = NULL;
        struct dma_chan *dma_chan;
 
@@ -294,8 +293,8 @@ static void moxart_transfer_dma(struct mmc_data *data, struct moxart_host *host)
 
        data->bytes_xfered += host->data_remain;
 
-       dma_time = wait_for_completion_interruptible_timeout(
-                  &host->dma_complete, host->timeout);
+       wait_for_completion_interruptible_timeout(&host->dma_complete,
+                                                 host->timeout);
 
        dma_unmap_sg(dma_chan->device->dev,
                     data->sg, data->sg_len,
@@ -395,7 +394,6 @@ static void moxart_prepare_data(struct moxart_host *host)
 static void moxart_request(struct mmc_host *mmc, struct mmc_request *mrq)
 {
        struct moxart_host *host = mmc_priv(mmc);
-       long pio_time;
        unsigned long flags;
        u32 status;
 
@@ -431,8 +429,8 @@ static void moxart_request(struct mmc_host *mmc, struct mmc_request *mrq)
                        spin_unlock_irqrestore(&host->lock, flags);
 
                        /* PIO transfers start from interrupt. */
-                       pio_time = wait_for_completion_interruptible_timeout(
-                                  &host->pio_complete, host->timeout);
+                       wait_for_completion_interruptible_timeout(&host->pio_complete,
+                                                                 host->timeout);
 
                        spin_lock_irqsave(&host->lock, flags);
                }
--

1.8.3.1