Skip to contentSkip to conversation

Patch "ARM: dts: turris-omnia: configure LED[2]/INTn pin as interrupt pin" has been added to the 4.14-stable tree

PATCH [email protected] 1 participant 1 message Apr 10, 2021 Device tree bindings

lore
Share & tools
lore

[email protected]

author Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

ARM: dts: turris-omnia: configure LED[2]/INTn pin as interrupt pin

to the 4.14-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
arm-dts-turris-omnia-configure-led-intn-pin-as-interrupt-pin.patch
and it can be found in the queue-4.14 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

From a26c56ae67fa9fbb45a8a232dcd7ebaa7af16086 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Marek=20Beh=C3=BAn?= <[email protected]>
Date: Sun, 21 Feb 2021 00:11:44 +0100
Subject: ARM: dts: turris-omnia: configure LED[2]/INTn pin as interrupt pin
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

From: Marek Behún <[email protected]>

commit a26c56ae67fa9fbb45a8a232dcd7ebaa7af16086 upstream.

Use the marvell,reg-init DT property to configure the LED[2]/INTn pin of the Marvell 88E1514 ethernet PHY on Turris Omnia into interrupt mode.

Without this the pin is by default in LED[2] mode, and the Marvell PHY driver configures LED[2] into "On - Link, Blink - Activity" mode.

This fixes the issue where the pca9538 GPIO/interrupt controller (which can't mask interrupts in HW) received too many interrupts and after a time started ignoring the interrupt with error message:
IRQ 71: nobody cared

There is a work in progress to have the Marvell PHY driver support parsing PHY LED nodes from OF and registering the LEDs as Linux LED class devices. Once this is done the PHY driver can also automatically set the pin into INTn mode if it does not find LED[2] in OF.

Until then, though, we fix this via marvell,reg-init DT property.

Fixes 26ca8b52d6e1 ("ARM: dts: add support for Turris Omnia")
Cc Uwe Kleine-König <[email protected]>
Cc Andrew Lunn <[email protected]>
Cc Gregory CLEMENT <[email protected]>
---
 arch/arm/boot/dts/armada-385-turris-omnia.dts |    1 +
 1 file changed, 1 insertion(+)
arch/arm/boot/dts/armada-385-turris-omnia.dts +1 -0
@@ -269,6 +269,7 @@
 		status = "okay";
 		compatible = "ethernet-phy-id0141.0DD1", "ethernet-phy-ieee802.3-c22";
 		reg = <1>;
+		marvell,reg-init = <3 18 0 0x4985>;
 
 		/* irq is connected to &pcawan pin 7 */
 	};

Patches currently in stable-queue which might be from [email protected] are

queue-4.14/arm-dts-turris-omnia-configure-led-intn-pin-as-interrupt-pin.patch

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel