mtd: rawnand: qcom: avoid write to obsolete register
PATCH 1/1 mtd: rawnand: qcom: avoid write to obsolete register
QPIC_EBI2_ECC_BUF_CFG register got obsolete from QPIC V2.0 onwards. Avoid writing this register if QPIC version is V2.0 or newer.
--- drivers/mtd/nand/raw/qcom_nandc.c | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-)
drivers/mtd/nand/raw/qcom_nandc.c +11 -6
@@ -714,7 +714,8 @@ static void update_rw_regs(struct qcom_nand_host *host, int num_cw, bool read)nandc_set_reg (nandc,NAND_DEV0_CFG0 , cfg0);nandc_set_reg (nandc,NAND_DEV0_CFG1 , cfg1);nandc_set_reg (nandc,NAND_DEV0_ECC_CFG , ecc_bch_cfg); -nandc_set_reg (nandc,NAND_EBI2_ECC_BUF_CFG , host->ecc_buf_cfg); +if (!nandc->props->qpic_v2) +nandc_set_reg (nandc,NAND_EBI2_ECC_BUF_CFG , host->ecc_buf_cfg);nandc_set_reg (nandc,NAND_FLASH_STATUS , host->clrflashstatus);nandc_set_reg (nandc,NAND_READ_STATUS , host->clrreadstatus);nandc_set_reg (nandc,NAND_EXEC_CMD ,1 );
@@ -1083,7 +1084,8 @@ static void config_nand_page_read(struct qcom_nand_controller *nandc) {write_reg_dma (nandc,NAND_ADDR0 ,2 ,0 );write_reg_dma (nandc,NAND_DEV0_CFG0 ,3 ,0 ); -write_reg_dma (nandc,NAND_EBI2_ECC_BUF_CFG ,1 ,0 ); +if (!nandc->props->qpic_v2) +write_reg_dma (nandc,NAND_EBI2_ECC_BUF_CFG ,1 ,0 );write_reg_dma (nandc,NAND_ERASED_CW_DETECT_CFG ,1 ,0 );write_reg_dma (nandc,NAND_ERASED_CW_DETECT_CFG ,1 ,NAND_ERASED_CW_SET |NAND_BAM_NEXT_SGL );
@@ -1132,8 +1134,9 @@ static void config_nand_page_write(struct qcom_nand_controller *nandc) {write_reg_dma (nandc,NAND_ADDR0 ,2 ,0 );write_reg_dma (nandc,NAND_DEV0_CFG0 ,3 ,0 ); -write_reg_dma (nandc,NAND_EBI2_ECC_BUF_CFG ,1 , -NAND_BAM_NEXT_SGL ); +if (!nandc->props->qpic_v2) +write_reg_dma (nandc,NAND_EBI2_ECC_BUF_CFG ,1 , +NAND_BAM_NEXT_SGL ); }/*
@@ -1187,7 +1190,8 @@ static int nandc_param(struct qcom_nand_host *host) | 2 << WR_RD_BSY_GAP |0 <<WIDE_FLASH | 1 << DEV0_CFG1_ECC_DISABLE); -nandc_set_reg (nandc,NAND_EBI2_ECC_BUF_CFG ,1 <<ECC_CFG_ECC_DISABLE ); +if (!nandc->props->qpic_v2) +nandc_set_reg (nandc,NAND_EBI2_ECC_BUF_CFG ,1 <<ECC_CFG_ECC_DISABLE );/* configure CMD1 and VLD for ONFI param probing in QPIC v1 */ if (!nandc->props->qpic_v2) {
@@ -2628,7 +2632,8 @@ static int qcom_nand_attach_chip(struct nand_chip *chip) | ecc_mode << ECC_MODE | host->ecc_bytes_hw <<ECC_PARITY_SIZE_BYTES_BCH ; - host->ecc_buf_cfg =0x203 <<NUM_STEPS ; +if (!nandc->props->qpic_v2) + host->ecc_buf_cfg =0x203 <<NUM_STEPS ; host->clrflashstatus =FS_READY_BSY_N ; host->clrreadstatus =0xc0 ;
Signature · 1 line
2.7.4
Quoted 71 lines · Md Sadre Alam
QPIC_EBI2_ECC_BUF_CFGregister got obsolete from QPIC V2.0 onwards. Avoid writing this register if QPIC version is V2.0 or newer.Signed-off-by Md Sadre Alam <[email protected]>--- drivers/mtd/nand/raw/qcom_nandc.c | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-)drivers/mtd/nand/raw/qcom_nandc.c +2
-1@@ -714,7 +714,8 @@ static void update_rw_regs(struct qcom_nand_host *host, int num_cw, bool read)nandc_set_reg (nandc,NAND_DEV0_CFG0 , cfg0);nandc_set_reg (nandc,NAND_DEV0_CFG1 , cfg1);nandc_set_reg (nandc,NAND_DEV0_ECC_CFG , ecc_bch_cfg); -nandc_set_reg (nandc,NAND_EBI2_ECC_BUF_CFG , host->ecc_buf_cfg); +if (!nandc->props->qpic_v2) +nandc_set_reg (nandc,NAND_EBI2_ECC_BUF_CFG , host->ecc_buf_cfg);nandc_set_reg (nandc,NAND_FLASH_STATUS , host->clrflashstatus);nandc_set_reg (nandc,NAND_READ_STATUS , host->clrreadstatus);drivers/mtd/nand/raw/qcom_nandc.c +2
-1nandc_set_reg (nandc,NAND_EXEC_CMD ,1 );@@ -1083,7 +1084,8 @@ static void config_nand_page_read(struct qcom_nand_controller *nandc) {write_reg_dma (nandc,NAND_ADDR0 ,2 ,0 );write_reg_dma (nandc,NAND_DEV0_CFG0 ,3 ,0 ); -write_reg_dma (nandc,NAND_EBI2_ECC_BUF_CFG ,1 ,0 ); +if (!nandc->props->qpic_v2) +write_reg_dma (nandc,NAND_EBI2_ECC_BUF_CFG ,1 ,0 );write_reg_dma (nandc,NAND_ERASED_CW_DETECT_CFG ,1 ,0 ); write_reg_dma(nandc, NAND_ERASED_CW_DETECT_CFG, 1,drivers/mtd/nand/raw/qcom_nandc.c +3
-2NAND_ERASED_CW_SET | NAND_BAM_NEXT_SGL);@@ -1132,8 +1134,9 @@ static void config_nand_page_write(struct qcom_nand_controller *nandc) {write_reg_dma (nandc,NAND_ADDR0 ,2 ,0 );write_reg_dma (nandc,NAND_DEV0_CFG0 ,3 ,0 ); -write_reg_dma (nandc,NAND_EBI2_ECC_BUF_CFG ,1 , -NAND_BAM_NEXT_SGL ); +if (!nandc->props->qpic_v2) +write_reg_dma (nandc,NAND_EBI2_ECC_BUF_CFG ,1 , +NAND_BAM_NEXT_SGL ); }/*
drivers/mtd/nand/raw/qcom_nandc.c +2
-1@@ -1187,7 +1190,8 @@ static int nandc_param(struct qcom_nand_host *host) |2 <<WR_RD_BSY_GAP |0 <<WIDE_FLASH | 1 << DEV0_CFG1_ECC_DISABLE); -nandc_set_reg (nandc,NAND_EBI2_ECC_BUF_CFG ,1 << ECC_CFG_ECC_DISABLE); +if (!nandc->props->qpic_v2) +nandc_set_reg (nandc,NAND_EBI2_ECC_BUF_CFG ,1 <<ECC_CFG_ECC_DISABLE );drivers/mtd/nand/raw/qcom_nandc.c +2
-1/* configure CMD1 and VLD for ONFI param probing in QPIC v1 */ if (!nandc->props->qpic_v2) {@@ -2628,7 +2632,8 @@ static int qcom_nand_attach_chip(struct nand_chip *chip) | ecc_mode <<ECC_MODE | host->ecc_bytes_hw <<ECC_PARITY_SIZE_BYTES_BCH ; - host->ecc_buf_cfg =0x203 <<NUM_STEPS ; +if (!nandc->props->qpic_v2) + host->ecc_buf_cfg =0x203 <<NUM_STEPS ; host->clrflashstatus =FS_READY_BSY_N ;
Quoted 1 line
host->clrreadstatus=0xc0;
ping! Hi Miquel could you review this change and let me know if more info needed.
Miquel Raynal
maintainerHello,
[email protected] wrote on Mon, 03 May 2021 20:24:54 +0530:
Quoted 67 lines · Md Sadre Alam
Quoted 66 lines
QPIC_EBI2_ECC_BUF_CFGregister got obsolete from QPIC V2.0 onwards. Avoid writing this register if QPIC version is V2.0 or newer.Signed-off-by Md Sadre Alam <[email protected]>--- drivers/mtd/nand/raw/qcom_nandc.c | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-)drivers/mtd/nand/raw/qcom_nandc.c +2
-1@@ -714,7 +714,8 @@ static void update_rw_regs(struct qcom_nand_host *host, int num_cw, bool read)nandc_set_reg (nandc,NAND_DEV0_CFG0 , cfg0);nandc_set_reg (nandc,NAND_DEV0_CFG1 , cfg1);nandc_set_reg (nandc,NAND_DEV0_ECC_CFG , ecc_bch_cfg); -nandc_set_reg (nandc,NAND_EBI2_ECC_BUF_CFG , host->ecc_buf_cfg); +if (!nandc->props->qpic_v2) +nandc_set_reg (nandc,NAND_EBI2_ECC_BUF_CFG , host->ecc_buf_cfg);nandc_set_reg (nandc,NAND_FLASH_STATUS , host->clrflashstatus);nandc_set_reg (nandc,NAND_READ_STATUS , host->clrreadstatus);drivers/mtd/nand/raw/qcom_nandc.c +2
-1nandc_set_reg (nandc,NAND_EXEC_CMD ,1 );@@ -1083,7 +1084,8 @@ static void config_nand_page_read(struct qcom_nand_controller *nandc) {write_reg_dma (nandc,NAND_ADDR0 ,2 ,0 );write_reg_dma (nandc,NAND_DEV0_CFG0 ,3 ,0 ); -write_reg_dma (nandc,NAND_EBI2_ECC_BUF_CFG ,1 ,0 ); +if (!nandc->props->qpic_v2) +write_reg_dma (nandc,NAND_EBI2_ECC_BUF_CFG ,1 ,0 );write_reg_dma (nandc,NAND_ERASED_CW_DETECT_CFG ,1 ,0 ); write_reg_dma(nandc, NAND_ERASED_CW_DETECT_CFG, 1,drivers/mtd/nand/raw/qcom_nandc.c +3
-2NAND_ERASED_CW_SET | NAND_BAM_NEXT_SGL);@@ -1132,8 +1134,9 @@ static void config_nand_page_write(struct qcom_nand_controller *nandc) {write_reg_dma (nandc,NAND_ADDR0 ,2 ,0 );write_reg_dma (nandc,NAND_DEV0_CFG0 ,3 ,0 ); -write_reg_dma (nandc,NAND_EBI2_ECC_BUF_CFG ,1 , -NAND_BAM_NEXT_SGL ); +if (!nandc->props->qpic_v2) +write_reg_dma (nandc,NAND_EBI2_ECC_BUF_CFG ,1 , +NAND_BAM_NEXT_SGL ); }/*
drivers/mtd/nand/raw/qcom_nandc.c +4
-2@@ -1187,7 +1190,8 @@ static int nandc_param(struct qcom_nand_host > *host) | 2 << WR_RD_BSY_GAP |0 <<WIDE_FLASH | 1 << DEV0_CFG1_ECC_DISABLE); - nandc_set_reg(nandc, NAND_EBI2_ECC_BUF_CFG, 1 << > ECC_CFG_ECC_DISABLE); +if (!nandc->props->qpic_v2) + nandc_set_reg(nandc, NAND_EBI2_ECC_BUF_CFG, 1 << > ECC_CFG_ECC_DISABLE);/* configure CMD1 and VLD for ONFI param probing in QPIC v1 */ if (!nandc->props->qpic_v2) {@@ -2628,7 +2632,8 @@ static int qcom_nand_attach_chip(struct nand_chip > *chip) | ecc_mode << ECC_MODE | host->ecc_bytes_hw <<ECC_PARITY_SIZE_BYTES_BCH ; - host->ecc_buf_cfg =0x203 <<NUM_STEPS ; +if (!nandc->props->qpic_v2) + host->ecc_buf_cfg =0x203 <<NUM_STEPS ;
Quoted 5 lines
drivers/mtd/nand/raw/qcom_nandc.c static int qcom_nand_attach_chip(struct nand_chip *chip) · line 2639
Quoted 2 lines
drivers/mtd/nand/raw/qcom_nandc.c +0
-0host->clrflashstatus =FS_READY_BSY_N ; host->clrreadstatus =0xc0 ;ping! Hi Miquel could you review this change and let me know if more info needed.
Come on, that's only 6 days of work and we are in the middle of the merge window...
BTW "avoid write to" in the title is incorrect "writing to" would be nicer.
Thanks,
Miquèl
Quoted 77 lines · Miquel Raynal
Hello,
[email protected] wrote on Mon, 03 May 2021 20:24:54 +0530:
Quoted 67 lines · Md Sadre Alam
Quoted 66 lines
QPIC_EBI2_ECC_BUF_CFGregister got obsolete from QPIC V2.0 onwards. Avoid writing this register if QPIC version is V2.0 or newer.Signed-off-by Md Sadre Alam <[email protected]>--- drivers/mtd/nand/raw/qcom_nandc.c | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-)drivers/mtd/nand/raw/qcom_nandc.c +2
-1@@ -714,7 +714,8 @@ static void update_rw_regs(struct qcom_nand_host *host, int num_cw, bool read)nandc_set_reg (nandc,NAND_DEV0_CFG0 , cfg0);nandc_set_reg (nandc,NAND_DEV0_CFG1 , cfg1);nandc_set_reg (nandc,NAND_DEV0_ECC_CFG , ecc_bch_cfg); -nandc_set_reg (nandc,NAND_EBI2_ECC_BUF_CFG , host->ecc_buf_cfg); +if (!nandc->props->qpic_v2) +nandc_set_reg (nandc,NAND_EBI2_ECC_BUF_CFG , host->ecc_buf_cfg);nandc_set_reg (nandc,NAND_FLASH_STATUS , host->clrflashstatus);nandc_set_reg (nandc,NAND_READ_STATUS , host->clrreadstatus);drivers/mtd/nand/raw/qcom_nandc.c +2
-1nandc_set_reg (nandc,NAND_EXEC_CMD ,1 );@@ -1083,7 +1084,8 @@ static void config_nand_page_read(struct qcom_nand_controller *nandc) {write_reg_dma (nandc,NAND_ADDR0 ,2 ,0 );write_reg_dma (nandc,NAND_DEV0_CFG0 ,3 ,0 ); -write_reg_dma (nandc,NAND_EBI2_ECC_BUF_CFG ,1 ,0 ); +if (!nandc->props->qpic_v2) +write_reg_dma (nandc,NAND_EBI2_ECC_BUF_CFG ,1 ,0 );write_reg_dma (nandc,NAND_ERASED_CW_DETECT_CFG ,1 ,0 ); write_reg_dma(nandc, NAND_ERASED_CW_DETECT_CFG, 1,drivers/mtd/nand/raw/qcom_nandc.c +3
-2NAND_ERASED_CW_SET | NAND_BAM_NEXT_SGL);@@ -1132,8 +1134,9 @@ static void config_nand_page_write(struct qcom_nand_controller *nandc) {write_reg_dma (nandc,NAND_ADDR0 ,2 ,0 );write_reg_dma (nandc,NAND_DEV0_CFG0 ,3 ,0 ); -write_reg_dma (nandc,NAND_EBI2_ECC_BUF_CFG ,1 , -NAND_BAM_NEXT_SGL ); +if (!nandc->props->qpic_v2) +write_reg_dma (nandc,NAND_EBI2_ECC_BUF_CFG ,1 , +NAND_BAM_NEXT_SGL ); }/*
drivers/mtd/nand/raw/qcom_nandc.c +4
-2@@ -1187,7 +1190,8 @@ static int nandc_param(struct qcom_nand_host > *host) | 2 << WR_RD_BSY_GAP |0 <<WIDE_FLASH | 1 << DEV0_CFG1_ECC_DISABLE); - nandc_set_reg(nandc, NAND_EBI2_ECC_BUF_CFG, 1 << > ECC_CFG_ECC_DISABLE); +if (!nandc->props->qpic_v2) + nandc_set_reg(nandc, NAND_EBI2_ECC_BUF_CFG, 1 << > ECC_CFG_ECC_DISABLE);/* configure CMD1 and VLD for ONFI param probing in QPIC v1 */ if (!nandc->props->qpic_v2) {@@ -2628,7 +2632,8 @@ static int qcom_nand_attach_chip(struct nand_chip > *chip) | ecc_mode << ECC_MODE | host->ecc_bytes_hw <<ECC_PARITY_SIZE_BYTES_BCH ; - host->ecc_buf_cfg =0x203 <<NUM_STEPS ; +if (!nandc->props->qpic_v2) + host->ecc_buf_cfg =0x203 <<NUM_STEPS ;Quoted 5 lines
drivers/mtd/nand/raw/qcom_nandc.c static int qcom_nand_attach_chip(struct nand_chip *chip) · line 2639
Quoted 2 lines
drivers/mtd/nand/raw/qcom_nandc.c +0
-0host->clrflashstatus =FS_READY_BSY_N ; host->clrreadstatus =0xc0 ;ping! Hi Miquel could you review this change and let me know if more info needed.
Quoted 5 lines
Come on, that's only 6 days of work and we are in the middle of the merge window...
BTW "avoid write to" in the title is incorrect "writing to" would be nicer.
Updated commit message in V2 patch.
Quoted 3 lines
Thanks,
Miquèl
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
Quoted 4 lines · Md Sadre Alam
QPIC_EBI2_ECC_BUF_CFGregister got obsolete from QPIC V2.0 onwards. Avoid writing this register if QPIC version is V2.0 or newer.Signed-off-by Md Sadre Alam <[email protected]>
Thanks,
Mani
Quoted 63 lines
--- drivers/mtd/nand/raw/qcom_nandc.c | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-)drivers/mtd/nand/raw/qcom_nandc.c +11
-6@@ -714,7 +714,8 @@ static void update_rw_regs(struct qcom_nand_host *host, int num_cw, bool read)nandc_set_reg (nandc,NAND_DEV0_CFG0 , cfg0);nandc_set_reg (nandc,NAND_DEV0_CFG1 , cfg1);nandc_set_reg (nandc,NAND_DEV0_ECC_CFG , ecc_bch_cfg); -nandc_set_reg (nandc,NAND_EBI2_ECC_BUF_CFG , host->ecc_buf_cfg); +if (!nandc->props->qpic_v2) +nandc_set_reg (nandc,NAND_EBI2_ECC_BUF_CFG , host->ecc_buf_cfg);nandc_set_reg (nandc,NAND_FLASH_STATUS , host->clrflashstatus);nandc_set_reg (nandc,NAND_READ_STATUS , host->clrreadstatus);nandc_set_reg (nandc,NAND_EXEC_CMD ,1 );@@ -1083,7 +1084,8 @@ static void config_nand_page_read(struct qcom_nand_controller *nandc) {write_reg_dma (nandc,NAND_ADDR0 ,2 ,0 );write_reg_dma (nandc,NAND_DEV0_CFG0 ,3 ,0 ); -write_reg_dma (nandc,NAND_EBI2_ECC_BUF_CFG ,1 ,0 ); +if (!nandc->props->qpic_v2) +write_reg_dma (nandc,NAND_EBI2_ECC_BUF_CFG ,1 ,0 );write_reg_dma (nandc,NAND_ERASED_CW_DETECT_CFG ,1 ,0 );write_reg_dma (nandc,NAND_ERASED_CW_DETECT_CFG ,1 ,NAND_ERASED_CW_SET |NAND_BAM_NEXT_SGL );@@ -1132,8 +1134,9 @@ static void config_nand_page_write(struct qcom_nand_controller *nandc) {write_reg_dma (nandc,NAND_ADDR0 ,2 ,0 );write_reg_dma (nandc,NAND_DEV0_CFG0 ,3 ,0 ); -write_reg_dma (nandc,NAND_EBI2_ECC_BUF_CFG ,1 , -NAND_BAM_NEXT_SGL ); +if (!nandc->props->qpic_v2) +write_reg_dma (nandc,NAND_EBI2_ECC_BUF_CFG ,1 , +NAND_BAM_NEXT_SGL ); }/* @@ -1187,7 +1190,8 @@ static int nandc_param(struct qcom_nand_host *host) | 2 << WR_RD_BSY_GAP |0 <<WIDE_FLASH | 1 << DEV0_CFG1_ECC_DISABLE); -nandc_set_reg (nandc,NAND_EBI2_ECC_BUF_CFG ,1 <<ECC_CFG_ECC_DISABLE ); +if (!nandc->props->qpic_v2) +nandc_set_reg (nandc,NAND_EBI2_ECC_BUF_CFG ,1 <<ECC_CFG_ECC_DISABLE );/* configure CMD1 and VLD for ONFI param probing in QPIC v1 */ if (!nandc->props->qpic_v2) {@@ -2628,7 +2632,8 @@ static int qcom_nand_attach_chip(struct nand_chip *chip) | ecc_mode << ECC_MODE | host->ecc_bytes_hw <<ECC_PARITY_SIZE_BYTES_BCH ; - host->ecc_buf_cfg =0x203 <<NUM_STEPS ; +if (!nandc->props->qpic_v2) + host->ecc_buf_cfg =0x203 <<NUM_STEPS ; host->clrflashstatus =FS_READY_BSY_N ; host->clrreadstatus =0xc0 ;Signature · 1 line
2.7.4
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/