RDMA/mlx5: Remove redundant assignment to ret
Subsystems (2)
PATCH 1/1 RDMA/mlx5: Remove redundant assignment to ret
Variable 'ret' is set to the rerurn value of function mlx5_mr_cache_alloc() but this value is never read as it is overwritten with a new value later on, hence it is a redundant assignment and can be removed
Clean up the following clang-analyzer warning:
drivers/infiniband/hw/mlx5/odp.c:421:2: warning: Value stored to 'ret' is never read [clang-analyzer-deadcode.DeadStores]
--- drivers/infiniband/hw/mlx5/odp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/infiniband/hw/mlx5/odp.c +1 -1
@@ -418,7 +418,7 @@ static struct mlx5_ib_mr *implicit_get_child_mr(struct mlx5_ib_mr *imr,if (IS_ERR (odp))return ERR_CAST (odp); - ret = mr =mlx5_mr_cache_alloc ( + mr =mlx5_mr_cache_alloc (mr_to_mdev (imr),MLX5_IMR_MTT_CACHE_ENTRY , imr->access_flags);if (IS_ERR (mr)) {ib_umem_odp_release (odp);
Signature · 1 line
1.8.3.1
Quoted 7 lines · Yang Li
Variable 'ret' is set to the rerurn value of function
mlx5_mr_cache_alloc()but this value is never read as it is overwritten with a new value later on, hence it is a redundant assignment and can be removedClean up the following clang-analyzer warning:
Quoted 9 lines
drivers/infiniband/hw/mlx5/odp.c:421:2: warning: Value stored to 'ret' is never read [clang-analyzer-deadcode.DeadStores]Reported-by Abaci Robot <[email protected]>Signed-off-by Yang Li <[email protected]>--- drivers/infiniband/hw/mlx5/odp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Thanks,
Quoted 10 lines · Yang Li
Variable 'ret' is set to the rerurn value of function
mlx5_mr_cache_alloc()but this value is never read as it is overwritten with a new value later on, hence it is a redundant assignment and can be removedClean up the following clang-analyzer warning:
drivers/infiniband/hw/mlx5/odp.c:421:2: warning: Value stored to 'ret' is never read [clang-analyzer-deadcode.DeadStores]
Quoted 6 lines
Reported-by Abaci Robot <[email protected]>Signed-off-by Yang Li <[email protected]>Reviewed-by Leon Romanovsky <[email protected]>--- drivers/infiniband/hw/mlx5/odp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to for-next, thanks
Jason