Skip to contentSkip to conversation

spi: altera: Remove redundant dev_err call in dfl_spi_altera_probe()

PATCH In review Zou Wei 2 participants 2 messages May 11, 2021 SPI

lore
Share & tools
lore

Zou Wei

author
#0 lore raw

PATCH 1/1 spi: altera: Remove redundant dev_err call in dfl_spi_altera_probe()

There is a error message within devm_ioremap_resource already, so remove the dev_err call to avoid redundant error message.

---
 drivers/spi/spi-altera-dfl.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/spi/spi-altera-dfl.c +1 -3
index 3e32e4f..39a3e1a 100644
@@ -148,10 +148,8 @@ static int dfl_spi_altera_probe(struct dfl_device *dfl_dev)
 
 	base = devm_ioremap_resource(dev, &dfl_dev->mmio_res);
 
-	if (IS_ERR(base)) {
-		dev_err(dev, "%s get mem resource fail!\n", __func__);
+	if (IS_ERR(base))
 		return PTR_ERR(base);
-	}
 
 	config_spi_master(base, master);
 	dev_dbg(dev, "%s cs %u bpm 0x%x mode 0x%x\n", __func__,
Signature · 1 line
2.6.2
maintainer
#1 lore raw
Quoted 3 lines · Zou Wei

There is a error message within devm_ioremap_resource already, so remove the dev_err call to avoid redundant error message.

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[1/1] spi: altera: Remove redundant dev_err call in dfl_spi_altera_probe()

      commit: 532259bfd1c12d561215c32b94cd9bb7c997bc6f

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark