patch "serial: tegra: Fix a mask operation that is always true" added to tty-linus
Subsystems (4)
This is a note to let you know that I've just added the patch titled
serial: tegra: Fix a mask operation that is always true
to my tty git tree which can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git
in the tty-linus branch.
The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.)
The patch will hopefully also be merged in Linus's tree for the next -rc kernel release.
If you have any questions about this process, please let me know.
From 3ddb4ce1e6e3bd112778ab93bbd9092f23a878ec Mon Sep 17 00:00:00 2001
From: Colin Ian King <[email protected]>
Date: Mon, 26 Apr 2021 11:55:14 +0100
Subject: serial: tegra: Fix a mask operation that is always true
Currently the expression lsr | UART_LSR_TEMT is always true and this seems suspect. I believe the intent was to mask lsr with UART_LSR_TEMT to check that bit, so the expression should be using the & operator instead. Fix this.
--- drivers/tty/serial/serial-tegra.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/tty/serial/serial-tegra.c +1 -1
@@ -338,7 +338,7 @@ static void tegra_uart_fifo_reset(struct tegra_uart_port *tup, u8 fcr_bits)do { lsr =tegra_uart_read (tup,UART_LSR ); -if ((lsr |UART_LSR_TEMT ) && !(lsr &UART_LSR_DR )) +if ((lsr &UART_LSR_TEMT ) && !(lsr &UART_LSR_DR ))break ;udelay (1 ); }while (--tmout);
Signature · 1 line
2.31.1