patch "misc: eeprom: at24: check suspend status before disable regulator" added to char-misc-linus
Subsystems (2)
This is a note to let you know that I've just added the patch titled
misc: eeprom: at24: check suspend status before disable regulator
to my char-misc git tree which can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git
in the char-misc-linus branch.
The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.)
The patch will hopefully also be merged in Linus's tree for the next -rc kernel release.
If you have any questions about this process, please let me know.
From 2962484dfef8dbb7f9059822bc26ce8a04d0e47c Mon Sep 17 00:00:00 2001
From: Hsin-Yi Wang <[email protected]>
Date: Tue, 20 Apr 2021 21:30:50 +0800
Subject: misc: eeprom: at24: check suspend status before disable regulator
cd5676db0574 ("misc: eeprom: at24: support pm_runtime control") disables regulator in runtime suspend. If runtime suspend is called before regulator disable, it will results in regulator unbalanced disabling.
--- drivers/misc/eeprom/at24.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/misc/eeprom/at24.c +4 -2
@@ -763,7 +763,8 @@ static int at24_probe(struct i2c_client *client) at24->nvmem =devm_nvmem_register (dev, &nvmem_config);if (IS_ERR (at24->nvmem)) {pm_runtime_disable (dev); -regulator_disable (at24->vcc_reg); +if (!pm_runtime_status_suspended (dev)) +regulator_disable (at24->vcc_reg);return PTR_ERR (at24->nvmem); }
@@ -774,7 +775,8 @@ static int at24_probe(struct i2c_client *client) err =at24_read (at24,0 , &test_byte,1 );if (err) {pm_runtime_disable (dev); -regulator_disable (at24->vcc_reg); +if (!pm_runtime_status_suspended (dev)) +regulator_disable (at24->vcc_reg);return -ENODEV ; }
Signature · 1 line
2.31.1