Skip to contentSkip to conversation

platform/x86: thinkpad_acpi: Fix inconsistent indenting

PATCH Superseded Jiapeng Chong 2 participants 2 messages May 21, 2021

Subsystems (2)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 platform/x86: thinkpad_acpi: Fix inconsistent indenting

Eliminate the follow smatch warning:

drivers/platform/x86/thinkpad_acpi.c:7942 volume_write() warn:
inconsistent indenting.

---
 drivers/platform/x86/thinkpad_acpi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/platform/x86/thinkpad_acpi.c +1 -1
index dd60c93..d0aa566 100644
@@ -7939,7 +7939,7 @@ static int volume_write(char *buf)
 			} else if (sscanf(cmd, "level %u", &l) == 1 &&
 				   l >= 0 && l <= TP_EC_VOLUME_MAX) {
 					new_level = l;
-				continue;
+					continue;
 			}
 		}
 		if (strlencmp(cmd, "mute") == 0)
Signature · 1 line
1.8.3.1
#1 lore raw

Hi,

Quoted 16 lines · Jiapeng Chong

Eliminate the follow smatch warning:

drivers/platform/x86/thinkpad_acpi.c:7942 volume_write() warn:
inconsistent indenting.

---
 drivers/platform/x86/thinkpad_acpi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/platform/x86/thinkpad_acpi.c +0 -0
index dd60c93..d0aa566 100644

drivers/platform/x86/thinkpad_acpi.c static int volume_write(char *buf) · line 7945

Quoted 8 lines
drivers/platform/x86/thinkpad_acpi.c +1 -1
@@ -7939,7 +7939,7 @@ static int volume_write(char *buf)
 			} else if (sscanf(cmd, "level %u", &l) == 1 &&
 				   l >= 0 && l <= TP_EC_VOLUME_MAX) {
 					new_level = l;
-				continue;
+					continue;
 			}
 		}
 		if (strlencmp(cmd, "mute") == 0)

Thank you for your patch, but actually the indentation of the "new_level = l;" is wrong, it is indented one level too much.

Please send a new version changing (reducing) the indentation of the "new_level = l;" statement instead.

Regards,

Hans