patch "usb: typec: tcpm: Use LE to CPU conversion when accessing msg->header" added to usb-linus
Subsystems (4)
This is a note to let you know that I've just added the patch titled
usb: typec: tcpm: Use LE to CPU conversion when accessing msg->header
to my usb git tree which can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
in the usb-linus branch.
The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.)
The patch will hopefully also be merged in Linus's tree for the next -rc kernel release.
If you have any questions about this process, please let me know.
From c58bbe3477f75deb7883983e6cf428404a107555 Mon Sep 17 00:00:00 2001
From: Andy Shevchenko <[email protected]>
Date: Wed, 19 May 2021 13:03:58 +0300
Subject: usb: typec: tcpm: Use LE to CPU conversion when accessing msg->header
Sparse is not happy about strict type handling:
.../typec/tcpm/tcpm.c:2720:27: warning: restricted __le16 degrades to integer .../typec/tcpm/tcpm.c:2814:32: warning: restricted __le16 degrades to integer
Fix this by converting LE to CPU before use.
--- drivers/usb/typec/tcpm/tcpm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/usb/typec/tcpm/tcpm.c +2 -2
@@ -2717,7 +2717,7 @@ static void tcpm_pd_ext_msg_request(struct tcpm_port *port,enum pd_ext_msg_type type =pd_header_type_le (msg->header);unsigned int data_size =pd_ext_header_data_size_le (msg->ext_msg.header); -if (!(msg->ext_msg.header &PD_EXT_HDR_CHUNKED )) { +if (!(le16_to_cpu (msg->ext_msg.header) &PD_EXT_HDR_CHUNKED )) {tcpm_pd_handle_msg (port,PD_MSG_CTRL_NOT_SUPP ,NONE_AMS );tcpm_log (port,"Unchunked extended messages unsupported" );return ;
@@ -2811,7 +2811,7 @@ static void tcpm_pd_rx_handler(struct kthread_work *work) "Data role mismatch, initiating error recovery");tcpm_set_state (port,ERROR_RECOVERY ,0 ); }else { -if (msg->header &PD_HEADER_EXT_HDR ) +if (le16_to_cpu (msg->header) &PD_HEADER_EXT_HDR )tcpm_pd_ext_msg_request (port, msg);else if (cnt)tcpm_pd_data_request (port, msg);
Signature · 1 line
2.31.1