Skip to contentSkip to conversation

Add PMIC DT files for sc7280

PATCH Applied satya priya 4 participants 20 messages May 25, 2021 – Jun 1, 2021

Subsystems (5)
Device tree bindings Arm Qualcomm mailing list Arm Qualcomm support Multifunction devices (MFD) +1 more subsystems
lore
Share & tools
lore

satya priya

author
#0 lore raw

v5 cover Add PMIC DT files for sc7280

This series depends on https://patchwork.kernel.org/project/linux-arm-msm/list/?series=478225
which adds therml-zones node.

Changes in V2:
- As per Matthias comments:
- I've Split the patch into per-PMIC patches and one sc7280 patch
- Removed 2nd critical point, thermal-governer property
- s/pm8325_tz/pm7325_temp_alarm and s/pm7325_temp_alarm/pm7325_thermal
- Fixed few other minor errors.

- As per Bjorn's comments, replaced '_' with '-' in node names and moved DT files inclusion to board dts.

Changes in V3:
- As per Matthias comments, changed commit text, modified critical interrupt node name like <name>-crit for all pmics.
- Moved pmk8350_vadc channel nodes to idp dts, as it is not guaranteed that a board with the pmk8350 will always have the other 3 PMICs

Changes in V4:
- PMR735A and PM8350C PMICS are used in sm8350 SoC. Added thermal_zones label for thermal-zones node to avoid compilation error while using the phandle in pmic dt files.
- As per Matthias comments:
- Changed commit text for pmk8350 pmic patch
- Moved the header files inclusion for the on die tempertures of PMICs from

    pmk8350 dt file to sc7280-idp dts
  - Changed commit text and made a dedicated patch to include pmic dt files
    for sc7280-idp

- Made separate patches for on die temp channel nodes and for adding thermal- zones node in sc7280 SoC dtsi

satya priya (11):
arm64: dts: qcom: sm8350: Add label for thermal-zones node
arm64: dts: qcom: pm7325: Add pm7325 base dts file
arm64: dts: qcom: pm8350c: Add temp-alarm support
arm64: dts: qcom: pm8350c: Correct the GPIO node
arm64: dts: qcom: pmr735a: Add temp-alarm support
arm64: dts: qcom: pmr735a: Correct the GPIO node
arm64: dts: qcom: pmk8350: Add peripherals for pmk8350
arm64: dts: qcom: pmk8350: Correct the GPIO node
arm64: dts: qcom: sc7280: Include PMIC DT files for sc7280-idp
arm64: dts: qcom: sc7280: Add ADC channel nodes for PMIC temperatures

    to sc7280-idp

mfd: qcom-spmi-pmic: Add support for four variants

 .../devicetree/bindings/mfd/qcom,spmi-pmic.txt     |  4 ++
 arch/arm64/boot/dts/qcom/pm7325.dtsi               | 53 ++++++++++++++++++++++
 arch/arm64/boot/dts/qcom/pm8350c.dtsi              | 32 ++++++++++++-
 arch/arm64/boot/dts/qcom/pmk8350.dtsi              | 51 ++++++++++++++++++++-
 arch/arm64/boot/dts/qcom/pmr735a.dtsi              | 32 ++++++++++++-
 arch/arm64/boot/dts/qcom/sc7280-idp.dts            | 34 ++++++++++++++
 arch/arm64/boot/dts/qcom/sm8350.dtsi               |  2 +-
 7 files changed, 204 insertions(+), 4 deletions(-)
 create mode 100644 arch/arm64/boot/dts/qcom/pm7325.dtsi
Signature · 2 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member 
of Code Aurora Forum, hosted by The Linux Foundation
author
#1 lore raw

PATCH v5 1/11 arm64: dts: qcom: sm8350: Add label for thermal-zones node

Add label "thermal_zones" for thermal-zones node.

Signed-off-by satya priya <[email protected]>
Reviewed-by Matthias Kaehlcke <[email protected]>

---
Changes in RESEND V4:
- No Changes.

Changes in V5:
- No Changes.

 arch/arm64/boot/dts/qcom/sm8350.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/qcom/sm8350.dtsi +1 -1
index ed0b51b..47c6c0b 100644
@@ -1317,7 +1317,7 @@
 		};
 	};
 
-	thermal-zones {
+	thermal_zones: thermal-zones {
 		cpu0-thermal {
 			polling-delay-passive = <250>;
 			polling-delay = <1000>;
Signature · 2 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member 
of Code Aurora Forum, hosted by The Linux Foundation
author
#2 lore raw

PATCH v5 2/11 arm64: dts: qcom: pm7325: Add pm7325 base dts file

In reply to satya priya

Add base DTS file for pm7325 along with GPIOs and temp-alarm nodes.

Signed-off-by satya priya <[email protected]>
Reviewed-by Matthias Kaehlcke <[email protected]>

---
Changes in RESEND V4:
- No Changes.

Changes in V5:
- No Changes.

 arch/arm64/boot/dts/qcom/pm7325.dtsi | 53 ++++++++++++++++++++++++++++++++++++
 1 file changed, 53 insertions(+)
 create mode 100644 arch/arm64/boot/dts/qcom/pm7325.dtsi
arch/arm64/boot/dts/qcom/pm7325.dtsi new file +53 -0
new file mode 100644
index 0000000..e7f64a9
@@ -0,0 +1,53 @@
+// SPDX-License-Identifier: BSD-3-Clause
+// Copyright (c) 2021, The Linux Foundation. All rights reserved.
+
+#include <dt-bindings/interrupt-controller/irq.h>
+#include <dt-bindings/spmi/spmi.h>
+
+&spmi_bus {
+	pm7325: pmic@1 {
+		compatible = "qcom,pm7325", "qcom,spmi-pmic";
+		reg = <0x1 SPMI_USID>;
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		pm7325_temp_alarm: temp-alarm@a00 {
+			compatible = "qcom,spmi-temp-alarm";
+			reg = <0xa00>;
+			interrupts = <0x1 0xa 0x0 IRQ_TYPE_EDGE_BOTH>;
+			#thermal-sensor-cells = <0>;
+		};
+
+		pm7325_gpios: gpios@8800 {
+			compatible = "qcom,pm7325-gpio", "qcom,spmi-gpio";
+			reg = <0x8800>;
+			gpio-controller;
+			gpio-ranges = <&pm7325_gpios 0 0 10>;
+			#gpio-cells = <2>;
+			interrupt-controller;
+			#interrupt-cells = <2>;
+		};
+	};
+};
+
+&thermal_zones {
+	pm7325_thermal: pm7325-thermal {
+		polling-delay-passive = <100>;
+		polling-delay = <0>;
+		thermal-sensors = <&pm7325_temp_alarm>;
+
+		trips {
+			pm7325_trip0: trip0 {
+				temperature = <95000>;
+				hysteresis = <0>;
+				type = "passive";
+			};
+
+			pm7325_crit: pm7325-crit {
+				temperature = <115000>;
+				hysteresis = <0>;
+				type = "critical";
+			};
+		};
+	};
+};
Signature · 2 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member 
of Code Aurora Forum, hosted by The Linux Foundation
author
#3 lore raw

PATCH v5 3/11 arm64: dts: qcom: pm8350c: Add temp-alarm support

In reply to satya priya

Add temp-alarm support for PM8350C pmic.

Signed-off-by satya priya <[email protected]>
Reviewed-by Matthias Kaehlcke <[email protected]>

---
Changes in RESEND V4:
- No Changes.

Changes in V5:
- Split this patch into two. One for adding temp-alarm support and next one to correct GPIO node.

 arch/arm64/boot/dts/qcom/pm8350c.dtsi | 29 +++++++++++++++++++++++++++++
 1 file changed, 29 insertions(+)
arch/arm64/boot/dts/qcom/pm8350c.dtsi +29 -0
index 2b9b75e..f926508 100644
@@ -13,6 +13,13 @@
 		#address-cells = <1>;
 		#size-cells = <0>;
 
+		pm8350c_temp_alarm: temp-alarm@a00 {
+			compatible = "qcom,spmi-temp-alarm";
+			reg = <0xa00>;
+			interrupts = <0x2 0xa 0x0 IRQ_TYPE_EDGE_BOTH>;
+			#thermal-sensor-cells = <0>;
+		};
+
 		pm8350c_gpios: gpio@8800 {
 			compatible = "qcom,pm8350c-gpio";
 			reg = <0x8800>;

@@ -23,3 +30,25 @@
 		};
 	};
 };
+
+&thermal_zones {
+	pm8350c_thermal: pm8350c-thermal {
+		polling-delay-passive = <100>;
+		polling-delay = <0>;
+		thermal-sensors = <&pm8350c_temp_alarm>;
+
+		trips {
+			pm8350c_trip0: trip0 {
+				temperature = <95000>;
+				hysteresis = <0>;
+				type = "passive";
+			};
+
+			pm8350c_crit: pm8350c-crit {
+				temperature = <115000>;
+				hysteresis = <0>;
+				type = "critical";
+			};
+		};
+	};
+};
Signature · 2 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member 
of Code Aurora Forum, hosted by The Linux Foundation
author
#4 lore raw

PATCH v5 4/11 arm64: dts: qcom: pm8350c: Correct the GPIO node

In reply to satya priya

Add gpio ranges and correct the compatible to add
"qcom,spmi-gpio" as this pmic is on spmi bus.

Signed-off-by satya priya <[email protected]>

---
Changes in V5:
- This is split from patch [3/11] and added newly in V5.

 arch/arm64/boot/dts/qcom/pm8350c.dtsi | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
arch/arm64/boot/dts/qcom/pm8350c.dtsi +2 -1
index f926508..e1b75ae 100644
@@ -21,9 +21,10 @@
 		};
 
 		pm8350c_gpios: gpio@8800 {
-			compatible = "qcom,pm8350c-gpio";
+			compatible = "qcom,pm8350c-gpio", "qcom,spmi-gpio";
 			reg = <0x8800>;
 			gpio-controller;
+			gpio-ranges = <&pm8350c_gpios 0 0 9>;
 			#gpio-cells = <2>;
 			interrupt-controller;
 			#interrupt-cells = <2>;
Signature · 2 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member 
of Code Aurora Forum, hosted by The Linux Foundation
Reviewed-by on v5 4/11
#5 lore raw

Re: [PATCH V5 04/11] arm64: dts: qcom: pm8350c: Correct the GPIO node

Quoted 7 lines · satya priya

Add gpio ranges and correct the compatible to add
"qcom,spmi-gpio" as this pmic is on spmi bus.

Signed-off-by satya priya <[email protected]>

---
Changes in V5:
- This is split from patch [3/11] and added newly in V5.

isn't the split from patch [4/8]?

https://patchwork.kernel.org/project/linux-arm-msm/patch/[email protected]/

Quoted 9 lines
 arch/arm64/boot/dts/qcom/pm8350c.dtsi | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
arch/arm64/boot/dts/qcom/pm8350c.dtsi +0 -0
index f926508..e1b75ae 100644
@@ -21,9 +21,10 @@
 		};

arch/arm64/boot/dts/qcom/pm8350c.dtsi line 30

Quoted 10 lines
arch/arm64/boot/dts/qcom/pm8350c.dtsi +2 -1
 
 		pm8350c_gpios: gpio@8800 {
-			compatible = "qcom,pm8350c-gpio";
+			compatible = "qcom,pm8350c-gpio", "qcom,spmi-gpio";
 			reg = <0x8800>;
 			gpio-controller;
+			gpio-ranges = <&pm8350c_gpios 0 0 9>;
 			#gpio-cells = <2>;
 			interrupt-controller;
 			#interrupt-cells = <2>;
Reviewed-by Matthias Kaehlcke <[email protected]>
author
#6 lore raw

PATCH v5 5/11 arm64: dts: qcom: pmr735a: Add temp-alarm support

In reply to satya priya

Add temp-alarm support for PMR735A pmic.

Signed-off-by satya priya <[email protected]>
Reviewed-by Matthias Kaehlcke <[email protected]>

---
Changes in RESEND V4:
- No Changes.

Changes in V5:
- Split this patch into two. One for adding temp-alarm support and next one to correct GPIO node.

 arch/arm64/boot/dts/qcom/pmr735a.dtsi | 29 +++++++++++++++++++++++++++++
 1 file changed, 29 insertions(+)
arch/arm64/boot/dts/qcom/pmr735a.dtsi +29 -0
index 1c675af1..b0a7cd6c0 100644
@@ -13,6 +13,13 @@
 		#address-cells = <1>;
 		#size-cells = <0>;
 
+		pmr735a_temp_alarm: temp-alarm@a00 {
+			compatible = "qcom,spmi-temp-alarm";
+			reg = <0xa00>;
+			interrupts = <0x4 0xa 0x0 IRQ_TYPE_EDGE_BOTH>;
+			#thermal-sensor-cells = <0>;
+		};
+
 		pmr735a_gpios: gpio@8800 {
 			compatible = "qcom,pmr735a-gpio";
 			reg = <0x8800>;

@@ -23,3 +30,25 @@
 		};
 	};
 };
+
+&thermal_zones {
+	pmr735a_thermal: pmr735a-thermal {
+		polling-delay-passive = <100>;
+		polling-delay = <0>;
+		thermal-sensors = <&pmr735a_temp_alarm>;
+
+		trips {
+			pmr735a_trip0: trip0 {
+				temperature = <95000>;
+				hysteresis = <0>;
+				type = "passive";
+			};
+
+			pmr735a_crit: pmr735a-crit {
+				temperature = <115000>;
+				hysteresis = <0>;
+				type = "critical";
+			};
+		};
+	};
+};
Signature · 2 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member 
of Code Aurora Forum, hosted by The Linux Foundation
author
#7 lore raw

PATCH v5 6/11 arm64: dts: qcom: pmr735a: Correct the GPIO node

In reply to satya priya

Add gpio ranges and correct the compatible to add
"qcom,spmi-gpio" as this pmic is on spmi bus.

Signed-off-by satya priya <[email protected]>

---
Changes in V5:
- This is split from patch [5/11] and added newly in V5.

 arch/arm64/boot/dts/qcom/pmr735a.dtsi | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
arch/arm64/boot/dts/qcom/pmr735a.dtsi +2 -1
index b0a7cd6c0..b4b6ba24 100644
@@ -21,9 +21,10 @@
 		};
 
 		pmr735a_gpios: gpio@8800 {
-			compatible = "qcom,pmr735a-gpio";
+			compatible = "qcom,pmr735a-gpio", "qcom,spmi-gpio";
 			reg = <0x8800>;
 			gpio-controller;
+			gpio-ranges = <&pmr735a_gpios 0 0 4>;
 			#gpio-cells = <2>;
 			interrupt-controller;
 			#interrupt-cells = <2>;
Signature · 2 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member 
of Code Aurora Forum, hosted by The Linux Foundation
Reviewed-by on v5 6/11
#8 lore raw

Re: [PATCH V5 06/11] arm64: dts: qcom: pmr735a: Correct the GPIO node

Quoted 7 lines · satya priya

Add gpio ranges and correct the compatible to add
"qcom,spmi-gpio" as this pmic is on spmi bus.

Signed-off-by satya priya <[email protected]>

---
Changes in V5:
- This is split from patch [5/11] and added newly in V5.

actually it's a split from patch [5/8], right?

https://patchwork.kernel.org/project/linux-arm-msm/patch/[email protected]/

Quoted 9 lines
 arch/arm64/boot/dts/qcom/pmr735a.dtsi | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
arch/arm64/boot/dts/qcom/pmr735a.dtsi +0 -0
index b0a7cd6c0..b4b6ba24 100644
@@ -21,9 +21,10 @@
 		};

arch/arm64/boot/dts/qcom/pmr735a.dtsi line 30

Quoted 10 lines
arch/arm64/boot/dts/qcom/pmr735a.dtsi +2 -1
 
 		pmr735a_gpios: gpio@8800 {
-			compatible = "qcom,pmr735a-gpio";
+			compatible = "qcom,pmr735a-gpio", "qcom,spmi-gpio";
 			reg = <0x8800>;
 			gpio-controller;
+			gpio-ranges = <&pmr735a_gpios 0 0 4>;
 			#gpio-cells = <2>;
 			interrupt-controller;
 			#interrupt-cells = <2>;
Reviewed-by Matthias Kaehlcke <[email protected]>
author
#9 lore raw

Re: [PATCH V5 06/11] arm64: dts: qcom: pmr735a: Correct the GPIO node

Quoted 11 lines · Matthias Kaehlcke
Quoted 7 lines · satya priya

Add gpio ranges and correct the compatible to add
"qcom,spmi-gpio" as this pmic is on spmi bus.

Signed-off-by satya priya <[email protected]>

---
Changes in V5:
- This is split from patch [5/11] and added newly in V5.

actually it's a split from patch [5/8], right?

Right, my bad. I should have mentioned this way to be more clear. Thank you for reviewing the patches!

Quoted 23 lines

https://patchwork.kernel.org/project/linux-arm-msm/patch/[email protected]/

Quoted 9 lines
 arch/arm64/boot/dts/qcom/pmr735a.dtsi | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
arch/arm64/boot/dts/qcom/pmr735a.dtsi +0 -0
index b0a7cd6c0..b4b6ba24 100644
@@ -21,9 +21,10 @@
 		};

arch/arm64/boot/dts/qcom/pmr735a.dtsi line 30

Quoted 10 lines
arch/arm64/boot/dts/qcom/pmr735a.dtsi +2 -1
 
 		pmr735a_gpios: gpio@8800 {
-			compatible = "qcom,pmr735a-gpio";
+			compatible = "qcom,pmr735a-gpio", "qcom,spmi-gpio";
 			reg = <0x8800>;
 			gpio-controller;
+			gpio-ranges = <&pmr735a_gpios 0 0 4>;
 			#gpio-cells = <2>;
 			interrupt-controller;
 			#interrupt-cells = <2>;
Reviewed-by Matthias Kaehlcke <[email protected]>
author
#10 lore raw

PATCH v5 7/11 arm64: dts: qcom: pmk8350: Add peripherals for pmk8350

In reply to satya priya

Add PON, RTC, VADC and ACD_TM support for PMK8350.

Signed-off-by satya priya <[email protected]>
Reviewed-by Matthias Kaehlcke <[email protected]>

---
Changes in RESEND V4:
- No Changes.

Changes in V5:
- Split this patch into two. One for adding pmk8350 peripherals and next one to correct GPIO node.

 arch/arm64/boot/dts/qcom/pmk8350.dtsi | 48 +++++++++++++++++++++++++++++++++++
 1 file changed, 48 insertions(+)
arch/arm64/boot/dts/qcom/pmk8350.dtsi +48 -0
index 1530b8f..ecd5ccd 100644
@@ -3,6 +3,8 @@
  * Copyright (c) 2021, Linaro Limited
  */
 
+#include <dt-bindings/input/input.h>
+#include <dt-bindings/input/linux-event-codes.h>
 #include <dt-bindings/interrupt-controller/irq.h>
 #include <dt-bindings/spmi/spmi.h>
 

@@ -13,6 +15,52 @@
 		#address-cells = <1>;
 		#size-cells = <0>;
 
+		pmk8350_pon: pon@1300 {
+			compatible = "qcom,pm8998-pon";
+			reg = <0x1300>;
+
+			pwrkey {
+				compatible = "qcom,pmk8350-pwrkey";
+				interrupts = <0x0 0x13 0x7 IRQ_TYPE_EDGE_BOTH>;
+				linux,code = <KEY_POWER>;
+			};
+
+			resin {
+				compatible = "qcom,pmk8350-resin";
+				interrupts = <0x0 0x13 0x6 IRQ_TYPE_EDGE_BOTH>;
+				linux,code = <KEY_VOLUMEDOWN>;
+			};
+		};
+
+		pmk8350_vadc: adc@3100 {
+			compatible = "qcom,spmi-adc7";
+			reg = <0x3100>;
+			#address-cells = <1>;
+			#size-cells = <0>;
+			interrupts = <0x0 0x31 0x0 IRQ_TYPE_EDGE_RISING>;
+			interrupt-names = "eoc-int-en-set";
+			#io-channel-cells = <1>;
+			io-channel-ranges;
+		};
+
+		pmk8350_adc_tm: adc-tm@3400 {
+			compatible = "qcom,adc-tm7";
+			reg = <0x3400>;
+			interrupts = <0x0 0x34 0x0 IRQ_TYPE_EDGE_RISING>;
+			interrupt-names = "threshold";
+			#address-cells = <1>;
+			#size-cells = <0>;
+			#thermal-sensor-cells = <1>;
+			status = "disabled";
+		};
+
+		pmk8350_rtc: rtc@6100 {
+			compatible = "qcom,pmk8350-rtc";
+			reg = <0x6100>, <0x6200>;
+			reg-names = "rtc", "alarm";
+			interrupts = <0x0 0x62 0x1 IRQ_TYPE_EDGE_RISING>;
+		};
+
 		pmk8350_gpios: gpio@b000 {
 			compatible = "qcom,pmk8350-gpio";
 			reg = <0xb000>;
Signature · 2 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member 
of Code Aurora Forum, hosted by The Linux Foundation
author
#11 lore raw

PATCH v5 8/11 arm64: dts: qcom: pmk8350: Correct the GPIO node

In reply to satya priya

Add gpio ranges and correct the compatible to add
"qcom,spmi-gpio" as this pmic is on spmi bus.

Signed-off-by satya priya <[email protected]>

---
Changes in V5:
- This is split from patch [7/11] and added newly in V5.

 arch/arm64/boot/dts/qcom/pmk8350.dtsi | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
arch/arm64/boot/dts/qcom/pmk8350.dtsi +2 -1
index ecd5ccd..04fc263 100644
@@ -62,9 +62,10 @@
 		};
 
 		pmk8350_gpios: gpio@b000 {
-			compatible = "qcom,pmk8350-gpio";
+			compatible = "qcom,pmk8350-gpio", "qcom,spmi-gpio";
 			reg = <0xb000>;
 			gpio-controller;
+			gpio-ranges = <&pmk8350_gpios 0 0 4>;
 			#gpio-cells = <2>;
 			interrupt-controller;
 			#interrupt-cells = <2>;
Signature · 2 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member 
of Code Aurora Forum, hosted by The Linux Foundation
Reviewed-by on v5 8/11
#12 lore raw

Re: [PATCH V5 08/11] arm64: dts: qcom: pmk8350: Correct the GPIO node

Quoted 7 lines · satya priya

Add gpio ranges and correct the compatible to add
"qcom,spmi-gpio" as this pmic is on spmi bus.

Signed-off-by satya priya <[email protected]>

---
Changes in V5:
- This is split from patch [7/11] and added newly in V5.

this should say 'patch [6/8]' I think.

https://patchwork.kernel.org/project/linux-arm-msm/patch/[email protected]/

Quoted 9 lines
 arch/arm64/boot/dts/qcom/pmk8350.dtsi | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
arch/arm64/boot/dts/qcom/pmk8350.dtsi +0 -0
index ecd5ccd..04fc263 100644
@@ -62,9 +62,10 @@
 		};

arch/arm64/boot/dts/qcom/pmk8350.dtsi line 71

Quoted 10 lines
arch/arm64/boot/dts/qcom/pmk8350.dtsi +2 -1
 
 		pmk8350_gpios: gpio@b000 {
-			compatible = "qcom,pmk8350-gpio";
+			compatible = "qcom,pmk8350-gpio", "qcom,spmi-gpio";
 			reg = <0xb000>;
 			gpio-controller;
+			gpio-ranges = <&pmk8350_gpios 0 0 4>;
 			#gpio-cells = <2>;
 			interrupt-controller;
 			#interrupt-cells = <2>;
Reviewed-by Matthias Kaehlcke <[email protected]>
author
#13 lore raw

PATCH v5 9/11 arm64: dts: qcom: sc7280: Include PMIC DT files for sc7280-idp

In reply to satya priya

The sc7280-idp has four PMICs, include their .dtsi files.

Signed-off-by satya priya <[email protected]>

---
Changes in RESEND V4:
- As per Matthias comments moved this patch before 'Add ADC channel nodes for PMIC temperatures to sc7280-idp'

Changes in V5:
- No changes.

 arch/arm64/boot/dts/qcom/sc7280-idp.dts | 4 ++++
 1 file changed, 4 insertions(+)
arch/arm64/boot/dts/qcom/sc7280-idp.dts +4 -0
index 54d2cb3..f295580 100644
@@ -8,6 +8,10 @@
 /dts-v1/;
 
 #include "sc7280.dtsi"
+#include "pm7325.dtsi"
+#include "pmr735a.dtsi"
+#include "pm8350c.dtsi"
+#include "pmk8350.dtsi"
 
 / {
 	model = "Qualcomm Technologies, Inc. sc7280 IDP platform";
Signature · 2 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member 
of Code Aurora Forum, hosted by The Linux Foundation
Reviewed-by on v5 9/11
#14 lore raw

Re: [PATCH V5 09/11] arm64: dts: qcom: sc7280: Include PMIC DT files for sc7280-idp

Quoted 19 lines · satya priya

The sc7280-idp has four PMICs, include their .dtsi files.

Signed-off-by satya priya <[email protected]>

---
Changes in RESEND V4:
- As per Matthias comments moved this patch before 'Add ADC channel nodes for PMIC temperatures to sc7280-idp'

Changes in V5:
- No changes.

 arch/arm64/boot/dts/qcom/sc7280-idp.dts | 4 ++++
 1 file changed, 4 insertions(+)
arch/arm64/boot/dts/qcom/sc7280-idp.dts +0 -0
index 54d2cb3..f295580 100644

arch/arm64/boot/dts/qcom/sc7280-idp.dts line 17

Quoted 10 lines
arch/arm64/boot/dts/qcom/sc7280-idp.dts +4 -0
@@ -8,6 +8,10 @@
 /dts-v1/;
 
 #include "sc7280.dtsi"
+#include "pm7325.dtsi"
+#include "pmr735a.dtsi"
+#include "pm8350c.dtsi"
+#include "pmk8350.dtsi"
 
 / {
 	model = "Qualcomm Technologies, Inc. sc7280 IDP platform";
Reviewed-by Matthias Kaehlcke <[email protected]>
author
#15 lore raw

PATCH v5 10/11 arm64: dts: qcom: sc7280: Add ADC channel nodes for PMIC temperatures to sc7280-idp

In reply to satya priya

Add channel nodes for the on die temperatures of PMICS pmk8350, pm8350, pmr735a and pmr735b.

Signed-off-by satya priya <[email protected]>
Reviewed-by Matthias Kaehlcke <[email protected]>

---
Changes in RESEND V4:
- As per Matthias comments, changed the commit text.

Changes in V5:
- No Changes.

 arch/arm64/boot/dts/qcom/sc7280-idp.dts | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)
arch/arm64/boot/dts/qcom/sc7280-idp.dts +30 -0
index f295580..704fb9a 100644
@@ -7,6 +7,10 @@
 
 /dts-v1/;
 
+#include <dt-bindings/iio/qcom,spmi-adc7-pmr735a.h>
+#include <dt-bindings/iio/qcom,spmi-adc7-pmr735b.h>
+#include <dt-bindings/iio/qcom,spmi-adc7-pm8350.h>
+#include <dt-bindings/iio/qcom,spmi-adc7-pmk8350.h>
 #include "sc7280.dtsi"
 #include "pm7325.dtsi"
 #include "pmr735a.dtsi"

@@ -238,6 +242,32 @@
 	};
 };
 
+&pmk8350_vadc {
+		pm8350_die_temp {
+			reg = <PM8350_ADC7_DIE_TEMP>;
+			label = "pm8350_die_temp";
+			qcom,pre-scaling = <1 1>;
+		};
+
+		pmk8350_die_temp {
+			reg = <PMK8350_ADC7_DIE_TEMP>;
+			label = "pmk8350_die_temp";
+			qcom,pre-scaling = <1 1>;
+		};
+
+		pmr735a_die_temp {
+			reg = <PMR735A_ADC7_DIE_TEMP>;
+			label = "pmr735a_die_temp";
+			qcom,pre-scaling = <1 1>;
+		};
+
+		pmr735b_die_temp {
+			reg = <PMR735B_ADC7_DIE_TEMP>;
+			label = "pmr735b_die_temp";
+			qcom,pre-scaling = <1 1>;
+		};
+};
+
 &qupv3_id_0 {
 	status = "okay";
 };
Signature · 2 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member 
of Code Aurora Forum, hosted by The Linux Foundation
author
#16 lore raw

PATCH v5 11/11 mfd: qcom-spmi-pmic: Add support for four variants

In reply to satya priya

Add support for pm8350c, pmk8350, pm7325 and pmr735a PMICS.

Signed-off-by satya priya <[email protected]>

---
Changes in V5:
- Newly added in V5 to add documentation support for pmics of this series.

 Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt | 4 ++++
 1 file changed, 4 insertions(+)
Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt +4 -0
index 79367a4..5ef79bf 100644
@@ -34,6 +34,10 @@ Required properties:
                    "qcom,pm8998",
                    "qcom,pmi8998",
                    "qcom,pm8005",
+                   "qcom,pm8350c",
+                   "qcom,pmk8350",
+                   "qcom,pm7325",
+                   "qcom,pmr735a",
                    or generalized "qcom,spmi-pmic".
 - reg:             Specifies the SPMI USID slave address for this device.
                    For more information see:
Signature · 2 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member 
of Code Aurora Forum, hosted by The Linux Foundation
Reviewed-by on v5 11/11
#17 lore raw

Re: [PATCH V5 11/11] mfd: qcom-spmi-pmic: Add support for four variants

Quoted 2 lines · satya priya

Add support for pm8350c, pmk8350, pm7325 and pmr735a PMICS.

Reviewed-by Bjorn Andersson <[email protected]>

@Lee, will you take this patch through the mfd tree?

Regards,
Bjorn

Quoted 27 lines
Signed-off-by satya priya <[email protected]>

---
Changes in V5:
- Newly added in V5 to add documentation support for pmics of this series.

 Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt | 4 ++++
 1 file changed, 4 insertions(+)
Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt +4 -0
index 79367a4..5ef79bf 100644
@@ -34,6 +34,10 @@ Required properties:
                    "qcom,pm8998",
                    "qcom,pmi8998",
                    "qcom,pm8005",
+                   "qcom,pm8350c",
+                   "qcom,pmk8350",
+                   "qcom,pm7325",
+                   "qcom,pmr735a",
                    or generalized "qcom,spmi-pmic".
 - reg:             Specifies the SPMI USID slave address for this device.
                    For more information see:
Signature · 2 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member 
of Code Aurora Forum, hosted by The Linux Foundation
#18 lore raw

Re: [PATCH V5 11/11] mfd: qcom-spmi-pmic: Add support for four variants

Quoted 8 lines · Bjorn Andersson
Quoted 2 lines · satya priya

Add support for pm8350c, pmk8350, pm7325 and pmr735a PMICS.

Reviewed-by Bjorn Andersson <[email protected]>

@Lee, will you take this patch through the mfd tree?

I will.

Not sure if Rob would like to review it too - it's pretty simple.

Quoted 23 lines
Quoted 23 lines
Signed-off-by satya priya <[email protected]>

---
Changes in V5:
- Newly added in V5 to add documentation support for pmics of this series.

 Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt | 4 ++++
 1 file changed, 4 insertions(+)
Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt +4 -0
index 79367a4..5ef79bf 100644
@@ -34,6 +34,10 @@ Required properties:
                    "qcom,pm8998",
                    "qcom,pmi8998",
                    "qcom,pm8005",
+                   "qcom,pm8350c",
+                   "qcom,pmk8350",
+                   "qcom,pm7325",
+                   "qcom,pmr735a",
                    or generalized "qcom,spmi-pmic".
 - reg:             Specifies the SPMI USID slave address for this device.
                    For more information see:
Signature · 4 lines
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
Applied
#19 lore raw

Re: [PATCH V5 11/11] mfd: qcom-spmi-pmic: Add support for four variants

In reply to satya priya
Quoted 9 lines · satya priya

Add support for pm8350c, pmk8350, pm7325 and pmr735a PMICS.

Signed-off-by satya priya <[email protected]>

---
Changes in V5:
- Newly added in V5 to add documentation support for pmics of this series.

 Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt | 4 ++++
 1 file changed, 4 insertions(+)

Applied, thanks.

Signature · 4 lines
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog