arch: Cleanup unused functions

PATCH In review [email protected] 3 participants 6 messages May 30, 2021 – Jun 9, 2021

Subsystems (4)

RISC-V Generic include/asm header files Arm/Allwinner sunXi SoC support Microblaze architecture

lore

Share & tools

lore

[email protected]

author

2021-05-30 04:54 UTC #0 lore raw

v2 cover arch: Cleanup unused functions

From: Guo Ren <[email protected]>

These functions haven't been used, so just remove them. The patch has been tested with riscv, but I only use grep to check the microblaze's.

Changes since v1:
- Separate into two patches
- Add Reviewed-by & Acked-by

Guo Ren (2):
riscv: Cleanup unused functions
microblaze: Cleanup unused functions

 arch/microblaze/include/asm/page.h |  3 ---
 arch/riscv/include/asm/page.h      | 10 ----------
 2 files changed, 13 deletions(-)

Signature · 1 line

2.7.4

[email protected]

author

2021-05-30 04:54 UTC #1 lore raw

PATCH v2 1/2 riscv: Cleanup unused functions

From: Guo Ren <[email protected]>

These functions haven't been used, so just remove them. The patch has been tested with riscv.

Signed-off-by Guo Ren <[email protected]>

Reviewed-by Christoph Hellwig <[email protected]>

Reviewed-by Anup Patel <[email protected]>

Reviewed-by Palmer Dabbelt <[email protected]>

Acked-by Palmer Dabbelt <[email protected]>

---
 arch/riscv/include/asm/page.h | 10 ----------
 1 file changed, 10 deletions(-)

arch/riscv/include/asm/page.h +0 ~~-10~~

index 6a7761c..a1b888f 100644
@@ -37,16 +37,6 @@
 
 #ifndef __ASSEMBLY__
 
-#define PAGE_UP(addr)	(((addr)+((PAGE_SIZE)-1))&(~((PAGE_SIZE)-1)))
-#define PAGE_DOWN(addr)	((addr)&(~((PAGE_SIZE)-1)))
-
-/* align addr on a size boundary - adjust address up/down if needed */
-#define _ALIGN_UP(addr, size)	(((addr)+((size)-1))&(~((size)-1)))
-#define _ALIGN_DOWN(addr, size)	((addr)&(~((size)-1)))
-
-/* align addr on a size boundary - adjust address up if needed */
-#define _ALIGN(addr, size)	_ALIGN_UP(addr, size)
-
 #define clear_page(pgaddr)			memset((pgaddr), 0, PAGE_SIZE)
 #define copy_page(to, from)			memcpy((to), (from), PAGE_SIZE)

Signature · 1 line

2.7.4

Palmer Dabbelt

2021-06-09 00:18 UTC #2 lore raw

Re: [PATCH V2 1/2] riscv: Cleanup unused functions

Quoted 24 lines · On Sat, 29 May 2021 21:53:27 PDT (-0700), [email protected] wrote:

From: Guo Ren <[email protected]>
These functions haven't been used, so just remove them. The patch has been tested with riscv.
Signed-off-by Guo Ren <[email protected]>
Reviewed-by Christoph Hellwig <[email protected]>
Reviewed-by Anup Patel <[email protected]>
Reviewed-by Palmer Dabbelt <[email protected]>
Acked-by Palmer Dabbelt <[email protected]>
---
 arch/riscv/include/asm/page.h | 10 ----------
 1 file changed, 10 deletions(-)
arch/riscv/include/asm/page.h +0 -2
index 6a7761c..a1b888f 100644
@@ -37,16 +37,6 @@
 
 #ifndef __ASSEMBLY__
 
-#define PAGE_UP(addr)	(((addr)+((PAGE_SIZE)-1))&(~((PAGE_SIZE)-1)))
-#define PAGE_DOWN(addr)	((addr)&(~((PAGE_SIZE)-1)))

arch/riscv/include/asm/page.h line 41

Quoted 10 lines

arch/riscv/include/asm/page.h +0 -8

-
-/* align addr on a size boundary - adjust address up/down if needed */
-#define _ALIGN_UP(addr, size)	(((addr)+((size)-1))&(~((size)-1)))
-#define _ALIGN_DOWN(addr, size)	((addr)&(~((size)-1)))
-
-/* align addr on a size boundary - adjust address up if needed */
-#define _ALIGN(addr, size)	_ALIGN_UP(addr, size)
-
 #define clear_page(pgaddr)			memset((pgaddr), 0, PAGE_SIZE)
 #define copy_page(to, from)			memcpy((to), (from), PAGE_SIZE)

Thanks, this is on for-next. I'm assuming you want the other one to go through the microblaze tree, and it looks like it's already been picked up.

[email protected]

author

2021-05-30 04:54 UTC #3 lore raw

PATCH v2 2/2 microblaze: Cleanup unused functions

In reply to [email protected]

From: Guo Ren <[email protected]>

These functions haven't been used, so just remove them. The patch just uses grep to verify.

Signed-off-by Guo Ren <[email protected]>

Reviewed-by Anup Patel <[email protected]>

Reviewed-by Christoph Hellwig <[email protected]>

Reviewed-by Palmer Dabbelt <[email protected]>

Cc Arnd Bergmann <[email protected]>

Cc Michal Simek <[email protected]>

---
 arch/microblaze/include/asm/page.h | 3 ---
 1 file changed, 3 deletions(-)

arch/microblaze/include/asm/page.h +0 -3

index bf681f2..ce55097 100644
@@ -35,9 +35,6 @@
 
 #define ARCH_SLAB_MINALIGN	L1_CACHE_BYTES
 
-#define PAGE_UP(addr)	(((addr)+((PAGE_SIZE)-1))&(~((PAGE_SIZE)-1)))
-#define PAGE_DOWN(addr)	((addr)&(~((PAGE_SIZE)-1)))
-
 /*
  * PAGE_OFFSET -- the first address of the first page of memory. With MMU
  * it is set to the kernel start address (aligned on a page boundary).

Signature · 1 line

2.7.4

Michal Simek

maintainer

2021-05-31 12:25 UTC #4 lore raw

Re: [PATCH V2 2/2] microblaze: Cleanup unused functions

Quoted 21 lines · On 5/30/21 6:53 AM, [email protected] wrote:

From: Guo Ren <[email protected]>
These functions haven't been used, so just remove them. The patch just uses grep to verify.
Signed-off-by Guo Ren <[email protected]>
Reviewed-by Anup Patel <[email protected]>
Reviewed-by Christoph Hellwig <[email protected]>
Reviewed-by Palmer Dabbelt <[email protected]>
Cc Arnd Bergmann <[email protected]>
Cc Michal Simek <[email protected]>
---
 arch/microblaze/include/asm/page.h | 3 ---
 1 file changed, 3 deletions(-)
arch/microblaze/include/asm/page.h +0 -0
index bf681f2..ce55097 100644

arch/microblaze/include/asm/page.h line 40

Quoted 9 lines

arch/microblaze/include/asm/page.h +0 -3

@@ -35,9 +35,6 @@
 
 #define ARCH_SLAB_MINALIGN	L1_CACHE_BYTES
 
-#define PAGE_UP(addr)	(((addr)+((PAGE_SIZE)-1))&(~((PAGE_SIZE)-1)))
-#define PAGE_DOWN(addr)	((addr)&(~((PAGE_SIZE)-1)))
-
 /*
  * PAGE_OFFSET -- the first address of the first page of memory. With MMU
  * it is set to the kernel start address (aligned on a page boundary).

Ah ok. you have sent v2. Will take this version instead of previous one.

Thanks,
Michal

Signature · 5 lines

Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Xilinx Microblaze
Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs
U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP/Versal SoCs

Guo Ren

author

2021-05-31 12:33 UTC #5 lore raw

Re: [PATCH V2 2/2] microblaze: Cleanup unused functions

Quoted 27 lines · Michal Simek

Quoted 23 lines · On 5/30/21 6:53 AM, [email protected] wrote:
From: Guo Ren <[email protected]>
These functions haven't been used, so just remove them. The patch just uses grep to verify.
Signed-off-by Guo Ren <[email protected]>
Reviewed-by Anup Patel <[email protected]>
Reviewed-by Christoph Hellwig <[email protected]>
Reviewed-by Palmer Dabbelt <[email protected]>
Cc Arnd Bergmann <[email protected]>
Cc Michal Simek <[email protected]>
---
 arch/microblaze/include/asm/page.h | 3 ---
 1 file changed, 3 deletions(-)
arch/microblaze/include/asm/page.h +0 -0
index bf681f2..ce55097 100644
@@ -35,9 +35,6 @@
 
 #define ARCH_SLAB_MINALIGN   L1_CACHE_BYTES
 

Quoted 9 lines

arch/microblaze/include/asm/page.h line 40
Quoted 7 lines
arch/microblaze/include/asm/page.h +0 -3
-#define PAGE_UP(addr)        (((addr)+((PAGE_SIZE)-1))&(~((PAGE_SIZE)-1)))
-#define PAGE_DOWN(addr)      ((addr)&(~((PAGE_SIZE)-1)))
-
 /*
  * PAGE_OFFSET -- the first address of the first page of memory. With MMU
  * it is set to the kernel start address (aligned on a page boundary).
Ah ok. you have sent v2. Will take this version instead of previous one.

No need, they are the same, Thx.

Quoted 11 lines

Thanks,
Michal
--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Xilinx Microblaze Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP/Versal SoCs

Signature · 4 lines

Best Regards
 Guo Ren

ML: https://lore.kernel.org/linux-csky/