Skip to contentSkip to conversation

net/mlx5e: Fix an error code in mlx5e_arfs_create_tables()

PATCH Applied Yang Li 2 participants 2 messages Jun 4, 2021 – Jun 9, 2021

Subsystems (5)
lore
Share & tools
lore

Yang Li

author
#0 lore raw

PATCH v2 1/1 net/mlx5e: Fix an error code in mlx5e_arfs_create_tables()

When the code execute 'if (!priv->fs.arfs->wq)', the value of err is 0. So, we use -ENOMEM to indicate that the function create_singlethread_workqueue() return NULL.

Clean up smatch warning:
drivers/net/ethernet/mellanox/mlx5/core/en_arfs.c:373 mlx5e_arfs_create_tables() warn: missing error code 'err'.

Fixes f6755b80d693 ("net/mlx5e: Dynamic alloc arfs table for netdev when needed")

---

Changes in v2:
--According to Saeed's suggestion, we modify the format of Fixes tag, --and initialize err to -ENOMEM.
https://lore.kernel.org/patchwork/patch/1440018/

 drivers/net/ethernet/mellanox/mlx5/core/en_arfs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/mellanox/mlx5/core/en_arfs.c +1 -1
index 5cd466e..25403af 100644
@@ -356,7 +356,7 @@ static int arfs_create_table(struct mlx5e_priv *priv,
 
 int mlx5e_arfs_create_tables(struct mlx5e_priv *priv)
 {
-	int err = 0;
+	int err = -ENOMEM;
 	int i;
 
 	if (!(priv->netdev->hw_features & NETIF_F_NTUPLE))
Signature · 1 line
1.8.3.1
#1 lore raw
Quoted 11 lines · Yang Li

When the code execute 'if (!priv->fs.arfs->wq)', the value of err is 0.
So, we use -ENOMEM to indicate that the function create_singlethread_workqueue() return NULL.

Clean up smatch warning:
drivers/net/ethernet/mellanox/mlx5/core/en_arfs.c:373 mlx5e_arfs_create_tables() warn: missing error code 'err'.

Fixes f6755b80d693 ("net/mlx5e: Dynamic alloc arfs table for netdev
Quoted 9 lines

when needed")

---

Changes in v2:
--According to Saeed's suggestion, we modify the format of Fixes tag, --and initialize err to -ENOMEM.
https://lore.kernel.org/patchwork/patch/1440018/

applied to net-mlx5.

thanks !