Skip to contentSkip to conversation

NTB: perf: Fix an error code in perf_setup_inbuf()

PATCH New Yang Li 1 participant 1 message Jun 7, 2021 NTB driver core

lore
Share & tools
lore

Yang Li

author
#0 lore raw

PATCH v2 1/1 NTB: perf: Fix an error code in perf_setup_inbuf()

When the function IS_ALIGNED() returns false, the value of ret is 0. So, we set ret to -EINVAL to indicate this error.

Clean up smatch warning:
drivers/ntb/test/ntb_perf.c:602 perf_setup_inbuf() warn: missing error code 'ret'.

---

Change in v2:
--According to Serge's suggestion, set ret to -EINVAL.
https://lore.kernel.org/lkml/20210605180554.ql4rhpukj57ujkxw@mobilestation/

 drivers/ntb/test/ntb_perf.c | 1 +
 1 file changed, 1 insertion(+)
drivers/ntb/test/ntb_perf.c +1 -0
index 89df135..65e1e5c 100644
@@ -598,6 +598,7 @@ static int perf_setup_inbuf(struct perf_peer *peer)
 		return -ENOMEM;
 	}
 	if (!IS_ALIGNED(peer->inbuf_xlat, xlat_align)) {
+		ret = -EINVAL;
 		dev_err(&perf->ntb->dev, "Unaligned inbuf allocated\n");
 		goto err_free_inbuf;
 	}
Signature · 1 line
1.8.3.1