Skip to contentSkip to conversation

venus: helper: do not set constrained parameters for UBWC

PATCH New Mansur Alisha Shaik 1 participant 1 message Jul 6, 2021

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH v4 1/1 venus: helper: do not set constrained parameters for UBWC

Plane constraints firmware interface is to override the default alignment for a given color format. By default venus hardware has alignments as 128x32, but NV12 was defined differently to meet various usecases. Compressed NV12 has always been aligned as 128x32, hence not needed to override the default alignment.

Fixes bc28936bbba9 ("media: venus: helpers, hfi, vdec: Set actual plane constraints to FW")

Changes in V4:
- Corrected the commit message and removed extra line

---
 drivers/media/platform/qcom/venus/helpers.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/media/platform/qcom/venus/helpers.c +3 -0
index 1fe6d46..8012f5c 100644
@@ -1137,6 +1137,9 @@ int venus_helper_set_format_constraints(struct venus_inst *inst)
 	if (!IS_V6(inst->core))
 		return 0;
 
+	if (inst->opb_fmt == HFI_COLOR_FORMAT_NV12_UBWC)
+		return 0;
+
 	pconstraint.buffer_type = HFI_BUFFER_OUTPUT2;
 	pconstraint.num_planes = 2;
 	pconstraint.plane_format[0].stride_multiples = 128;
Signature · 2 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member 
of Code Aurora Forum, hosted by The Linux Foundation