Skip to contentSkip to conversation

FAILED: patch "[PATCH] crypto: ccp - Annotate SEV Firmware file names" failed to apply to 5.4-stable tree

PATCH In review [email protected] 2 participants 3 messages Jul 11, 2021 – Jul 15, 2021

Subsystems (4)
lore
Share & tools
lore

[email protected]

author maintainer
#0 lore raw

The patch below does not apply to the 5.4-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.

thanks,

greg k-h

------------------ original commit in Linus's tree ------------------

From c8671c7dc7d51125ab9f651697866bf4a9132277 Mon Sep 17 00:00:00 2001
From: Joerg Roedel <[email protected]>
Date: Mon, 26 Apr 2021 10:17:48 +0200
Subject: [PATCH] crypto: ccp - Annotate SEV Firmware file names

Annotate the firmware files CCP might need using MODULE_FIRMWARE(). This will get them included into an initrd when CCP is also included there. Otherwise the CCP module will not find its firmware when loaded before the root-fs is mounted.
This can cause problems when the pre-loaded SEV firmware is too old to support current SEV and SEV-ES virtualization features.

Fixes e93720606efd ("crypto: ccp - Allow SEV firmware to be chosen based on Family and Model")
Cc [email protected] # v4.20+
drivers/crypto/ccp/sev-dev.c +4 -0
index 3506b2050fb8..91808402e0bf 100644
@@ -43,6 +43,10 @@ static int psp_probe_timeout = 5;
 module_param(psp_probe_timeout, int, 0644);
 MODULE_PARM_DESC(psp_probe_timeout, " default timeout value, in seconds, during PSP device probe");
 
+MODULE_FIRMWARE("amd/amd_sev_fam17h_model0xh.sbin"); /* 1st gen EPYC */
+MODULE_FIRMWARE("amd/amd_sev_fam17h_model3xh.sbin"); /* 2nd gen EPYC */
+MODULE_FIRMWARE("amd/amd_sev_fam19h_model0xh.sbin"); /* 3rd gen EPYC */
+
 static bool psp_dead;
 static int psp_timeout;
 
#1 lore raw

PATCH 1/1 crypto: ccp - Annotate SEV Firmware file names

From: Joerg Roedel <[email protected]>

[ Upstream commit c8671c7dc7d51125ab9f651697866bf4a9132277 ]

Annotate the firmware files CCP might need using MODULE_FIRMWARE(). This will get them included into an initrd when CCP is also included there. Otherwise the CCP module will not find its firmware when loaded before the root-fs is mounted.
This can cause problems when the pre-loaded SEV firmware is too old to support current SEV and SEV-ES virtualization features.

Fixes e93720606efd ("crypto: ccp - Allow SEV firmware to be chosen based on Family and Model")
Cc [email protected] # v4.20+
---
 drivers/crypto/ccp/psp-dev.c | 4 ++++
 1 file changed, 4 insertions(+)
drivers/crypto/ccp/psp-dev.c +4 -0
index 6b17d179ef8a..5acf6ae5af66 100644
@@ -40,6 +40,10 @@ static int psp_probe_timeout = 5;
 module_param(psp_probe_timeout, int, 0644);
 MODULE_PARM_DESC(psp_probe_timeout, " default timeout value, in seconds, during PSP device probe");
 
+MODULE_FIRMWARE("amd/amd_sev_fam17h_model0xh.sbin"); /* 1st gen EPYC */
+MODULE_FIRMWARE("amd/amd_sev_fam17h_model3xh.sbin"); /* 2nd gen EPYC */
+MODULE_FIRMWARE("amd/amd_sev_fam19h_model0xh.sbin"); /* 3rd gen EPYC */
+
 static bool psp_dead;
 static int psp_timeout;
 
Signature · 1 line
2.31.1
author maintainer
#2 lore raw

Re: [PATCH stable-5.4] crypto: ccp - Annotate SEV Firmware file names

Quoted 11 lines · Joerg Roedel

From: Joerg Roedel <[email protected]>

[ Upstream commit c8671c7dc7d51125ab9f651697866bf4a9132277 ]

Annotate the firmware files CCP might need using MODULE_FIRMWARE(). This will get them included into an initrd when CCP is also included there. Otherwise the CCP module will not find its firmware when loaded before the root-fs is mounted.
This can cause problems when the pre-loaded SEV firmware is too old to support current SEV and SEV-ES virtualization features.

Quoted 8 lines
Fixes e93720606efd ("crypto: ccp - Allow SEV firmware to be chosen based on Family and Model")
Cc [email protected] # v4.20+
---
 drivers/crypto/ccp/psp-dev.c | 4 ++++
 1 file changed, 4 insertions(+)

Now applied, thanks!

greg k-h