Skip to contentSkip to conversation

FAILED: patch "[PATCH] iommu/vt-d: Fix clearing real DMA device's scalable-mode" failed to apply to 5.10-stable tree

PATCH [email protected] 1 participant 1 message Jul 19, 2021

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer
#0 lore raw

The patch below does not apply to the 5.10-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.

thanks,

greg k-h

------------------ original commit in Linus's tree ------------------

From 474dd1c6506411752a9b2f2233eec11f1733a099 Mon Sep 17 00:00:00 2001
From: Lu Baolu <[email protected]>
Date: Mon, 12 Jul 2021 15:17:12 +0800
Subject: [PATCH] iommu/vt-d: Fix clearing real DMA device's scalable-mode
context entries

The commit 2b0140c69637e ("iommu/vt-d: Use pci_real_dma_dev() for mapping") fixes an issue of "sub-device is removed where the context entry is cleared for all aliases". But this commit didn't consider the PASID entry and PASID table in VT-d scalable mode. This fix increases the coverage of scalable mode.

Fixes 8038bdb855331 ("iommu/vt-d: Only clear real DMA device's context entries")
Fixes 2b0140c69637e ("iommu/vt-d: Use pci_real_dma_dev() for mapping")
Cc Jon Derrick <[email protected]>
drivers/iommu/intel/iommu.c +2 -3
index 57270290d62b..dd22fc7d5176 100644
@@ -4472,14 +4472,13 @@ static void __dmar_remove_one_dev_info(struct device_domain_info *info)
 	iommu = info->iommu;
 	domain = info->domain;
 
-	if (info->dev) {
+	if (info->dev && !dev_is_real_dma_subdevice(info->dev)) {
 		if (dev_is_pci(info->dev) && sm_supported(iommu))
 			intel_pasid_tear_down_entry(iommu, info->dev,
 					PASID_RID2PASID, false);
 
 		iommu_disable_dev_iotlb(info);
-		if (!dev_is_real_dma_subdevice(info->dev))
-			domain_context_clear(info);
+		domain_context_clear(info);
 		intel_pasid_free_table(info->dev);
 	}