dma-buf: WARN on dmabuf release with pending attachments
Subsystems (2)
PATCH 1/1 dma-buf: WARN on dmabuf release with pending attachments
It is expected from the clients to follow the below steps on an imported dmabuf fd:
a) dmabuf = dma_buf_get(fd) // Get the dmabuf from fd
b) dma_buf_attach(dmabuf); // Clients attach to the dmabuf
o Here the kernel does some slab allocations, say fordma_buf_attachment and may be some other slab allocation in the dmabuf->ops->attach().
c) Client may need to do dma_buf_map_attachment().
d) Accordingly dma_buf_unmap_attachment() should be called.
e) dma_buf_detach () // Clients detach to the dmabuf.
o Here the slab allocations made in b) are freed.
f) dma_buf_put(dmabuf) // Can free the dmabuf if it is the last reference.
Now say an erroneous client failed at step c) above thus it directly called dma_buf_put(), step f) above. Considering that it may be the last reference to the dmabuf, buffer will be freed with pending attachments left to the dmabuf which can show up as the 'memory leak'. This should at least be reported as the WARN().
--- drivers/dma-buf/dma-buf.c | 1 + 1 file changed, 1 insertion(+)
drivers/dma-buf/dma-buf.c +1 -0
@@ -79,6 +79,7 @@ static void dma_buf_release(struct dentry *dentry)if (dmabuf->resv == (struct dma_resv *)&dmabuf[1 ])dma_resv_fini (dmabuf->resv); +WARN_ON (!list_empty (&dmabuf->attachments));module_put (dmabuf->owner);kfree (dmabuf->name);kfree (dmabuf);
Signature · 2 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation
Christian König
maintainerAm 23.07.21 um 14:31 schrieb Charan Teja Reddy:
Quoted 14 lines
It is expected from the clients to follow the below steps on an imported dmabuf fd:
a) dmabuf =dma_buf_get(fd)// Get the dmabuf from fd
b)dma_buf_attach(dmabuf); // Clients attach to the dmabuf
o Here the kernel does some slab allocations, say fordma_buf_attachmentand may be some other slab allocation in thedmabuf->ops->attach().
c) Client may need to dodma_buf_map_attachment().
d) Accordinglydma_buf_unmap_attachment()should be called.
e)dma_buf_detach() // Clients detach to the dmabuf.
o Here the slab allocations made in b) are freed.
f)dma_buf_put(dmabuf)// Can free the dmabuf if it is the last reference.
Quoted 7 lines
Now say an erroneous client failed at step c) above thus it directly called
dma_buf_put(), step f) above. Considering that it may be the last reference to the dmabuf, buffer will be freed with pending attachments left to the dmabuf which can show up as the 'memory leak'. This should at least be reported as theWARN().Signed-off-by Charan Teja Reddy <[email protected]>
Good idea. I would expect a crash immediately, but from such a backtrace it is quite hard to tell what the problem is.
Patch is Reviewed-by: Christian König <[email protected]> and I'm going to push this to drm-misc-next on Monday if nobody objects.
Thanks,
Christian.
Quoted 16 lines
--- drivers/dma-buf/dma-buf.c | 1 + 1 file changed, 1 insertion(+)drivers/dma-buf/dma-buf.c +1
-0@@ -79,6 +79,7 @@ static void dma_buf_release(struct dentry *dentry)if (dmabuf->resv == (struct dma_resv *)&dmabuf[1 ])dma_resv_fini (dmabuf->resv); +WARN_ON (!list_empty (&dmabuf->attachments));module_put (dmabuf->owner);kfree (dmabuf->name);kfree (dmabuf);
Daniel Vetter
Acked-byQuoted 21 lines · Christian König
Am 23.07.21 um 14:31 schrieb Charan Teja Reddy:
Quoted 20 lines
It is expected from the clients to follow the below steps on an imported dmabuf fd:
a) dmabuf =dma_buf_get(fd)// Get the dmabuf from fd
b)dma_buf_attach(dmabuf); // Clients attach to the dmabuf
o Here the kernel does some slab allocations, say fordma_buf_attachmentand may be some other slab allocation in thedmabuf->ops->attach().
c) Client may need to dodma_buf_map_attachment().
d) Accordinglydma_buf_unmap_attachment()should be called.
e)dma_buf_detach() // Clients detach to the dmabuf.
o Here the slab allocations made in b) are freed.
f)dma_buf_put(dmabuf)// Can free the dmabuf if it is the last reference.Now say an erroneous client failed at step c) above thus it directly called
dma_buf_put(), step f) above. Considering that it may be the last reference to the dmabuf, buffer will be freed with pending attachments left to the dmabuf which can show up as the 'memory leak'. This should at least be reported as theWARN().
Quoted 7 lines
Quoted 1 line
Signed-off-by Charan Teja Reddy <[email protected]>Good idea. I would expect a crash immediately, but from such a backtrace it is quite hard to tell what the problem is.
Patch is Reviewed-by: Christian König <[email protected]> and I'm going to push this to drm-misc-next on Monday if nobody objects.
The boom only happens a lot later when the offending import uses the attachment again. This here has a good chance to catch that early drm_buf_put(), so I think it's a good improvement. We'll still Oops later on ofc, but meh.
Quoted 20 lines
Thanks,
Christian.Quoted 15 lines
--- drivers/dma-buf/dma-buf.c | 1 + 1 file changed, 1 insertion(+)drivers/dma-buf/dma-buf.c +1
-0@@ -79,6 +79,7 @@ static void dma_buf_release(struct dentry *dentry)if (dmabuf->resv == (struct dma_resv *)&dmabuf[1 ])dma_resv_fini (dmabuf->resv); +WARN_ON (!list_empty (&dmabuf->attachments));module_put (dmabuf->owner);kfree (dmabuf->name);kfree (dmabuf);
Signature · 3 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch