FAILED: patch "[PATCH] btrfs: mark compressed range uptodate only if all bio succeed" failed to apply to 4.19-stable tree
Subsystems (2)
[email protected]
maintainerThe patch below does not apply to the 4.19-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.
thanks,
greg k-h
------------------ original commit in Linus's tree ------------------
From 240246f6b913b0c23733cfd2def1d283f8cc9bbe Mon Sep 17 00:00:00 2001
From: Goldwyn Rodrigues <[email protected]>
Date: Fri, 9 Jul 2021 11:29:22 -0500
Subject: [PATCH] btrfs: mark compressed range uptodate only if all bio succeed
In compression write endio sequence, the range which the compressed_bio writes is marked as uptodate if the last bio of the compressed (sub)bios is completed successfully. There could be previous bio which may have failed which is recorded in cb->errors.
Set the writeback range as uptodate only if cb->errors is zero, as opposed to checking only the last bio's status.
Backporting notes: in all versions up to 4.4 the last argument is always replaced by "!cb->errors".
fs/btrfs/compression.c +1 -1
@@ -352,7 +352,7 @@ static void end_compressed_bio_write(struct bio *bio)btrfs_record_physical_zoned (inode, cb->start, bio);btrfs_writepage_endio_finish_ordered (BTRFS_I (inode),NULL , cb->start, cb->start + cb->len -1 , - bio->bi_status ==BLK_STS_OK ); + !cb->errors);end_compressed_writeback (inode, cb);/* note, our inode could be gone now */
PATCH 1/1 btrfs: mark compressed range uptodate only if all bio succeed
For: v4.19
Git-commit: 240246f6b913b0c23733cfd2def1d283f8cc9bbe
In compression write endio sequence, the range which the compressed_bio writes is marked as uptodate if the last bio of the compressed (sub)bios is completed successfully. There could be previous bio which may have failed which is recorded in cb->errors.
Set the writeback range as uptodate only if cb->errors is zero, as opposed to checking only the last bio's status.
Backporting notes: in all versions up to 4.4 the last argument is always replaced by "!cb->errors".
fs/btrfs/compression.c +1 -2
@@ -270,8 +270,7 @@ static void end_compressed_bio_write(struct bio *bio) cb->start, cb->start + cb->len -1 ,NULL , - bio->bi_status ? - BLK_STS_OK : BLK_STS_NOTSUPP); + !cb->errors); cb->compressed_pages[0 ]->mapping =NULL ;end_compressed_writeback (inode, cb);
Signature · 1 line
Goldwyn
Re: [PATCH] btrfs: mark compressed range uptodate only if all bio succeed
Quoted 11 lines · Goldwyn Rodrigues
For: v4.19
Git-commit:240246f6b913b0c23733cfd2def1d283f8cc9bbeIn compression write endio sequence, the range which the
compressed_biowrites is marked as uptodate if the last bio of the compressed (sub)bios is completed successfully. There could be previous bio which may have failed which is recorded incb->errors.Set the writeback range as uptodate only if
cb->errorsis zero, as opposed to checking only the last bio's status.
Quoted 6 lines
Backporting notes: in all versions up to 4.4 the last argument is always replaced by "!cb->errors".
Signed-off-by Goldwyn Rodrigues <[email protected]>Reviewed-by David Sterba <[email protected]>Signed-off-by David Sterba <[email protected]>
I've queued up this and the other backports, thanks!
Signature · 2 lines
Thanks, Sasha