Skip to contentSkip to conversation

cpufreq: qcom-hw: Set dvfs_possible_from_any_cpu cpufreq driver flag

PATCH Superseded Taniya Das 2 participants 3 messages Aug 11, 2021 – Aug 12, 2021

Subsystems (2)
Arm Qualcomm mailing list CPU frequency scaling framework

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Taniya Das

author
#0 lore raw

PATCH 1/1 cpufreq: qcom-hw: Set dvfs_possible_from_any_cpu cpufreq driver flag

As remote cpufreq updates are supported on QCOM platforms, set dvfs_possible_from_any_cpu cpufreq driver flag.

Signed-off-by Taniya Das <[email protected]>
---
 drivers/cpufreq/qcom-cpufreq-hw.c | 1 +
 1 file changed, 1 insertion(+)
drivers/cpufreq/qcom-cpufreq-hw.c +1 -0
index f86859b..20455aa 100644
@@ -161,6 +161,7 @@ static int qcom_cpufreq_hw_read_lut(struct device *cpu_dev,
 		return ret;
 	} else {
 		policy->fast_switch_possible = true;
+		policy->dvfs_possible_from_any_cpu = true;
 		icc_scaling_enabled = false;
 	}

--
Qualcomm INDIA, on behalf of Qualcomm Innovation Center, Inc.is a member of the Code Aurora Forum, hosted by the Linux Foundation.

maintainer
#1 lore raw
Quoted 13 lines · Taniya Das

As remote cpufreq updates are supported on QCOM platforms, set dvfs_possible_from_any_cpu cpufreq driver flag.

Signed-off-by Taniya Das <[email protected]>
---
 drivers/cpufreq/qcom-cpufreq-hw.c | 1 +
 1 file changed, 1 insertion(+)
drivers/cpufreq/qcom-cpufreq-hw.c +0 -0
index f86859b..20455aa 100644

drivers/cpufreq/qcom-cpufreq-hw.c static int qcom_cpufreq_hw_read_lut(struct device *cpu_dev, · line 166

Quoted 6 lines
drivers/cpufreq/qcom-cpufreq-hw.c +1 -0
@@ -161,6 +161,7 @@ static int qcom_cpufreq_hw_read_lut(struct device *cpu_dev,
 		return ret;
 	} else {
 		policy->fast_switch_possible = true;
+		policy->dvfs_possible_from_any_cpu = true;
 		icc_scaling_enabled = false;
 	}

Why don't you set it always ?

Quoted 4 lines
drivers/cpufreq/qcom-cpufreq-hw.c +0 -1
--

Qualcomm INDIA, on behalf of Qualcomm Innovation Center, Inc.is a member of the Code Aurora Forum, hosted by the Linux Foundation.

Signature · 1 line
viresh
author
#2 lore raw

Thanks Viresh for the review.

Quoted 9 lines · Viresh Kumar
Quoted 8 lines · Taniya Das

As remote cpufreq updates are supported on QCOM platforms, set dvfs_possible_from_any_cpu cpufreq driver flag.

Signed-off-by Taniya Das <[email protected]>
---
  drivers/cpufreq/qcom-cpufreq-hw.c | 1 +
  1 file changed, 1 insertion(+)
Quoted 14 lines

drivers/cpufreq/qcom-cpufreq-hw.c static int qcom_cpufreq_hw_read_lut(struct device *cpu_dev, · line 166

Quoted 11 lines
drivers/cpufreq/qcom-cpufreq-hw.c +1 -0
index f86859b..20455aa 100644
@@ -161,6 +161,7 @@ static int qcom_cpufreq_hw_read_lut(struct device *cpu_dev,
  		return ret;
  	} else {
  		policy->fast_switch_possible = true;
+		policy->dvfs_possible_from_any_cpu = true;
  		icc_scaling_enabled = false;
  	}

Why don't you set it always ?

Sure, will move it outside.

Quoted 5 lines
Quoted 4 lines
drivers/cpufreq/qcom-cpufreq-hw.c +0 -1
--

Qualcomm INDIA, on behalf of Qualcomm Innovation Center, Inc.is a member of the Code Aurora Forum, hosted by the Linux Foundation.

Signature · 4 lines
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation.

--