hw/virtio: Fix leak of host-notifier memory-region
PATCH 1/1 hw/virtio: Fix leak of host-notifier memory-region
If call virtio_queue_set_host_notifier_mr fails, should free host-notifier memory-region.
Signed-off-by Yajun Wu <[email protected]>
--- hw/virtio/vhost-user.c | 1 + 1 file changed, 1 insertion(+)
hw/virtio/vhost-user.c +1 -0
@@ -1474,6 +1474,7 @@ static int vhost_user_slave_handle_vring_host_notifier(struct vhost_dev *dev,g_free (name);if (virtio_queue_set_host_notifier_mr (vdev, queue_idx, &n->mr, true)) { +object_unparent (OBJECT (&n->mr));munmap (addr, page_size);return -1 ; }
Signature · 1 line
1.8.3.1
Quoted 3 lines · Yajun Wu via
If call
virtio_queue_set_host_notifier_mrfails, should free host-notifier memory-region.
We can add:
Fixes 44866521bd ("vhost-user: support registering external host notifiers")
Quoted 21 lines
Signed-off-by Yajun Wu <[email protected]>---
hw/virtio/vhost-user.c| 1 +1 file changed, 1 insertion(+)hw/virtio/vhost-user.c +1
-0@@ -1474,6 +1474,7 @@ static int vhost_user_slave_handle_vring_host_notifier(struct vhost_dev *dev,g_free (name);if (virtio_queue_set_host_notifier_mr (vdev, queue_idx, &n->mr, true)) { +object_unparent (OBJECT (&n->mr));munmap (addr, page_size);return -1 ; }Signature · 1 line
1.8.3.1
Reviewed-by Stefano Garzarella <[email protected]>