nss: fix postinst in do_rootfs for target
PATCH 1/1 nss: fix postinst in do_rootfs for target
In reply to a message not in the archivePartially revert "nss: fix postinst script for nativesdk build"
This reverts commit 31552510b15c1c97aa6cbe180c2bb53d139efbcc.
When running in do_rootfs we need to run shlibsign provided by nss-native, otherwise it fails when /usr/bin/shlibsign doesn't exist on host builder:
do_rootfs: Postinstall scriptlets of ['nss'] have failed. If the intention is to defer them to first boot, then please place them into pkg_postinst_ontarget_${PN} ().
Deferring to first boot via 'exit 1' is no longer supported.
--- meta-oe/recipes-support/nss/nss_3.54.bb | 26 ++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-)
meta-oe/recipes-support/nss/nss_3.54.bb +13 -13
@@ -240,19 +240,19 @@ do_install_append_class-target() { PACKAGE_WRITE_DEPS += "nss-native" pkg_postinst_${PN} () { - if [ -n "$D" ]; then - for I in $D${libdir}/lib*.chk; do - DN=`dirname $I` - BN=`basename $I .chk` - FN=$DN/$BN.so - ${bindir}/shlibsign -i $FN - if [ $? -ne 0 ]; then - exit 1 - fi - done - else - ${bindir}/signlibs.sh - fi + for I in $D${libdir}/lib*.chk; do + DN=`dirname $I` + BN=`basename $I .chk` + FN=$DN/$BN.so + shlibsign -i $FN + if [ $? -ne 0 ]; then + echo "shlibsign -i $FN failed" + fi + done +} + +pkg_postinst_ontarget_${PN} () { + ${bindir}/signlibs.sh } PACKAGES =+ "${PN}-smime"
Signature · 1 line
2.25.1
Quoted 7 lines · Martin Jansa
Partially revert "nss: fix postinst script for nativesdk build"
This reverts commit
31552510b15c1c97aa6cbe180c2bb53d139efbcc.When running in
do_rootfswe need to run shlibsign provided by nss-native, otherwise it fails when/usr/bin/shlibsigndoesn't exist on host builder:
this fixes the issue I was seeing.
thanks.
Quoted 49 lines
do_rootfs: Postinstall scriptlets of ['nss'] have failed. If the intention is to defer them to first boot, then please place them into pkg_postinst_ontarget_${PN} ().
Deferring to first boot via 'exit 1' is no longer supported.Signed-off-by Martin Jansa <[email protected]>--- meta-oe/recipes-support/nss/nss_3.54.bb | 26 ++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-)meta-oe/recipes-support/nss/nss_3.54.bb +13
-13@@ -240,19 +240,19 @@ do_install_append_class-target() { PACKAGE_WRITE_DEPS += "nss-native" pkg_postinst_${PN} () { - if [ -n "$D" ]; then - for I in $D${libdir}/lib*.chk; do - DN=`dirname $I` - BN=`basename $I .chk` - FN=$DN/$BN.so - ${bindir}/shlibsign -i $FN - if [ $? -ne 0 ]; then - exit 1 - fi - done - else - ${bindir}/signlibs.sh - fi + for I in $D${libdir}/lib*.chk; do + DN=`dirname $I` + BN=`basename $I .chk` + FN=$DN/$BN.so + shlibsign -i $FN + if [ $? -ne 0 ]; then + echo "shlibsign -i $FN failed" + fi + done +} + +pkg_postinst_ontarget_${PN} () { + ${bindir}/signlibs.sh } PACKAGES =+ "${PN}-smime"
Hi,
Quoted 11 lines · Martin Jansa
Partially revert "nss: fix postinst script for nativesdk build"
This reverts commit
31552510b15c1c97aa6cbe180c2bb53d139efbcc.When running in
do_rootfswe need to run shlibsign provided by nss-native, otherwise it fails when/usr/bin/shlibsigndoesn't exist on host builder:
do_rootfs: Postinstall scriptlets of ['nss'] have failed. If the intention is to defer them to first boot, then please place them into pkg_postinst_ontarget_${PN} ().
Deferring to first boot via 'exit 1' is no longer supported.
Thanks for this, it fixes all issues.
I didn't properly test my patch. Sorry!
-Mikko
Quoted 47 lines
Signed-off-by Martin Jansa <[email protected]>--- meta-oe/recipes-support/nss/nss_3.54.bb | 26 ++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-)meta-oe/recipes-support/nss/nss_3.54.bb +13
-13@@ -240,19 +240,19 @@ do_install_append_class-target() { PACKAGE_WRITE_DEPS += "nss-native" pkg_postinst_${PN} () { - if [ -n "$D" ]; then - for I in $D${libdir}/lib*.chk; do - DN=`dirname $I` - BN=`basename $I .chk` - FN=$DN/$BN.so - ${bindir}/shlibsign -i $FN - if [ $? -ne 0 ]; then - exit 1 - fi - done - else - ${bindir}/signlibs.sh - fi + for I in $D${libdir}/lib*.chk; do + DN=`dirname $I` + BN=`basename $I .chk` + FN=$DN/$BN.so + shlibsign -i $FN + if [ $? -ne 0 ]; then + echo "shlibsign -i $FN failed" + fi + done +} + +pkg_postinst_ontarget_${PN} () { + ${bindir}/signlibs.sh } PACKAGES =+ "${PN}-smime"Signature · 1 line
2.25.1
Looks like my "solution" also isn't working well at least for images with read-only-rootfs in IMAGE_FEATURES.
pkg_postinst_ontarget_${PN} is always forced to run on the target, which for read-only-rootfs results in:
log.do_rootfs:
...
NOTE: If an image is being built, the postinstalls for the following packages will be postponed for first boot: nss
...
ERROR: The following packages could not be configured offline and rootfs is
read-only: ['nss']
and now looking at the /usr/bin/signlibs.sh:
CHK_FILES=ls /lib*/*.chk /usr/lib*/*.chk 2>/dev/null SIGN_BINARY=which shlibsign
for I in $CHK_FILES
do
DN=dirname $I
BN=basename $I .chk
FN=$DN/$BN.so
$SIGN_BINARY -i $FN
done
it does pretty much the same as the postinst script when D isn't empty.
From oe-core git history it shows that signlibs.sh was added first:
https://git.openembedded.org/openembedded-core/commit/?id=a4580f967c8064294a06d406acf5deb24aee2acc
then the offline version of postinst was added to support read-only-rootfs in:
https://git.openembedded.org/openembedded-core/commit/?id=64e87fc6e99bc1d4807034166735034b1f92bad8
and nss-native should always provide the shlibsign since:
https://git.openembedded.org/openembedded-core/commit/?id=88540c5b08dea069660d1a68e506aebdd68e6ae0
and only after
https://git.openembedded.org/openembedded-core/commit/?id=8f782f7095e718dd9452055af53363beb6bdbece
it looked like signlibs.sh was something special only for target.
So it looks to me, that we should just remove signlibs.sh script and let the same postinst be used on target and offline
(with or without D being empty).
Cheers,
Quoted 71 lines · On Mon, Aug 31, 2020 at 9:45 AM <[email protected]> wrote:
Hi,
Quoted 9 lines · Martin Jansa
Partially revert "nss: fix postinst script for nativesdk build"
This reverts commit
31552510b15c1c97aa6cbe180c2bb53d139efbcc.When running in
do_rootfswe need to run shlibsign provided by nss-native, otherwise it fails when/usr/bin/shlibsigndoesn't exist on host builder:
do_rootfs: Postinstall scriptlets of ['nss'] have failed. If theintention is to defer them to first boot,
Quoted 2 lines
then please place them into pkg_postinst_ontarget_${PN} (). Deferring to first boot via 'exit 1' is no longer supported.
Thanks for this, it fixes all issues.
I didn't properly test my patch. Sorry!
-Mikko
Review
Quoted 6 lines
Signed-off-by Martin Jansa <[email protected]>--- meta-oe/recipes-support/nss/nss_3.54.bb | 26 ++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-)(quoted diff) +0
-0b/meta-oe/recipes-support/nss/nss_3.54.bb
Quoted 41 lines
index
882145c1ef..81b2538813100644meta-oe/recipes-support/nss/nss_3.54.bb +13
-14@@ -240,19 +240,19 @@ do_install_append_class-target() { PACKAGE_WRITE_DEPS += "nss-native" pkg_postinst_${PN} () { - if [ -n "$D" ]; then - for I in $D${libdir}/lib*.chk; do - DN=`dirname $I` - BN=`basename $I .chk` - FN=$DN/$BN.so - ${bindir}/shlibsign -i $FN - if [ $? -ne 0 ]; then - exit 1 - fi - done - else - ${bindir}/signlibs.sh - fi + for I in $D${libdir}/lib*.chk; do + DN=`dirname $I` + BN=`basename $I .chk` + FN=$DN/$BN.so + shlibsign -i $FN + if [ $? -ne 0 ]; then + echo "shlibsign -i $FN failed" + fi + done +} + +pkg_postinst_ontarget_${PN} () { + ${bindir}/signlibs.sh } PACKAGES =+ "${PN}-smime" --2.25.1
PATCH 1/1 nss: remove signlibs.sh
In reply to a message not in the archiveLooks like my "solution" also isn't working well at least for images with read-only-rootfs in IMAGE_FEATURES.
pkg_postinst_ontarget_${PN} is always forced to run on the target, which for read-only-rootfs results in:
log.do_rootfs:
...
NOTE: If an image is being built, the postinstalls for the following packages will be postponed for first boot: nss
...
ERROR: The following packages could not be configured offline and rootfs is read-only: ['nss']
and now looking at the /usr/bin/signlibs.sh and it does pretty much the same as the postinst script when D isn't empty.
From oe-core git history it shows that signlibs.sh was added first:
https://git.openembedded.org/openembedded-core/commit/?id=a4580f967c8064294a06d406acf5deb24aee2acc
then the offline version of postinst was added to support read-only-rootfs in:
https://git.openembedded.org/openembedded-core/commit/?id=64e87fc6e99bc1d4807034166735034b1f92bad8
and nss-native should always provide the shlibsign since:
https://git.openembedded.org/openembedded-core/commit/?id=88540c5b08dea069660d1a68e506aebdd68e6ae0
and only after
https://git.openembedded.org/openembedded-core/commit/?id=8f782f7095e718dd9452055af53363beb6bdbece
it looked like signlibs.sh was something special only for target.
So it looks to me, that we should just remove signlibs.sh script and let the same postinst be used on target and offline (with or without D being empty).
--- meta-oe/recipes-support/nss/nss/signlibs.sh | 20 -------------------- meta-oe/recipes-support/nss/nss_3.56.bb | 6 ------ 2 files changed, 26 deletions(-) delete mode 100644 meta-oe/recipes-support/nss/nss/signlibs.sh
meta-oe/recipes-support/nss/nss/signlibs.sh deleted +0 -20
@@ -1,20 +0,0 @@ -#!/bin/sh - -# signlibs.sh -# -# (c)2010 Wind River Systems, Inc. -# -# regenerates the .chk files for the NSS libraries that require it -# since the ones that are built have incorrect checksums that were -# calculated on the host where they really need to be done on the -# target - -CHK_FILES=`ls /lib*/*.chk /usr/lib*/*.chk 2>/dev/null` -SIGN_BINARY=`which shlibsign` -for I in $CHK_FILES -do - DN=`dirname $I` - BN=`basename $I .chk` - FN=$DN/$BN.so - $SIGN_BINARY -i $FN -done
meta-oe/recipes-support/nss/nss_3.56.bb +0 -6
@@ -21,7 +21,6 @@ VERSION_DIR = "${@d.getVar('BP').upper().replace('-', '_').replace('.', '_') + ' SRC_URI = "http://ftp.mozilla.org/pub/mozilla.org/security/nss/releases/${VERSION_DIR}/src/${BP}.tar.gz \ file://nss.pc.in \ - file://signlibs.sh \ file://0001-nss-fix-support-cross-compiling.patch \ file://nss-no-rpath-for-cross-compiling.patch \ file://nss-fix-incorrect-shebang-of-perl.patch \
@@ -214,7 +213,6 @@ do_install_append() { touch ${D}/${libdir}/$file chmod 755 ${D}/${libdir}/$file done - install -D -m 755 ${WORKDIR}/signlibs.sh ${D}/${bindir}/signlibs.sh install -d ${D}${libdir}/pkgconfig/ sed 's/%NSS_VERSION%/${PV}/' ${WORKDIR}/nss.pc.in | sed 's/%NSPR_VERSION%/4.9.2/' > ${D}${libdir}/pkgconfig/nss.pc
@@ -251,10 +249,6 @@ pkg_postinst_${PN} () { done } -pkg_postinst_ontarget_${PN} () { - ${bindir}/signlibs.sh -} - PACKAGES =+ "${PN}-smime" FILES_${PN}-smime = "\ ${bindir}/smime \
Signature · 1 line
2.25.1
Re: [oe] [meta-oe][PATCH] nss: remove signlibs.sh
Quoted 40 lines · Martin Jansa
Looks like my "solution" also isn't working well at least for images with read-only-rootfs in
IMAGE_FEATURES.pkg_postinst_ontarget_${PN} is always forced to run on the target, which for read-only-rootfs results in:
log.do_rootfs:
...
NOTE: If an image is being built, the postinstalls for the following packages will be postponed for first boot: nss
...
ERROR: The following packages could not be configured offline and rootfs is read-only: ['nss']and now looking at the
/usr/bin/signlibs.shand it does pretty much the same as the postinst script when D isn't empty.From oe-core git history it shows that
signlibs.shwas added first:
https://git.openembedded.org/openembedded-core/commit/?id=a4580f967c8064294a06d406acf5deb24aee2acc
then the offline version of postinst was added to support read-only-rootfs in:
https://git.openembedded.org/openembedded-core/commit/?id=64e87fc6e99bc1d4807034166735034b1f92bad8
and nss-native should always provide the shlibsign since:
https://git.openembedded.org/openembedded-core/commit/?id=88540c5b08dea069660d1a68e506aebdd68e6ae0
and only after
https://git.openembedded.org/openembedded-core/commit/?id=8f782f7095e718dd9452055af53363beb6bdbece
it looked likesignlibs.shwas something special only for target.So it looks to me, that we should just remove
signlibs.shscript and let the same postinst be used on target and offline (with or without D being empty).Signed-off-by Martin Jansa <[email protected]>--- meta-oe/recipes-support/nss/nss/signlibs.sh | 20 -------------------- meta-oe/recipes-support/nss/nss_3.56.bb | 6 ------ 2 files changed, 26 deletions(-) delete mode 100644 meta-oe/recipes-support/nss/nss/signlibs.shmeta-oe/recipes-support/nss/nss/signlibs.sh deleted +0
-1@@ -1,20 +0,0 @@ -#!/bin/sh
meta-oe/recipes-support/nss/nss/signlibs.sh line 11
Quoted 10 lines
meta-oe/recipes-support/nss/nss/signlibs.sh deleted +0
-10- -# signlibs.sh -# -# (c)2010 Wind River Systems, Inc. -# -# regenerates the .chk files for the NSS libraries that require it -# since the ones that are built have incorrect checksums that were -# calculated on the host where they really need to be done on the -# target -
if we remove this then how do we solve above said issue? is it still an issue ?
Quoted 44 lines
meta-oe/recipes-support/nss/nss/signlibs.sh deleted +0
-9-CHK_FILES=`ls /lib*/*.chk /usr/lib*/*.chk 2>/dev/null` -SIGN_BINARY=`which shlibsign` -for I in $CHK_FILES -do - DN=`dirname $I` - BN=`basename $I .chk` - FN=$DN/$BN.so - $SIGN_BINARY -i $FN -donemeta-oe/recipes-support/nss/nss_3.56.bb +0
-7@@ -21,7 +21,6 @@ VERSION_DIR = "${@d.getVar('BP').upper().replace('-', '_').replace('.', '_') + ' SRC_URI = "http://ftp.mozilla.org/pub/mozilla.org/security/nss/releases/${VERSION_DIR}/src/${BP}.tar.gz \ file://nss.pc.in \ - file://signlibs.sh \ file://0001-nss-fix-support-cross-compiling.patch \ file://nss-no-rpath-for-cross-compiling.patch \ file://nss-fix-incorrect-shebang-of-perl.patch \@@ -214,7 +213,6 @@ do_install_append() { touch ${D}/${libdir}/$file chmod 755 ${D}/${libdir}/$file done - install -D -m 755 ${WORKDIR}/signlibs.sh ${D}/${bindir}/signlibs.sh install -d ${D}${libdir}/pkgconfig/ sed 's/%NSS_VERSION%/${PV}/' ${WORKDIR}/nss.pc.in | sed 's/%NSPR_VERSION%/4.9.2/' > ${D}${libdir}/pkgconfig/nss.pc@@ -251,10 +249,6 @@ pkg_postinst_${PN} () { done } -pkg_postinst_ontarget_${PN} () { - ${bindir}/signlibs.sh -} - PACKAGES =+ "${PN}-smime" FILES_${PN}-smime = "\ ${bindir}/smime \ --2.25.1
Re: [oe] [meta-oe][PATCH] nss: remove signlibs.sh
Quoted 45 lines · Khem Raj
Quoted 44 lines · Martin Jansa
Looks like my "solution" also isn't working well at least for images with read-only-rootfs in
IMAGE_FEATURES.pkg_postinst_ontarget_${PN} is always forced to run on the target, which for read-only-rootfs results in:
log.do_rootfs:
...
NOTE: If an image is being built, the postinstalls for the following packages will be postponed for first boot: nss
...
ERROR: The following packages could not be configured offline and rootfs is read-only: ['nss']and now looking at the
/usr/bin/signlibs.shand it does pretty much the same as the postinst script when D isn't empty.From oe-core git history it shows that
signlibs.shwas added first:
https://git.openembedded.org/openembedded-core/commit/?id=a4580f967c8064294a06d406acf5deb24aee2acc
then the offline version of postinst was added to support read-only-rootfs in:
https://git.openembedded.org/openembedded-core/commit/?id=64e87fc6e99bc1d4807034166735034b1f92bad8
and nss-native should always provide the shlibsign since:
https://git.openembedded.org/openembedded-core/commit/?id=88540c5b08dea069660d1a68e506aebdd68e6ae0
and only after
https://git.openembedded.org/openembedded-core/commit/?id=8f782f7095e718dd9452055af53363beb6bdbece
it looked likesignlibs.shwas something special only for target.So it looks to me, that we should just remove
signlibs.shscript and let the same postinst be used on target and offline (with or without D being empty).Signed-off-by Martin Jansa <[email protected]>--- meta-oe/recipes-support/nss/nss/signlibs.sh | 20 -------------------- meta-oe/recipes-support/nss/nss_3.56.bb | 6 ------ 2 files changed, 26 deletions(-) delete mode 100644 meta-oe/recipes-support/nss/nss/signlibs.shmeta-oe/recipes-support/nss/nss/signlibs.sh deleted +0
-5@@ -1,20 +0,0 @@ -#!/bin/sh - -# signlibs.sh -# -# (c)2010 Wind River Systems, Inc.
Quoted 8 lines
meta-oe/recipes-support/nss/nss/signlibs.sh line 11
Quoted 6 lines
meta-oe/recipes-support/nss/nss/signlibs.sh deleted +0
-6-# -# regenerates the .chk files for the NSS libraries that require it -# since the ones that are built have incorrect checksums that were -# calculated on the host where they really need to be done on the -# target -if we remove this then how do we solve above said issue? is it still an issue ?
I think above said issue was resolved in 2013 with:
https://git.openembedded.org/openembedded-core/commit/?id=64e87fc6e99bc1d4807034166735034b1f92bad8
since then nobody should be running signlibs.sh on target (if it was already finished in do_rootfs) and if it works offline for read-only-rootfs then it doesn't really run on the target, right?
Quoted 45 lines
Quoted 45 lines
meta-oe/recipes-support/nss/nss/signlibs.sh deleted +0
-9-CHK_FILES=`ls /lib*/*.chk /usr/lib*/*.chk 2>/dev/null` -SIGN_BINARY=`which shlibsign` -for I in $CHK_FILES -do - DN=`dirname $I` - BN=`basename $I .chk` - FN=$DN/$BN.so - $SIGN_BINARY -i $FN -donemeta-oe/recipes-support/nss/nss_3.56.bb +0
-7@@ -21,7 +21,6 @@ VERSION_DIR = "${@d.getVar('BP').upper().replace('-', '_').replace('.', '_') + ' SRC_URI = "http://ftp.mozilla.org/pub/mozilla.org/security/nss/releases/${VERSION_DIR}/src/${BP}.tar.gz \ file://nss.pc.in \ - file://signlibs.sh \ file://0001-nss-fix-support-cross-compiling.patch \ file://nss-no-rpath-for-cross-compiling.patch \ file://nss-fix-incorrect-shebang-of-perl.patch \@@ -214,7 +213,6 @@ do_install_append() { touch ${D}/${libdir}/$file chmod 755 ${D}/${libdir}/$file done - install -D -m 755 ${WORKDIR}/signlibs.sh ${D}/${bindir}/signlibs.sh install -d ${D}${libdir}/pkgconfig/ sed 's/%NSS_VERSION%/${PV}/' ${WORKDIR}/nss.pc.in | sed 's/%NSPR_VERSION%/4.9.2/' > ${D}${libdir}/pkgconfig/nss.pc@@ -251,10 +249,6 @@ pkg_postinst_${PN} () { done } -pkg_postinst_ontarget_${PN} () { - ${bindir}/signlibs.sh -} - PACKAGES =+ "${PN}-smime" FILES_${PN}-smime = "\ ${bindir}/smime \ --2.25.1
Re: [oe] [meta-oe][PATCH] nss: remove signlibs.sh
Correct.
Quoted 235 lines · Martin Jansa
Quoted 1 line · Khem Raj
On Tue, Sep 1, 2020 at 3:41 PM Martin Jansa <[email protected]>
Quoted 3 lines · wrote:
Quoted 3 lines
Looks like my "solution" also isn't working well at least for images
with read-only-rootfs in
IMAGE_FEATURES.Quoted 3 lines
Quoted 3 lines
pkg_postinst_ontarget_${PN} is always forced to run on the target,
which for read-only-rootfs results in:
Quoted 5 lines
Quoted 5 lines
log.do_rootfs:
...
NOTE: If an image is being built, the postinstalls for the following
packages will be postponed for first boot: nss
Quoted 3 lines
Quoted 3 lines
...
ERROR: The following packages could not be configured offline and
rootfs is read-only: ['nss']
Quoted 11 lines
Quoted 11 lines
and now looking at the
/usr/bin/signlibs.shand it does pretty muchthe same as the postinst script when D isn't empty.
From oe-core git history it shows that
signlibs.shwas added first:https://git.openembedded.org/openembedded-core/commit/?id=a4580f967c8064294a06d406acf5deb24aee2acc
Quoted 1 line
Quoted 1 line
then the offline version of postinst was added to support
read-only-rootfs in:
Quoted 1 line
Quoted 1 line
https://git.openembedded.org/openembedded-core/commit/?id=64e87fc6e99bc1d4807034166735034b1f92bad8
Quoted 3 lines
Quoted 3 lines
and nss-native should always provide the shlibsign since:
https://git.openembedded.org/openembedded-core/commit/?id=88540c5b08dea069660d1a68e506aebdd68e6ae0
Quoted 3 lines
Quoted 3 lines
and only after
https://git.openembedded.org/openembedded-core/commit/?id=8f782f7095e718dd9452055af53363beb6bdbece
Quoted 5 lines
Quoted 5 lines
it looked like
signlibs.shwas something special only for target.So it looks to me, that we should just remove
signlibs.shscript andlet the same postinst be used on target and offline
Quoted 12 lines
Quoted 11 lines
(with or without D being empty).
Signed-off-by Martin Jansa <[email protected]>---
meta-oe/recipes-support/nss/nss/signlibs.sh | 20 --------------------meta-oe/recipes-support/nss/nss_3.56.bb | 6 ------Quoted 7 lines
Review
Quoted 7 lines
2 files changed, 26 deletions(-)delete mode 100644 meta-oe/recipes-support/nss/nss/signlibs.sh(quoted diff) +0
-0
b/meta-oe/recipes-support/nss/nss/signlibs.shQuoted 28 lines
Quoted 27 lines
deleted file mode 100644
index a74e499f8c..0000000000
---
a/meta-oe/recipes-support/nss/nss/signlibs.sh+++
/dev/nullmeta-oe/recipes-support/nss/nss/signlibs.sh deleted +0
-9@@ -1,20 +0,0 @@ -#!/bin/sh - -# signlibs.sh -# -# (c)2010 Wind River Systems, Inc. -# -# regenerates the .chk files for the NSS libraries that require it -# since the ones that are built have incorrect checksums that were -# calculated on the host where they really need to be done on theQuoted 7 lines
meta-oe/recipes-support/nss/nss/signlibs.sh line 11
Quoted 3 lines
meta-oe/recipes-support/nss/nss/signlibs.sh deleted +0
-2-# target -if we remove this then how do we solve above said issue? is it still an
issue ?
I think above said issue was resolved in 2013 with:
https://git.openembedded.org/openembedded-core/commit/?id=64e87fc6e99bc1d4807034166735034b1f92bad8
since then nobody should be running
signlibs.shon target (if it wasalready finished in
do_rootfs) and if it works offline for read-only-rootfsthen it doesn't really run on the target, right?
Quoted 14 lines
Quoted 13 lines
meta-oe/recipes-support/nss/nss/signlibs.sh deleted +0
-6-CHK_FILES=`ls /lib*/*.chk /usr/lib*/*.chk 2>/dev/null` -SIGN_BINARY=`which shlibsign` -for I in $CHK_FILES -do - DN=`dirname $I` - BN=`basename $I .chk`Quoted 7 lines
Review
Quoted 7 lines
meta-oe/recipes-support/nss/nss/signlibs.sh deleted +0
-3- FN=$DN/$BN.so - $SIGN_BINARY -i $FN -done(quoted diff) +0
-0b/meta-oe/recipes-support/nss/nss_3.56.bb
Quoted 7 lines
Review VERSION_DIR =
Quoted 7 lines
index
107b0a0152..997f8950fd100644--- a/meta-oe/recipes-support/nss/nss_3.56.bb
+++ b/meta-oe/recipes-support/nss/nss_3.56.bb
(quoted diff) +0
-0@@ -21,7 +21,6 @@ VERSION_DIR ="${@d.getVar('BP').upper().replace('-', '_').replace('.', '_') + '
Quoted 3 lines
Review VERSION_DIR = · line 21
Quoted 3 lines
(quoted diff) +0
-0SRC_URI = "http://ftp.mozilla.org/pub/mozilla.org/security/nss/releases/${VERSION_DIR}/src/${BP}.tar.gz
\Quoted 12 lines
Quoted 11 lines
meta-oe/recipes-support/nss/nss_3.56.bb +0
-1file://nss.pc.in \ - file://signlibs.sh \ file://0001-nss-fix-support-cross-compiling.patch \file://nss-no-rpath-for-cross-compiling.patch \ file://nss-fix-incorrect-shebang-of-perl.patch \(quoted diff) +0
-0@@ -214,7 +213,6 @@ do_install_append() {Quoted 7 lines
Review do_install_append() { · line 220
Quoted 7 lines
(quoted diff) +0
-1touch ${D}/${libdir}/$file chmod 755 ${D}/${libdir}/$file done - install -D -m 755 ${WORKDIR}/signlibs.sh
${D}/${bindir}/signlibs.shQuoted 5 lines
Quoted 5 lines
install -d ${D}${libdir}/pkgconfig/ sed 's/%NSS_VERSION%/${PV}/' ${WORKDIR}/nss.pc.in | sed's/%NSPR_VERSION%/4.9.2/' > ${D}${libdir}/pkgconfig/nss.pc
Quoted 29 lines
Quoted 29 lines
(quoted diff) +0
-5@@ -251,10 +249,6 @@ pkg_postinst_${PN} () { done } -pkg_postinst_ontarget_${PN} () { - ${bindir}/signlibs.sh -} - PACKAGES =+ "${PN}-smime" FILES_${PN}-smime = "\ ${bindir}/smime \ --2.25.1