xinput-calibrator: avoid defunct process
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 7 lines · On Friday, August 28, 2020 5:29:19 P.M. EDT Mark Asselstine wrote:
The
xinput_calibrator_once.shscript produces output on stdout and stderr which the current 'Exec' doesn't consume. This results in a [xinput_calibrator_once.sh] defunct process which will remain around until we exit the X11 session.Add a redirect to the Exec which will consume this output and avoid the defunct process.
Hold off on reviewing or merging this. Looking into another .desktop file which is causing yet another zombie process we are pretty sure there is a deeper issue at play here. I want to confirm and address what we are seeing before this is merged as it may not be needed.
Sorry about the churn. Things were only clear once the multiple issues were looked at.
2/2 is still valid, so if you want to take that one on its own, then go for it.
Thanks,
Mark Asselstine
Quoted 28 lines
Signed-off-by Mark Asselstine <[email protected]>---
V2: * no changes
.../recipes-graphics/xinput-calibrator/xinput-calibrator_git.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/meta/recipes-graphics/xinput-calibrator/xinput-calibrator_git.bb b/meta/recipes-graphics/xinput-calibrator/xinput-calibrator_git.bb index
4f831932e7..c59f97895c100644meta/recipes-graphics/xinput-calibrator/xinput-calibrator_git.bb +0
-0@@ -31,7 +31,7 @@ do_install_append() { install -m 0755 ${WORKDIR}/30xinput_calibrate.sh${D}${sysconfdir}/X11/Xsession.d/
install -d ${D}${sysconfdir}/xdg/autostart- sed -e 's,^Exec=.*,Exec=${bindir}/xinput_calibrator_once.sh,'
${S}/scripts/xinput_calibrator.desktop >
${D}${sysconfdir}/xdg/autostart/xinput_calibrator.desktop + sed -e
's,^Exec=.*,Exec=${bindir}/sh -c "${bindir}/xinput_calibrator_once.sh2>\&1Quoted 1 line
/dev/null",' ${S}/scripts/xinput_calibrator.desktop >${D}${sysconfdir}/xdg/autostart/xinput_calibrator.desktop }
FILES_${PN} += "${sysconfdir}/xdg/autostart"