Skip to contentSkip to conversation

ACPI/PRM: Find PRMT table before parse it

PATCH Superseded Aubrey Li 2 participants 2 messages Sep 8, 2021 ACPI

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Aubrey Li

author
#0 lore raw

PATCH 1/1 ACPI/PRM: Find PRMT table before parse it

Find and verify PRMT table before parse it, this eliminates a warning on machines without PRMT table.

	[    7.197173] ACPI: PRMT not present
---
 drivers/acpi/prmt.c | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)
drivers/acpi/prmt.c +9 -1
index 1f6007a..89c22bc 100644
@@ -288,10 +288,18 @@ static acpi_status acpi_platformrt_space_handler(u32 function,
 
 void __init init_prmt(void)
 {
+	struct acpi_table_header *tbl;
 	acpi_status status;
-	int mc = acpi_table_parse_entries(ACPI_SIG_PRMT, sizeof(struct acpi_table_prmt) +
+	int mc;
+
+	status = acpi_get_table(ACPI_SIG_PRMT, 0, &tbl);
+	if (ACPI_FAILURE(status))
+		return;
+
+	mc = acpi_table_parse_entries(ACPI_SIG_PRMT, sizeof(struct acpi_table_prmt) +
 					  sizeof (struct acpi_table_prmt_header),
 					  0, acpi_parse_prmt, 0);
+	acpi_put_table(tbl);
 	/*
 	 * Return immediately if PRMT table is not present or no PRM module found.
 	 */
Signature · 1 line
2.7.4
#1 lore raw

Dear Aubrey,

Am 08.09.21 um 04:09 schrieb Aubrey Li:

Quoted 4 lines

Find and verify PRMT table before parse it, this eliminates a warning on machines without PRMT table.

	[    7.197173] ACPI: PRMT not present

Please also add:

Fixes cefc7ca462 ("ACPI: PRM: implement OperationRegion handler for the PlatformRtMechanism subtype")
Quoted 20 lines
---
  drivers/acpi/prmt.c | 10 +++++++++-
  1 file changed, 9 insertions(+), 1 deletion(-)
drivers/acpi/prmt.c +4 -1
index 1f6007a..89c22bc 100644
@@ -288,10 +288,18 @@ static acpi_status acpi_platformrt_space_handler(u32 function,
 
  void __init init_prmt(void)
  {
+	struct acpi_table_header *tbl;
  	acpi_status status;
-	int mc = acpi_table_parse_entries(ACPI_SIG_PRMT, sizeof(struct acpi_table_prmt) +
+	int mc;
+
+	status = acpi_get_table(ACPI_SIG_PRMT, 0, &tbl);

drivers/acpi/prmt.c static acpi_status acpi_platformrt_space_handler(u32 function, · line 305

Quoted 10 lines
drivers/acpi/prmt.c +5 -0
+	if (ACPI_FAILURE(status))
+		return;
+
+	mc = acpi_table_parse_entries(ACPI_SIG_PRMT, sizeof(struct acpi_table_prmt) +
  					  sizeof (struct acpi_table_prmt_header),
  					  0, acpi_parse_prmt, 0);
+	acpi_put_table(tbl);
  	/*
  	 * Return immediately if PRMT table is not present or no PRM module found.
  	 */

Thank you very much for preparing the patch.

Kind regards,

Paul