Skip to contentSkip to conversation

staging: r8188eu: Remove unneeded if-null-free check

PATCH In review Jiapeng Chong 2 participants 2 messages Sep 18, 2021 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: r8188eu: Remove unneeded if-null-free check

Eliminate the following coccicheck warning:

./drivers/staging/r8188eu/os_dep/usb_intf.c:545:3-8: WARNING: NULL check before some freeing functions is not needed.

Fixes 2b42bd58b321 ("staging: r8188eu: introduce new os_dep dir for RTL8188eu driver")
---
 drivers/staging/r8188eu/os_dep/usb_intf.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/staging/r8188eu/os_dep/usb_intf.c +1 -3
index d04d2f65..7e42a0a 100644
@@ -541,9 +541,7 @@ static struct adapter *rtw_usb_if1_init(struct dvobj_priv *dvobj,
 	if (status != _SUCCESS) {
 		if (pnetdev)
 			rtw_free_netdev(pnetdev);
-		else if (padapter)
-			vfree(padapter);
-		padapter = NULL;
+		vfree(padapter);
 	}
 exit:
 	return padapter;
Signature · 1 line
1.8.3.1
maintainer
#1 lore raw
Quoted 30 lines · Jiapeng Chong

Eliminate the following coccicheck warning:

./drivers/staging/r8188eu/os_dep/usb_intf.c:545:3-8: WARNING: NULL check before some freeing functions is not needed.

Fixes 2b42bd58b321 ("staging: r8188eu: introduce new os_dep dir for RTL8188eu driver")
---
 drivers/staging/r8188eu/os_dep/usb_intf.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/staging/r8188eu/os_dep/usb_intf.c +1 -3
index d04d2f65..7e42a0a 100644
@@ -541,9 +541,7 @@ static struct adapter *rtw_usb_if1_init(struct dvobj_priv *dvobj,
 	if (status != _SUCCESS) {
 		if (pnetdev)
 			rtw_free_netdev(pnetdev);
-		else if (padapter)
-			vfree(padapter);
-		padapter = NULL;
+		vfree(padapter);
 	}
 exit:
 	return padapter;
Signature · 1 line
1.8.3.1

You just changed how this function works. :(

Please be MUCH more careful, and fix your robot.

greg k-h