Skip to contentSkip to conversation

patch "debugfs: debugfs_create_file_size(): use IS_ERR to check for error" added to driver-core-linus

PATCH [email protected] 1 participant 1 message Sep 21, 2021

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

debugfs: debugfs_create_file_size(): use IS_ERR to check for error

to my driver-core git tree which can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git
in the driver-core-linus branch.

The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.)

The patch will hopefully also be merged in Linus's tree for the next -rc kernel release.

If you have any questions about this process, please let me know.

From af505cad9567f7a500d34bf183696d570d7f6810 Mon Sep 17 00:00:00 2001
From: Nirmoy Das <[email protected]>
Date: Thu, 2 Sep 2021 12:29:17 +0200
Subject: debugfs: debugfs_create_file_size(): use IS_ERR to check for error
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

debugfs_create_file() returns encoded error so use IS_ERR for checking return value.

Fixes ff9fb72bc077 ("debugfs: return error values, not NULL")
Cc stable <[email protected]>

References: https://gitlab.freedesktop.org/drm/amd/-/issues/1686

---
 fs/debugfs/inode.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/debugfs/inode.c +1 -1
index 8129a430d789..2f117c57160d 100644
@@ -528,7 +528,7 @@ void debugfs_create_file_size(const char *name, umode_t mode,
 {
 	struct dentry *de = debugfs_create_file(name, mode, parent, data, fops);
 
-	if (de)
+	if (!IS_ERR(de))
 		d_inode(de)->i_size = file_size;
 }
 EXPORT_SYMBOL_GPL(debugfs_create_file_size);
Signature · 1 line
2.33.0