patch "staging: vc04_services: shut up out-of-range warning" added to staging-linus
Subsystems (3)
This is a note to let you know that I've just added the patch titled
staging: vc04_services: shut up out-of-range warning
to my staging git tree which can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
in the staging-linus branch.
The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.)
The patch will hopefully also be merged in Linus's tree for the next -rc kernel release.
If you have any questions about this process, please let me know.
From 7ff4034e910fe00a90d985f0d05bacf60c162f02 Mon Sep 17 00:00:00 2001
From: Arnd Bergmann <[email protected]>
Date: Mon, 27 Sep 2021 13:36:56 +0200
Subject: staging: vc04_services: shut up out-of-range warning
The comparison against SIZE_MAX produces a harmless warning on 64-bit architectures:
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:185:16: error: result of comparison of constant 419244183493398898 with expression of type 'unsigned int' is always false [-Werror,-Wtautological-constant-out-of-range-compare]
if (num_pages > (SIZE_MAX - sizeof(struct pagelist) -
~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Shut up that warning by adding a cast to a longer type.
--- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c +1 -1
@@ -182,7 +182,7 @@ create_pagelist(char *buf, char __user *ubuf, offset = (uintptr_t )ubuf & (PAGE_SIZE -1 ); num_pages =DIV_ROUND_UP (count + offset,PAGE_SIZE ); -if (num_pages > (SIZE_MAX -sizeof (struct pagelist ) - +if ((size_t )num_pages > (SIZE_MAX -sizeof (struct pagelist ) -sizeof (struct vchiq_pagelist_info )) / (sizeof (u32) +sizeof (pages[0 ]) +sizeof (struct scatterlist )))
Signature · 1 line
2.33.0