Skip to contentSkip to conversation

ASoC: wcd938x: Fix jack detection issue

PATCH In review Srinivasa Rao Mandadapu 3 participants 3 messages Oct 7, 2021

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ASoC: wcd938x: Fix jack detection issue

This patch is to fix audio 3.5mm jack detection failure on wcd938x codec based target.

Fixes bcee7ed09b8e (ASoC: codecs: wcd938x: add Multi Button Headset Control support)
---
 sound/soc/codecs/wcd938x.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
sound/soc/codecs/wcd938x.c +3 -3
index f0daf8d..52de7d1 100644
@@ -4144,10 +4144,10 @@ static int wcd938x_codec_set_jack(struct snd_soc_component *comp,
 {
 	struct wcd938x_priv *wcd = dev_get_drvdata(comp->dev);
 
-	if (!jack)
+	if (jack)
 		return wcd_mbhc_start(wcd->wcd_mbhc, &wcd->mbhc_cfg, jack);
-
-	wcd_mbhc_stop(wcd->wcd_mbhc);
+	else
+		wcd_mbhc_stop(wcd->wcd_mbhc);
 
 	return 0;
 }
Signature · 2 lines
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc.,
is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.
Reviewed-by on v1 1/1
#1 lore raw
Quoted 7 lines · Srinivasa Rao Mandadapu

This patch is to fix audio 3.5mm jack detection failure on wcd938x codec based target.

Fixes bcee7ed09b8e (ASoC: codecs: wcd938x: add Multi Button Headset Control support)
Quoted 23 lines
---
  sound/soc/codecs/wcd938x.c | 6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)
sound/soc/codecs/wcd938x.c +3 -3
index f0daf8d..52de7d1 100644
@@ -4144,10 +4144,10 @@ static int wcd938x_codec_set_jack(struct snd_soc_component *comp,
  {
  	struct wcd938x_priv *wcd = dev_get_drvdata(comp->dev);
 
-	if (!jack)
+	if (jack)
  		return wcd_mbhc_start(wcd->wcd_mbhc, &wcd->mbhc_cfg, jack);
-
-	wcd_mbhc_stop(wcd->wcd_mbhc);
+	else
+		wcd_mbhc_stop(wcd->wcd_mbhc);
 
  	return 0;
  }
maintainer
#2 lore raw
In reply to Srinivasa Rao Mandadapu
Quoted 6 lines · Srinivasa Rao Mandadapu

This patch is to fix audio 3.5mm jack detection failure on wcd938x codec based target.

Fixes bcee7ed09b8e (ASoC: codecs: wcd938x: add Multi Button Headset Control support)

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: wcd938x: Fix jack detection issue

      commit: db0767b8a6e620b99459d2e688c1983c2e5add0d

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark