acpi: replace snprintf in show functions with sysfs_emit
PATCH 1/1 acpi: replace snprintf in show functions with sysfs_emit
coccicheck complains about the use of snprintf() in sysfs show functions.
Fix the coccicheck warning:
WARNING: use scnprintf or sprintf.
Use sysfs_emit instead of scnprintf or sprintf makes more sense.
Signed-off-by Qing Wang <[email protected]>
--- drivers/acpi/acpi_lpss.c | 2 +- drivers/acpi/dock.c | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-)
drivers/acpi/acpi_lpss.c +1 -1
@@ -748,7 +748,7 @@ static ssize_t lpss_ltr_show(struct device *dev, struct device_attribute *attr,if (ret)return ret; -return snprintf (buf,PAGE_SIZE ,"%08x\n" , ltr_value); +return sysfs_emit (buf,"%08x\n" , ltr_value); } static ssize_t lpss_ltr_mode_show(struct device *dev,
drivers/acpi/dock.c +4 -4
@@ -492,7 +492,7 @@ static ssize_t docked_show(struct device *dev,struct acpi_device *adev =NULL ;acpi_bus_get_device (dock_station->handle, &adev); -return snprintf (buf,PAGE_SIZE ,"%u\n" ,acpi_device_enumerated (adev)); +return sysfs_emit (buf,"%u\n" ,acpi_device_enumerated (adev)); }static DEVICE_ATTR_RO (docked);
@@ -504,7 +504,7 @@ static ssize_t flags_show(struct device *dev, {struct dock_station *dock_station = dev->platform_data; -return snprintf (buf,PAGE_SIZE ,"%d\n" , dock_station->flags); +return sysfs_emit (buf,"%d\n" , dock_station->flags); }static DEVICE_ATTR_RO (flags);
@@ -543,7 +543,7 @@ static ssize_t uid_show(struct device *dev,if (ACPI_FAILURE (status))return 0 ; -return snprintf (buf,PAGE_SIZE ,"%llx\n" , lbuf); +return sysfs_emit (buf,"%llx\n" , lbuf); }static DEVICE_ATTR_RO (uid);
@@ -562,7 +562,7 @@ static ssize_t type_show(struct device *dev,else type ="unknown" ; -return snprintf (buf,PAGE_SIZE ,"%s\n" , type); +return sysfs_emit (buf,"%s\n" , type); }static DEVICE_ATTR_RO (type);
Signature · 1 line
2.7.4
Quoted 59 lines · Qing Wang
coccicheck complains about the use of
snprintf()in sysfs show functions.Fix the coccicheck warning:
WARNING: use scnprintf or sprintf.Use
sysfs_emitinstead of scnprintf or sprintf makes more sense.Signed-off-by Qing Wang <[email protected]>--- drivers/acpi/acpi_lpss.c | 2 +- drivers/acpi/dock.c | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-)drivers/acpi/acpi_lpss.c +1
-1@@ -748,7 +748,7 @@ static ssize_t lpss_ltr_show(struct device *dev, struct device_attribute *attr,if (ret)return ret; -return snprintf (buf,PAGE_SIZE ,"%08x\n" , ltr_value); +return sysfs_emit (buf,"%08x\n" , ltr_value); } static ssize_t lpss_ltr_mode_show(struct device *dev,drivers/acpi/dock.c +3
-3@@ -492,7 +492,7 @@ static ssize_t docked_show(struct device *dev,struct acpi_device *adev =NULL ;acpi_bus_get_device (dock_station->handle, &adev); -return snprintf (buf,PAGE_SIZE ,"%u\n" ,acpi_device_enumerated (adev)); +return sysfs_emit (buf,"%u\n" ,acpi_device_enumerated (adev)); }static DEVICE_ATTR_RO (docked);@@ -504,7 +504,7 @@ static ssize_t flags_show(struct device *dev, {struct dock_station *dock_station = dev->platform_data; -return snprintf (buf,PAGE_SIZE ,"%d\n" , dock_station->flags); +return sysfs_emit (buf,"%d\n" , dock_station->flags); }static DEVICE_ATTR_RO (flags);@@ -543,7 +543,7 @@ static ssize_t uid_show(struct device *dev,if (ACPI_FAILURE (status))return 0 ; -return snprintf (buf,PAGE_SIZE ,"%llx\n" , lbuf); +return sysfs_emit (buf,"%llx\n" , lbuf); }static DEVICE_ATTR_RO (uid);
drivers/acpi/dock.c static ssize_t type_show(struct device *dev,
Quoted 9 lines
drivers/acpi/dock.c +1
-2@@ -562,7 +562,7 @@ static ssize_t type_show(struct device *dev,else type ="unknown" ; -return snprintf (buf,PAGE_SIZE ,"%s\n" , type); +return sysfs_emit (buf,"%s\n" , type); }static DEVICE_ATTR_RO (type); --
Applied as 5.16 material with some edits in the subject and changelog, thanks!