hwmon: replace snprintf in show functions with sysfs_emit
PATCH 1/1 hwmon: replace snprintf in show functions with sysfs_emit
show() must not use snprintf() when formatting the value to be returned to user space.
Fix the following coccicheck warning:drivers/hwmon/smm665.c:378: WARNING: use scnprintf or sprintf.
Use sysfs_emit instead of scnprintf or sprintf makes more sense.
Signed-off-by Qing Wang <[email protected]>
--- drivers/hwmon/smm665.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/hwmon/smm665.c +1 -1
@@ -375,7 +375,7 @@ static ssize_t smm665_show_##what(struct device *dev, \ { \struct sensor_device_attribute *attr =to_sensor_dev_attr (da); \ const int val = smm665_get_##what(dev, attr->index); \ - return snprintf(buf, PAGE_SIZE, "%d\n", val); \ + return sysfs_emit(buf, "%d\n", val); \ }SMM665_SHOW (min);
Signature · 1 line
2.7.4
Guenter Roeck
maintainerQuoted 9 lines · Qing Wang
show()must not usesnprintf()when formatting the value to be returned to user space.Fix the following coccicheck warning:
drivers/hwmon/smm665.c:378: WARNING: use scnprintf or sprintf.Use
sysfs_emitinstead of scnprintf or sprintf makes more sense.Signed-off-by Qing Wang <[email protected]>
Please refrain from such cleanup patches unless you also make functional changes to a driver.
Guenter
Quoted 18 lines
--- drivers/hwmon/smm665.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/hwmon/smm665.c +1
-1@@ -375,7 +375,7 @@ static ssize_t smm665_show_##what(struct device *dev, \ { \struct sensor_device_attribute *attr =to_sensor_dev_attr (da); \ const int val = smm665_get_##what(dev, attr->index); \ - return snprintf(buf, PAGE_SIZE, "%d\n", val); \ + return sysfs_emit(buf, "%d\n", val); \ }SMM665_SHOW (min);