Skip to contentSkip to conversation

hwmon: replace snprintf in show functions with sysfs_emit

PATCH In review Qing Wang 2 participants 2 messages Oct 15, 2021 Hardware monitoring

lore
Share & tools
lore

Qing Wang

author
#0 lore raw

PATCH 1/1 hwmon: replace snprintf in show functions with sysfs_emit

show() must not use snprintf() when formatting the value to be returned to user space.

Fix the following coccicheck warning:
drivers/hwmon/smm665.c:378: WARNING: use scnprintf or sprintf.

Use sysfs_emit instead of scnprintf or sprintf makes more sense.

---
 drivers/hwmon/smm665.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/hwmon/smm665.c +1 -1
index 62906d9..122031e 100644
@@ -375,7 +375,7 @@ static ssize_t smm665_show_##what(struct device *dev, \
 { \
 	struct sensor_device_attribute *attr = to_sensor_dev_attr(da); \
 	const int val = smm665_get_##what(dev, attr->index); \
-	return snprintf(buf, PAGE_SIZE, "%d\n", val); \
+	return sysfs_emit(buf, "%d\n", val); \
 }
 
 SMM665_SHOW(min);
Signature · 1 line
2.7.4
maintainer
#1 lore raw
Quoted 9 lines · Qing Wang

show() must not use snprintf() when formatting the value to be returned to user space.

Fix the following coccicheck warning:
drivers/hwmon/smm665.c:378: WARNING: use scnprintf or sprintf.

Use sysfs_emit instead of scnprintf or sprintf makes more sense.

Please refrain from such cleanup patches unless you also make functional changes to a driver.

Guenter

Quoted 18 lines
---
  drivers/hwmon/smm665.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/hwmon/smm665.c +1 -1
index 62906d9..122031e 100644
@@ -375,7 +375,7 @@ static ssize_t smm665_show_##what(struct device *dev, \
  { \
  	struct sensor_device_attribute *attr = to_sensor_dev_attr(da); \
  	const int val = smm665_get_##what(dev, attr->index); \
-	return snprintf(buf, PAGE_SIZE, "%d\n", val); \
+	return sysfs_emit(buf, "%d\n", val); \
  }
 
  SMM665_SHOW(min);