Skip to contentSkip to conversation

ASUS My-Cinema remote patch

linux-dvb Bozhan Boiadzhiev 3 participants 5 messages Jun 15, 2008 – Jul 17, 2008 2 messages not in the archive Media (V4L/DVB)

lore
Share & tools
lore
#0 lore raw

ok i'll test patch later.
thanks
:)

Quoted 86 lines

-------- Оригинално писмо --------
От: hermann pitton
Относно: Re: [linux-dvb] ASUS My-Cinema remote patch До: Bozhan Boiadzhiev
Изпратено на: Неделя, 2008, Юни 15 04:53:14 EEST

Hi Bozhan,

Am Samstag, den 14.06.2008, 23:44 +0300 schrieb Bozhan Boiadzhiev:

Quoted 6 lines

ASUS My-Cinema package include remote
here i found patch for 2.6.22 https://bugs.launchpad.net/ubuntu/+source/linux-source-2.6.22/+bug/141622
Please include it!
All ASUS My-Cinema comes with remote control.
Thanks.

the video4linux-list is the better place for analog only cards.

The problem is known, but we had no testers.

The old Asus TVFM35 is not identical to your card.

It seems to have different s-video and composite inputs and also came with an USB remote. Adding a new, on the old card not present remote now there, seems to be confusing for the users.

The new tuner type tda8275a is auto detected, that makes the old entry working for you. It has the previous tda8275 not "a".

The problem is the unchanged PCI subsystem on your card, which causes that it is autodetected as card=53.

The following untested patch is a first try to detect your card and add a separate entry for it. We discussed this once.

Cheers,
Hermann

diff -r 2a89445f3b24 linux/drivers/media/video/saa7134/saa7134-cards.c

linux/drivers/media/video/saa7134/saa7134-cards.c Sun Jun 15 01:55:38 2008 +0200 renamed from linux/drivers/media/video/saa7134/saa7134-cards.c Tue Jun 10 11:22:00 2008 -0300 +18 -0
@@ -4401,6 +4401,39 @@ struct saa7134_board saa7134_boards[] =
               },
               /* no DVB support for now */
               /* .mpeg           = SAA7134_MPEG_DVB, */
+       },
+       [SAA7134_BOARD_ASUSTeK_P7131_ANALOG] = {
+               .name           = "ASUSTeK P7131 Analog",
+               .audio_clock    = 0x00187de7,
+               .tuner_type     = TUNER_PHILIPS_TDA8290,
+               .radio_type     = UNSET,
+               .tuner_addr     = ADDR_UNSET,
+               .radio_addr     = ADDR_UNSET,
+               .gpiomask       = 1 i2c_adap, &msg, 1);
               break;
       }
+       case SAA7134_BOARD_ASUSTeK_TVFM7135:
+       /* The card is misdetected as card=53, but is different */
+               if(dev->autodetected && (dev->eedata[0x27] == 0x03)) {
+                       dev->board = SAA7134_BOARD_ASUSTeK_P7131_ANALOG;
+                       printk(KERN_INFO "%s: P7131 analog only using "
+                                                       "entry of %s\n",
+                       dev->name, saa7134_boards[dev->board].name);
+               }
+               break;
       case SAA7134_BOARD_HAUPPAUGE_HVR1110:
               hauppauge_eeprom(dev, dev->eedata+0x80);
               /* break intentionally omitted */

diff -r 2a89445f3b24 linux/drivers/media/video/saa7134/saa7134-input.c

linux/drivers/media/video/saa7134/saa7134-input.c Sun Jun 15 01:55:38 2008 +0200 renamed from linux/drivers/media/video/saa7134/saa7134-input.c Tue Jun 10 11:22:00 2008 -0300 +1 -0
@@ -400,6 +400,7 @@ int saa7134_input_init1(struct saa7134_d
               break;
       case SAA7134_BOARD_ASUSTeK_P7131_DUAL:
       case SAA7134_BOARD_ASUSTeK_P7131_HYBRID_LNA:
+       case SAA7134_BOARD_ASUSTeK_P7131_ANALOG:
               ir_codes     = ir_codes_asus_pc39;
               mask_keydown = 0x0040000;
               rc5_gpio = 1;

diff -r 2a89445f3b24 linux/drivers/media/video/saa7134/saa7134.h

linux/drivers/media/video/saa7134/saa7134.h Sun Jun 15 01:55:38 2008 +0200 struct saa7134_format { · line 279

Quoted 7 lines
linux/drivers/media/video/saa7134/saa7134.h Sun Jun 15 01:55:38 2008 +0200 renamed from linux/drivers/media/video/saa7134/saa7134.h Tue Jun 10 11:22:00 2008 -0300 +1 -0
@@ -273,6 +273,7 @@ struct saa7134_format {
 #define SAA7134_BOARD_BEHOLD_H6      142
 #define SAA7134_BOARD_BEHOLD_M63      143
 #define SAA7134_BOARD_BEHOLD_M6_EXTRA    144
+#define SAA7134_BOARD_ASUSTeK_P7131_ANALOG 145
 
 #define SAA7134_MAXBOARDS 8
 #define SAA7134_INPUT_MAX 8

_______________________________________________
linux-dvb mailing list
[email protected]
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb

#1 lore raw

Hi,

Am Sonntag, den 15.06.2008, 13:03 +0300 schrieb Bozhan Boiadzhiev:

Quoted 4 lines

ok i'll test patch later.
thanks
:)

here is an updated version after latest changes by Matthias and Tim on saa7134. Should work.

Can't do much more on it.

Hartmut, Mauro, the eeprom detection is very basic, but should work. I sign off so far. Also attached.

Cheers,
Hermann

saa7134: add a separate entry for the ASUSTeK P7131 analog only
and do some eeprom detection to escape from the TVFM35 with the same PCI subsystem on auto detection.

linux/Documentation/video4linux/CARDLIST.saa7134 Sun Jun 15 22:25:29 2008 +0200 renamed from linux/Documentation/video4linux/CARDLIST.saa7134 Sun Jun 15 10:33:42 2008 -0300 +1 -0
diff -r 78442352b885 linux/Documentation/video4linux/CARDLIST.saa7134
@@ -143,3 +143,4 @@ 142 -> Beholder BeholdTV H6
 142 -> Beholder BeholdTV H6                     [5ace:6290]
 143 -> Beholder BeholdTV M63                    [5ace:6191]
 144 -> Beholder BeholdTV M6 Extra               [5ace:6193]
+145 -> ASUSTeK P7131 Analog
linux/drivers/media/video/saa7134/saa7134-cards.c Sun Jun 15 22:25:29 2008 +0200 renamed from linux/drivers/media/video/saa7134/saa7134-cards.c Sun Jun 15 10:33:42 2008 -0300 +43 -0

61 lines not on this page · raw message

linux/drivers/media/video/saa7134/saa7134-input.c Sun Jun 15 22:25:29 2008 +0200 renamed from linux/drivers/media/video/saa7134/saa7134-input.c Sun Jun 15 10:33:42 2008 -0300 +1 -0
diff -r 78442352b885 linux/drivers/media/video/saa7134/saa7134-input.c
@@ -409,6 +409,7 @@ int saa7134_input_init1(struct saa7134_d
                break;
        case SAA7134_BOARD_ASUSTeK_P7131_DUAL:
        case SAA7134_BOARD_ASUSTeK_P7131_HYBRID_LNA:
+       case SAA7134_BOARD_ASUSTeK_P7131_ANALOG:
                ir_codes     = ir_codes_asus_pc39;
                mask_keydown = 0x0040000;
                rc5_gpio = 1;
linux/drivers/media/video/saa7134/saa7134.h Sun Jun 15 22:25:29 2008 +0200 renamed from linux/drivers/media/video/saa7134/saa7134.h Sun Jun 15 10:33:42 2008 -0300 +1 -0
diff -r 78442352b885 linux/drivers/media/video/saa7134/saa7134.h
@@ -273,6 +273,7 @@ struct saa7134_format {
 #define SAA7134_BOARD_BEHOLD_H6      142
 #define SAA7134_BOARD_BEHOLD_M63      143
 #define SAA7134_BOARD_BEHOLD_M6_EXTRA    144
+#define SAA7134_BOARD_ASUSTeK_P7131_ANALOG 145
 
 #define SAA7134_MAXBOARDS 8
 #define SAA7134_INPUT_MAX 8
Quoted 32 lines
Quoted 32 lines

-------- Оригинално писмо --------
От: hermann pitton
Относно: Re: [linux-dvb] ASUS My-Cinema remote patch До: Bozhan Boiadzhiev
Изпратено на: Неделя, 2008, Юни 15 04:53:14 EEST

Hi Bozhan,

Am Samstag, den 14.06.2008, 23:44 +0300 schrieb Bozhan Boiadzhiev:

Quoted 6 lines

ASUS My-Cinema package include remote
here i found patch for 2.6.22 https://bugs.launchpad.net/ubuntu/+source/linux-source-2.6.22/+bug/141622
Please include it!
All ASUS My-Cinema comes with remote control.
Thanks.

the video4linux-list is the better place for analog only cards.

The problem is known, but we had no testers.

The old Asus TVFM35 is not identical to your card.

It seems to have different s-video and composite inputs and also came with an USB remote. Adding a new, on the old card not present remote now there, seems to be confusing for the users.

The new tuner type tda8275a is auto detected, that makes the old entry working for you. It has the previous tda8275 not "a".

The problem is the unchanged PCI subsystem on your card, which causes that it is autodetected as card=53.

Quoted 6 lines
Quoted 6 lines

The following untested patch is a first try to detect your card and add a separate entry for it. We discussed this once.

Cheers,
Hermann

linux/Documentation/video4linux/CARDLIST.saa7134 +1 -0
diff -r 78442352b885 linux/Documentation/video4linux/CARDLIST.saa7134
@@ -143,3 +143,4 @@ 142 -> Beholder BeholdTV H6             
 142 -> Beholder BeholdTV H6                     [5ace:6290]
 143 -> Beholder BeholdTV M63                    [5ace:6191]
 144 -> Beholder BeholdTV M6 Extra               [5ace:6193]
+145 -> ASUSTeK P7131 Analog
linux/drivers/media/video/saa7134/saa7134-cards.c +43 -0

61 lines not on this page · raw message

linux/drivers/media/video/saa7134/saa7134-input.c +1 -0
diff -r 78442352b885 linux/drivers/media/video/saa7134/saa7134-input.c
@@ -409,6 +409,7 @@ int saa7134_input_init1(struct saa7134_d
 		break;
 	case SAA7134_BOARD_ASUSTeK_P7131_DUAL:
 	case SAA7134_BOARD_ASUSTeK_P7131_HYBRID_LNA:
+	case SAA7134_BOARD_ASUSTeK_P7131_ANALOG:
 		ir_codes     = ir_codes_asus_pc39;
 		mask_keydown = 0x0040000;
 		rc5_gpio = 1;
linux/drivers/media/video/saa7134/saa7134.h +1 -0
diff -r 78442352b885 linux/drivers/media/video/saa7134/saa7134.h
@@ -273,6 +273,7 @@ struct saa7134_format {
 #define SAA7134_BOARD_BEHOLD_H6      142
 #define SAA7134_BOARD_BEHOLD_M63      143
 #define SAA7134_BOARD_BEHOLD_M6_EXTRA    144
+#define SAA7134_BOARD_ASUSTeK_P7131_ANALOG 145
 
 #define SAA7134_MAXBOARDS 8
 #define SAA7134_INPUT_MAX 8

--
video4linux-list mailing list
Unsubscribe mailto:[email protected]?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list

#3 lore raw
In reply to a message not in the archive
Quoted 8 lines · On Sun, 15 Jun 2008 22:34:35 +0200 hermann pitton <[email protected]>…

Hi,

Am Sonntag, den 15.06.2008, 13:03 +0300 schrieb Bozhan Boiadzhiev:

Quoted 4 lines

ok i'll test patch later.
thanks
:)

Quoted 7 lines

here is an updated version after latest changes by Matthias and Tim on saa7134. Should work.

Can't do much more on it.

Hartmut, Mauro, the eeprom detection is very basic, but should work. I sign off so far. Also attached.

Patch applied. I had to manually fix a conflict with a previously applied one. Please check.

Cheers,
Mauro

_______________________________________________
linux-dvb mailing list
[email protected]
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb

#4 lore raw

Hi,

Am Samstag, den 12.07.2008, 09:29 -0300 schrieb Mauro Carvalho Chehab:

Quoted 16 lines
Quoted 13 lines · On Sun, 15 Jun 2008 22:34:35 +0200 hermann pitton <[email protected]>…

Hi,

Am Sonntag, den 15.06.2008, 13:03 +0300 schrieb Bozhan Boiadzhiev:

Quoted 4 lines

ok i'll test patch later.
thanks
:)

here is an updated version after latest changes by Matthias and Tim on saa7134. Should work.

Can't do much more on it.

Quoted 7 lines
Quoted 2 lines

Hartmut, Mauro, the eeprom detection is very basic, but should work. I sign off so far. Also attached.

Patch applied. I had to manually fix a conflict with a previously applied one. Please check.

Cheers,
Mauro

latest version around with TVFM7135 device name fix was here.

http://www.spinics.net/lists/vfl/msg37290.html

Latest questions on it are in the same thread.

Mauro, almost all my tabs were lost, maybe it works better with attachments.

Cheers,
Hermann

saa7134: update the Asustek P7131 Analog patch to latest
version and also try to replace lost tabs.

linux/drivers/media/video/saa7134/saa7134-cards.c +43 -46
diff -r 0ebffe1cc136 linux/drivers/media/video/saa7134/saa7134-cards.c
@@ -3558,39 +3558,39 @@ struct saa7134_board saa7134_boards[] = 
 			.amux = TV,
 			.gpio = 0x0200000,
 		},
-       },
-       [SAA7134_BOARD_ASUSTeK_P7131_ANALOG] = {
-	       .name           = "ASUSTeK P7131 Analog",
-	       .audio_clock    = 0x00187de7,
-	       .tuner_type     = TUNER_PHILIPS_TDA8290,
-	       .radio_type     = UNSET,
-	       .tuner_addr     = ADDR_UNSET,
-	       .radio_addr     = ADDR_UNSET,
-	       .gpiomask       = 1 << 21,
-	       .inputs         = {{
-		       .name = name_tv,
-		       .vmux = 1,
-		       .amux = TV,
-		       .tv   = 1,
-		       .gpio = 0x0000000,
-	       }, {
-		       .name = name_comp1,
-		       .vmux = 3,
-		       .amux = LINE2,
-	       }, {
-		       .name = name_comp2,
-		       .vmux = 0,
-		       .amux = LINE2,
-	       }, {
-		       .name = name_svideo,
-		       .vmux = 8,
-		       .amux = LINE2,
-	       } },
-	       .radio = {
-		       .name = name_radio,
-		       .amux = TV,
-		       .gpio = 0x0200000,
-	       },
+	},
+	[SAA7134_BOARD_ASUSTeK_P7131_ANALOG] = {
+		.name           = "ASUSTeK P7131 Analog",
+		.audio_clock    = 0x00187de7,
+		.tuner_type     = TUNER_PHILIPS_TDA8290,
+		.radio_type     = UNSET,
+		.tuner_addr     = ADDR_UNSET,
+		.radio_addr     = ADDR_UNSET,
+		.gpiomask       = 1 << 21,
+		.inputs         = {{
+			.name = name_tv,
+			.vmux = 1,
+			.amux = TV,
+			.tv   = 1,
+			.gpio = 0x0000000,
+		}, {
+			.name = name_comp1,
+			.vmux = 3,
+			.amux = LINE2,
+		}, {
+			.name = name_comp2,
+			.vmux = 0,
+			.amux = LINE2,
+		}, {
+			.name = name_svideo,
+			.vmux = 8,
+			.amux = LINE2,
+		} },
+		.radio = {
+			.name = name_radio,
+			.amux = TV,
+			.gpio = 0x0200000,
+		},
 	},
 	[SAA7134_BOARD_SABRENT_TV_PCB05] = {
 		.name           = "Sabrent PCMCIA TV-PCB05",
@@ -5737,7 +5737,7 @@ int saa7134_board_init1(struct saa7134_d
 	case SAA7134_BOARD_FLYDVBT_LR301:
 	case SAA7134_BOARD_ASUSTeK_P7131_DUAL:
 	case SAA7134_BOARD_ASUSTeK_P7131_HYBRID_LNA:
-       case SAA7134_BOARD_ASUSTeK_P7131_ANALOG:
+	case SAA7134_BOARD_ASUSTeK_P7131_ANALOG:
 	case SAA7134_BOARD_FLYDVBTDUO:
 	case SAA7134_BOARD_PROTEUS_2309:
 	case SAA7134_BOARD_AVERMEDIA_A16AR:
@@ -6078,18 +6078,15 @@ int saa7134_board_init2(struct saa7134_d
 		i2c_transfer(&dev->i2c_adap, &msg, 1);
 		break;
 	}
-#if 0
-	/* FIXME: This entry doesn't exist yet */
-       case SAA7134_BOARD_ASUSTeK_TVFM35:
-       /* The card below is detected as card=53, but is different */
-	       if (dev->autodetected && (dev->eedata[0x27] == 0x03)) {
-		       dev->board = SAA7134_BOARD_ASUSTeK_P7131_ANALOG;
-		       printk(KERN_INFO "%s: P7131 analog only, using "
-						       "entry of %s\n",
-		       dev->name, saa7134_boards[dev->board].name);
-	       }
-	       break;
-#endif
+	case SAA7134_BOARD_ASUSTeK_TVFM7135:
+	/* The card below is detected as card=53, but is different */
+		if (dev->autodetected && (dev->eedata[0x27] == 0x03)) {
+			dev->board = SAA7134_BOARD_ASUSTeK_P7131_ANALOG;
+			printk(KERN_INFO "%s: P7131 analog only, using "
+							"entry of %s\n",
+			dev->name, saa7134_boards[dev->board].name);
+		}
+		break;
 	case SAA7134_BOARD_HAUPPAUGE_HVR1110:
 		hauppauge_eeprom(dev, dev->eedata+0x80);
 		/* break intentionally omitted */
linux/drivers/media/video/saa7134/saa7134-input.c +1 -1
diff -r 0ebffe1cc136 linux/drivers/media/video/saa7134/saa7134-input.c
@@ -409,7 +409,7 @@ int saa7134_input_init1(struct saa7134_d
 		break;
 	case SAA7134_BOARD_ASUSTeK_P7131_DUAL:
 	case SAA7134_BOARD_ASUSTeK_P7131_HYBRID_LNA:
-       case SAA7134_BOARD_ASUSTeK_P7131_ANALOG:
+	case SAA7134_BOARD_ASUSTeK_P7131_ANALOG:
 		ir_codes     = ir_codes_asus_pc39;
 		mask_keydown = 0x0040000;
 		rc5_gpio = 1;

--
video4linux-list mailing list
Unsubscribe mailto:[email protected]?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list

#6 lore raw
In reply to a message not in the archive
Quoted 10 lines · On Sat, 12 Jul 2008 23:14:09 +0200 hermann pitton <[email protected]>…

Latest questions on it are in the same thread.

Mauro, almost all my tabs were lost, maybe it works better with attachments.

Cheers,
Hermann

saa7134: update the Asustek P7131 Analog patch to latest
version and also try to replace lost tabs.

The patch seems to have whitespaces mangled. I'm fixing the original patch at -git and applying a patch, based on yours, fixing this issue.

Cheers,
Mauro

_______________________________________________
linux-dvb mailing list
[email protected]
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb