memory: tegra20-emc: replace DEFINE_SIMPLE_ATTRIBUTE with DEFINE_DEBUGFS_ATTRIBUTE
Subsystems (2)
PATCH 1/1 memory: tegra20-emc: replace DEFINE_SIMPLE_ATTRIBUTE with DEFINE_DEBUGFS_ATTRIBUTE
Fix the following coccicheck warning:
./drivers/memory/tegra/tegra20-emc.c:915:0-23: WARNING:tegra_emc_debug_max_rate_fops should be defined with DEFINE_DEBUGFS_ATTRIBUTE ./drivers/memory/tegra/tegra20-emc.c:885:0-23: WARNING:tegra_emc_debug_min_rate_fops should be defined with DEFINE_DEBUGFS_ATTRIBUTE
--- drivers/memory/tegra/tegra20-emc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/memory/tegra/tegra20-emc.c +2 -2
@@ -882,7 +882,7 @@ static int tegra_emc_debug_min_rate_set(void *data, u64 rate)return 0 ; } -DEFINE_SIMPLE_ATTRIBUTE (tegra_emc_debug_min_rate_fops, +DEFINE_DEBUGFS_ATTRIBUTE (tegra_emc_debug_min_rate_fops, tegra_emc_debug_min_rate_get, tegra_emc_debug_min_rate_set,"%llu\n" );
@@ -912,7 +912,7 @@ static int tegra_emc_debug_max_rate_set(void *data, u64 rate)return 0 ; } -DEFINE_SIMPLE_ATTRIBUTE (tegra_emc_debug_max_rate_fops, +DEFINE_DEBUGFS_ATTRIBUTE (tegra_emc_debug_max_rate_fops, tegra_emc_debug_max_rate_get, tegra_emc_debug_max_rate_set,"%llu\n" );
Signature · 1 line
1.8.3.1
Quoted 9 lines · Yang Li
Fix the following coccicheck warning:
./drivers/memory/tegra/tegra20-emc.c:915:0-23: WARNING:tegra_emc_debug_max_rate_fopsshould be defined withDEFINE_DEBUGFS_ATTRIBUTE./drivers/memory/tegra/tegra20-emc.c:885:0-23: WARNING:tegra_emc_debug_min_rate_fopsshould be defined withDEFINE_DEBUGFS_ATTRIBUTEReported-by Abaci Robot <[email protected]>
Where is the report? If it is not public, it's not reported-by.
Quoted 5 lines
Signed-off-by Yang Li <[email protected]>--- drivers/memory/tegra/tegra20-emc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
NAK, it's the 6th patch for DEFINE_SIMPLE_ATTRIBUTE in Tegra memory controller drivers. Several folks from alibaba and zte.com.cn keep sending patches replacing only one line each time. Leaving all others not touched.
It's my mistake I actually accepted this, so this ends now.
This is not a warning, this is not a bug. It is rather a coding convention, so sending such one-by-one is unnecessary churn. Pointless patches...
Replace all of such patterns or don't send it.
Best regards,
Krzysztof