patch "staging: r8188eu: fix a memory leak in rtw_wx_read32()" added to staging-linus
Subsystems (2)
This is a note to let you know that I've just added the patch titled
staging: r8188eu: fix a memory leak in rtw_wx_read32()
to my staging git tree which can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
in the staging-linus branch.
The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.)
The patch will hopefully also be merged in Linus's tree for the next -rc kernel release.
If you have any questions about this process, please let me know.
From be4ea8f383551b9dae11b8dfff1f38b3b5436e9a Mon Sep 17 00:00:00 2001
From: Dan Carpenter <[email protected]>
Date: Tue, 9 Nov 2021 14:49:36 +0300
Subject: staging: r8188eu: fix a memory leak in rtw_wx_read32()
Free "ptmp" before returning -EINVAL.
--- drivers/staging/r8188eu/os_dep/ioctl_linux.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)
drivers/staging/r8188eu/os_dep/ioctl_linux.c +7 -1
@@ -1980,6 +1980,7 @@ static int rtw_wx_read32(struct net_device *dev,u32 data32;u32 bytes;u8 *ptmp; +int ret; padapter = (struct adapter *)rtw_netdev_priv (dev); p = &wrqu->data;
@@ -2007,12 +2008,17 @@ static int rtw_wx_read32(struct net_device *dev,break ;default :DBG_88E (KERN_INFO "%s: usage> read [bytes],[address(hex)]\n" , __func__); -return -EINVAL ; + ret = -EINVAL ; + goto err_free_ptmp; }DBG_88E (KERN_INFO "%s: addr = 0x%08X data =%s\n" , __func__, addr, extra);kfree (ptmp);return 0 ; + +err_free_ptmp: +kfree (ptmp); +return ret; } static int rtw_wx_write32(struct net_device *dev,
Signature · 1 line
2.33.1