Skip to contentSkip to conversation

lxc: remove deprecated options in lxc*.service

PATCH Superseded Yu, Mingli 2 participants 8 messages Sep 23, 2020 – Sep 29, 2020 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Yu, Mingli

author
#1 lore raw

PATCH v2 1/1 lxc: remove deprecated options in lxc*.service

From: Mingli Yu <[email protected]>

Remove deprecated options in lxc*.service to silence below warning:

 # systemctl status lxc
 [snip]
 /usr/lib/systemd/system/lxc.service:17: Standard output type syslog is obsolete, automatically updating to journal. Please update your unit file, and consider removing the setting altogether.
 /usr/lib/systemd/system/lxc.service:18: Standard output type syslog is obsolete, automatically updating to journal. Please update your unit file, and consider removing the setting altogether.
---
 ...setting-regarding-the-Standard-Outpu.patch | 35 +++++++++++++++++++
 ...ed-options-in-lxc.service-fixes-3527.patch | 31 ++++++++++++++++
 recipes-containers/lxc/lxc_4.0.2.bb           |  2 ++
 3 files changed, 68 insertions(+)
 create mode 100644 recipes-containers/lxc/files/0001-Remove-obsolete-setting-regarding-the-Standard-Outpu.patch
 create mode 100644 recipes-containers/lxc/files/0001-remove-deprecated-options-in-lxc.service-fixes-3527.patch
recipes-containers/lxc/files/0001-Remove-obsolete-setting-regarding-the-Standard-Outpu.patch new file +35 -0
new file mode 100644
index 0000000..ab97422
@@ -0,0 +1,35 @@
+From a7a92a06a47322dee45664db5c7bfa68b2b95edb Mon Sep 17 00:00:00 2001
+From: Mingli Yu <[email protected]>
+Date: Wed, 23 Sep 2020 07:03:02 +0000
+Subject: [PATCH] Remove obsolete setting regarding the Standard Output
+
+The Standard output type "syslog" is obsolete, causing a warning since systemd
+version 246 [1].
+
+Please consider using "journal" or "journal+console"
+
+[1] https://github.com/systemd/systemd/blob/master/NEWS#L202
+
+Upstream-Status: Submitted [https://github.com/lxc/lxc/pull/3541]
+
+Signed-off-by: Mingli Yu <[email protected]>
+---
+ config/init/systemd/[email protected]         | 2 --
+ 1 files changed, 2 deletions(-)
+
+diff --git a/config/init/systemd/[email protected] b/config/init/systemd/[email protected]
+index a2aa2211f..21ce64aef 100644
+--- a/config/init/systemd/[email protected]
++++ b/config/init/systemd/[email protected]
+@@ -14,8 +14,6 @@ ExecStop=@BINDIR@/lxc-stop -n %i
+ # Environment=BOOTUP=serial
+ # Environment=CONSOLETYPE=serial
+ Delegate=yes
+-StandardOutput=syslog
+-StandardError=syslog
+ 
+ [Install]
+ WantedBy=multi-user.target
+-- 
+2.26.2
+
recipes-containers/lxc/files/0001-remove-deprecated-options-in-lxc.service-fixes-3527.patch new file +31 -0
new file mode 100644
index 0000000..2957680
@@ -0,0 +1,31 @@
+From 0c4cd88d4a19d27ba9b5d2c8fa4d482d78211c35 Mon Sep 17 00:00:00 2001
+From: graysky <[email protected]>
+Date: Fri, 21 Aug 2020 06:33:49 -0400
+Subject: [PATCH] remove deprecated options in lxc.service fixes #3527
+
+Remove deprecated options in lxc.service fixes #3527
+
+Upstream-Status: Backport
+
+Signed-off-by: graysky <[email protected]>
+Signed-off-by: Mingli Yu <[email protected]>
+---
+ config/init/systemd/lxc.service.in | 2 --
+ 1 file changed, 2 deletions(-)
+
+diff --git a/config/init/systemd/lxc.service.in b/config/init/systemd/lxc.service.in
+index e3745dc2d..397a6c4d0 100644
+--- a/config/init/systemd/lxc.service.in
++++ b/config/init/systemd/lxc.service.in
+@@ -14,8 +14,6 @@ ExecReload=@LIBEXECDIR@/lxc/lxc-apparmor-load
+ # Environment=BOOTUP=serial
+ # Environment=CONSOLETYPE=serial
+ Delegate=yes
+-StandardOutput=syslog
+-StandardError=syslog
+ 
+ [Install]
+ WantedBy=multi-user.target
+-- 
+2.26.2
+
recipes-containers/lxc/lxc_4.0.2.bb +2 -0
index d0ead81..ead6bb2 100644
@@ -47,6 +47,8 @@ SRC_URI = "http://linuxcontainers.org/downloads/${BPN}-${PV}.tar.gz \
 	file://templates-use-curl-instead-of-wget.patch \
 	file://tests-our-init-is-not-busybox.patch \
 	file://tests-add-no-validate-when-using-download-template.patch \
+	file://0001-remove-deprecated-options-in-lxc.service-fixes-3527.patch \
+	file://0001-Remove-obsolete-setting-regarding-the-Standard-Outpu.patch \
 	file://dnsmasq.conf \
 	file://lxc-net \
 	"
Signature · 1 line
2.26.2
#2 lore raw
Quoted 8 lines · Mingli

From: Mingli Yu <[email protected]>

Remove deprecated options in lxc*.service to silence below warning:

 # systemctl status lxc
 [snip]
 /usr/lib/systemd/system/lxc.service:17: Standard output type syslog is obsolete, automatically updating to journal. Please update your unit file, and consider removing the setting altogether.
 /usr/lib/systemd/system/lxc.service:18: Standard output type syslog is obsolete, automatically updating to journal. Please update your unit file, and consider removing the setting altogether.

What's the delta to v1 ?

Bruce

Quoted 107 lines
---
 ...setting-regarding-the-Standard-Outpu.patch | 35 +++++++++++++++++++
 ...ed-options-in-lxc.service-fixes-3527.patch | 31 ++++++++++++++++
 recipes-containers/lxc/lxc_4.0.2.bb           |  2 ++
 3 files changed, 68 insertions(+)
 create mode 100644 recipes-containers/lxc/files/0001-Remove-obsolete-setting-regarding-the-Standard-Outpu.patch
 create mode 100644 recipes-containers/lxc/files/0001-remove-deprecated-options-in-lxc.service-fixes-3527.patch
recipes-containers/lxc/files/0001-Remove-obsolete-setting-regarding-the-Standard-Outpu.patch new file +35 -0
new file mode 100644
index 0000000..ab97422
@@ -0,0 +1,35 @@
+From a7a92a06a47322dee45664db5c7bfa68b2b95edb Mon Sep 17 00:00:00 2001
+From: Mingli Yu <[email protected]>
+Date: Wed, 23 Sep 2020 07:03:02 +0000
+Subject: [PATCH] Remove obsolete setting regarding the Standard Output
+
+The Standard output type "syslog" is obsolete, causing a warning since systemd
+version 246 [1].
+
+Please consider using "journal" or "journal+console"
+
+[1] https://github.com/systemd/systemd/blob/master/NEWS#L202
+
+Upstream-Status: Submitted [https://github.com/lxc/lxc/pull/3541]
+
+Signed-off-by: Mingli Yu <[email protected]>
+---
+ config/init/systemd/[email protected]         | 2 --
+ 1 files changed, 2 deletions(-)
+
+diff --git a/config/init/systemd/[email protected] b/config/init/systemd/[email protected]
+index a2aa2211f..21ce64aef 100644
+--- a/config/init/systemd/[email protected]
++++ b/config/init/systemd/[email protected]
+@@ -14,8 +14,6 @@ ExecStop=@BINDIR@/lxc-stop -n %i
+ # Environment=BOOTUP=serial
+ # Environment=CONSOLETYPE=serial
+ Delegate=yes
+-StandardOutput=syslog
+-StandardError=syslog
+
+ [Install]
+ WantedBy=multi-user.target
+--
+2.26.2
+
recipes-containers/lxc/files/0001-remove-deprecated-options-in-lxc.service-fixes-3527.patch new file +31 -0
new file mode 100644
index 0000000..2957680
@@ -0,0 +1,31 @@
+From 0c4cd88d4a19d27ba9b5d2c8fa4d482d78211c35 Mon Sep 17 00:00:00 2001
+From: graysky <[email protected]>
+Date: Fri, 21 Aug 2020 06:33:49 -0400
+Subject: [PATCH] remove deprecated options in lxc.service fixes #3527
+
+Remove deprecated options in lxc.service fixes #3527
+
+Upstream-Status: Backport
+
+Signed-off-by: graysky <[email protected]>
+Signed-off-by: Mingli Yu <[email protected]>
+---
+ config/init/systemd/lxc.service.in | 2 --
+ 1 file changed, 2 deletions(-)
+
+diff --git a/config/init/systemd/lxc.service.in b/config/init/systemd/lxc.service.in
+index e3745dc2d..397a6c4d0 100644
+--- a/config/init/systemd/lxc.service.in
++++ b/config/init/systemd/lxc.service.in
+@@ -14,8 +14,6 @@ ExecReload=@LIBEXECDIR@/lxc/lxc-apparmor-load
+ # Environment=BOOTUP=serial
+ # Environment=CONSOLETYPE=serial
+ Delegate=yes
+-StandardOutput=syslog
+-StandardError=syslog
+
+ [Install]
+ WantedBy=multi-user.target
+--
+2.26.2
+
recipes-containers/lxc/lxc_4.0.2.bb +2 -1
index d0ead81..ead6bb2 100644
@@ -47,6 +47,8 @@ SRC_URI = "http://linuxcontainers.org/downloads/${BPN}-${PV}.tar.gz \
        file://templates-use-curl-instead-of-wget.patch \
        file://tests-our-init-is-not-busybox.patch \
        file://tests-add-no-validate-when-using-download-template.patch \
+       file://0001-remove-deprecated-options-in-lxc.service-fixes-3527.patch \
+       file://0001-Remove-obsolete-setting-regarding-the-Standard-Outpu.patch \
        file://dnsmasq.conf \
        file://lxc-net \
        "
--

2.26.2

Signature · 3 lines
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II
author
#3 lore raw

Hi Bruce,

Quoted 11 lines · Bruce Ashfield
Quoted 8 lines · Mingli

From: Mingli Yu <[email protected]>

Remove deprecated options in lxc*.service to silence below warning:

  # systemctl status lxc
  [snip]
  /usr/lib/systemd/system/lxc.service:17: Standard output type syslog is obsolete, automatically updating to journal. Please update your unit file, and consider removing the setting altogether.
  /usr/lib/systemd/system/lxc.service:18: Standard output type syslog is obsolete, automatically updating to journal. Please update your unit file, and consider removing the setting altogether.

What's the delta to v1 ?

The v1 only have one patch
file://0001-remove-deprecated-options-in-lxc.service-fixes-3527.patch

And the v2 have the below two patch files.
file://0001-remove-deprecated-options-in-lxc.service-fixes-3527.patch file://0001-Remove-obsolete-setting-regarding-the-Standard-Outpu.patch

Thanks,

Quoted 112 lines

Bruce

Quoted 107 lines
---
  ...setting-regarding-the-Standard-Outpu.patch | 35 +++++++++++++++++++
  ...ed-options-in-lxc.service-fixes-3527.patch | 31 ++++++++++++++++
  recipes-containers/lxc/lxc_4.0.2.bb           |  2 ++
  3 files changed, 68 insertions(+)

create mode 100644 recipes-containers/lxc/files/0001-Remove-obsolete-setting-regarding-the-Standard-Outpu.patch create mode 100644 recipes-containers/lxc/files/0001-remove-deprecated-options-in-lxc.service-fixes-3527.patch

recipes-containers/lxc/files/0001-Remove-obsolete-setting-regarding-the-Standard-Outpu.patch new file +35 -0
new file mode 100644
index 0000000..ab97422
@@ -0,0 +1,35 @@
+From a7a92a06a47322dee45664db5c7bfa68b2b95edb Mon Sep 17 00:00:00 2001
+From: Mingli Yu <[email protected]>
+Date: Wed, 23 Sep 2020 07:03:02 +0000
+Subject: [PATCH] Remove obsolete setting regarding the Standard Output
+
+The Standard output type "syslog" is obsolete, causing a warning since systemd
+version 246 [1].
+
+Please consider using "journal" or "journal+console"
+
+[1] https://github.com/systemd/systemd/blob/master/NEWS#L202
+
+Upstream-Status: Submitted [https://github.com/lxc/lxc/pull/3541]
+
+Signed-off-by: Mingli Yu <[email protected]>
+---
+ config/init/systemd/[email protected]         | 2 --
+ 1 files changed, 2 deletions(-)
+
+diff --git a/config/init/systemd/[email protected] b/config/init/systemd/[email protected]
+index a2aa2211f..21ce64aef 100644
+--- a/config/init/systemd/[email protected]
++++ b/config/init/systemd/[email protected]
+@@ -14,8 +14,6 @@ ExecStop=@BINDIR@/lxc-stop -n %i
+ # Environment=BOOTUP=serial
+ # Environment=CONSOLETYPE=serial
+ Delegate=yes
+-StandardOutput=syslog
+-StandardError=syslog
+
+ [Install]
+ WantedBy=multi-user.target
+--
+2.26.2
+
recipes-containers/lxc/files/0001-remove-deprecated-options-in-lxc.service-fixes-3527.patch new file +31 -0
new file mode 100644
index 0000000..2957680
@@ -0,0 +1,31 @@
+From 0c4cd88d4a19d27ba9b5d2c8fa4d482d78211c35 Mon Sep 17 00:00:00 2001
+From: graysky <[email protected]>
+Date: Fri, 21 Aug 2020 06:33:49 -0400
+Subject: [PATCH] remove deprecated options in lxc.service fixes #3527
+
+Remove deprecated options in lxc.service fixes #3527
+
+Upstream-Status: Backport
+
+Signed-off-by: graysky <[email protected]>
+Signed-off-by: Mingli Yu <[email protected]>
+---
+ config/init/systemd/lxc.service.in | 2 --
+ 1 file changed, 2 deletions(-)
+
+diff --git a/config/init/systemd/lxc.service.in b/config/init/systemd/lxc.service.in
+index e3745dc2d..397a6c4d0 100644
+--- a/config/init/systemd/lxc.service.in
++++ b/config/init/systemd/lxc.service.in
+@@ -14,8 +14,6 @@ ExecReload=@LIBEXECDIR@/lxc/lxc-apparmor-load
+ # Environment=BOOTUP=serial
+ # Environment=CONSOLETYPE=serial
+ Delegate=yes
+-StandardOutput=syslog
+-StandardError=syslog
+
+ [Install]
+ WantedBy=multi-user.target
+--
+2.26.2
+
recipes-containers/lxc/lxc_4.0.2.bb +2 -1
index d0ead81..ead6bb2 100644
@@ -47,6 +47,8 @@ SRC_URI = "http://linuxcontainers.org/downloads/${BPN}-${PV}.tar.gz \
         file://templates-use-curl-instead-of-wget.patch \
         file://tests-our-init-is-not-busybox.patch \
         file://tests-add-no-validate-when-using-download-template.patch \
+       file://0001-remove-deprecated-options-in-lxc.service-fixes-3527.patch \
+       file://0001-Remove-obsolete-setting-regarding-the-Standard-Outpu.patch \
         file://dnsmasq.conf \
         file://lxc-net \
         "
--

2.26.2

#4 lore raw
Quoted 16 lines · Mingli

Hi Bruce,

Quoted 11 lines · Bruce Ashfield
Quoted 8 lines · Mingli

From: Mingli Yu <[email protected]>

Remove deprecated options in lxc*.service to silence below warning:

  # systemctl status lxc
  [snip]
  /usr/lib/systemd/system/lxc.service:17: Standard output type syslog is obsolete, automatically updating to journal. Please update your unit file, and consider removing the setting altogether.
  /usr/lib/systemd/system/lxc.service:18: Standard output type syslog is obsolete, automatically updating to journal. Please update your unit file, and consider removing the setting altogether.

What's the delta to v1 ?

This should be logged in the temporary section of the patch, that way I can track what is changing through a series.

That being said, I went to apply this patch, and it isn't against the lxc version that we have in master.

Can you update and resubmit ?

Bruce

Quoted 122 lines

The v1 only have one patch
file://0001-remove-deprecated-options-in-lxc.service-fixes-3527.patch

And the v2 have the below two patch files.
file://0001-remove-deprecated-options-in-lxc.service-fixes-3527.patch file://0001-Remove-obsolete-setting-regarding-the-Standard-Outpu.patch

Thanks,

Quoted 112 lines

Bruce

Quoted 107 lines
---
  ...setting-regarding-the-Standard-Outpu.patch | 35 +++++++++++++++++++
  ...ed-options-in-lxc.service-fixes-3527.patch | 31 ++++++++++++++++
  recipes-containers/lxc/lxc_4.0.2.bb           |  2 ++
  3 files changed, 68 insertions(+)

create mode 100644 recipes-containers/lxc/files/0001-Remove-obsolete-setting-regarding-the-Standard-Outpu.patch create mode 100644 recipes-containers/lxc/files/0001-remove-deprecated-options-in-lxc.service-fixes-3527.patch

recipes-containers/lxc/files/0001-Remove-obsolete-setting-regarding-the-Standard-Outpu.patch new file +35 -0
new file mode 100644
index 0000000..ab97422
@@ -0,0 +1,35 @@
+From a7a92a06a47322dee45664db5c7bfa68b2b95edb Mon Sep 17 00:00:00 2001
+From: Mingli Yu <[email protected]>
+Date: Wed, 23 Sep 2020 07:03:02 +0000
+Subject: [PATCH] Remove obsolete setting regarding the Standard Output
+
+The Standard output type "syslog" is obsolete, causing a warning since systemd
+version 246 [1].
+
+Please consider using "journal" or "journal+console"
+
+[1] https://github.com/systemd/systemd/blob/master/NEWS#L202
+
+Upstream-Status: Submitted [https://github.com/lxc/lxc/pull/3541]
+
+Signed-off-by: Mingli Yu <[email protected]>
+---
+ config/init/systemd/[email protected]         | 2 --
+ 1 files changed, 2 deletions(-)
+
+diff --git a/config/init/systemd/[email protected] b/config/init/systemd/[email protected]
+index a2aa2211f..21ce64aef 100644
+--- a/config/init/systemd/[email protected]
++++ b/config/init/systemd/[email protected]
+@@ -14,8 +14,6 @@ ExecStop=@BINDIR@/lxc-stop -n %i
+ # Environment=BOOTUP=serial
+ # Environment=CONSOLETYPE=serial
+ Delegate=yes
+-StandardOutput=syslog
+-StandardError=syslog
+
+ [Install]
+ WantedBy=multi-user.target
+--
+2.26.2
+
recipes-containers/lxc/files/0001-remove-deprecated-options-in-lxc.service-fixes-3527.patch new file +31 -0
new file mode 100644
index 0000000..2957680
@@ -0,0 +1,31 @@
+From 0c4cd88d4a19d27ba9b5d2c8fa4d482d78211c35 Mon Sep 17 00:00:00 2001
+From: graysky <[email protected]>
+Date: Fri, 21 Aug 2020 06:33:49 -0400
+Subject: [PATCH] remove deprecated options in lxc.service fixes #3527
+
+Remove deprecated options in lxc.service fixes #3527
+
+Upstream-Status: Backport
+
+Signed-off-by: graysky <[email protected]>
+Signed-off-by: Mingli Yu <[email protected]>
+---
+ config/init/systemd/lxc.service.in | 2 --
+ 1 file changed, 2 deletions(-)
+
+diff --git a/config/init/systemd/lxc.service.in b/config/init/systemd/lxc.service.in
+index e3745dc2d..397a6c4d0 100644
+--- a/config/init/systemd/lxc.service.in
++++ b/config/init/systemd/lxc.service.in
+@@ -14,8 +14,6 @@ ExecReload=@LIBEXECDIR@/lxc/lxc-apparmor-load
+ # Environment=BOOTUP=serial
+ # Environment=CONSOLETYPE=serial
+ Delegate=yes
+-StandardOutput=syslog
+-StandardError=syslog
+
+ [Install]
+ WantedBy=multi-user.target
+--
+2.26.2
+
recipes-containers/lxc/lxc_4.0.2.bb +2 -1
index d0ead81..ead6bb2 100644
@@ -47,6 +47,8 @@ SRC_URI = "http://linuxcontainers.org/downloads/${BPN}-${PV}.tar.gz \
         file://templates-use-curl-instead-of-wget.patch \
         file://tests-our-init-is-not-busybox.patch \
         file://tests-add-no-validate-when-using-download-template.patch \
+       file://0001-remove-deprecated-options-in-lxc.service-fixes-3527.patch \
+       file://0001-Remove-obsolete-setting-regarding-the-Standard-Outpu.patch \
         file://dnsmasq.conf \
         file://lxc-net \
         "
--

2.26.2

Signature · 3 lines
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II
author
#5 lore raw

Hi Bruce,

Quoted 18 lines · Bruce Ashfield
Quoted 16 lines · Mingli

Hi Bruce,

Quoted 11 lines · Bruce Ashfield
Quoted 8 lines · Mingli

From: Mingli Yu <[email protected]>

Remove deprecated options in lxc*.service to silence below warning:

   # systemctl status lxc
   [snip]
   /usr/lib/systemd/system/lxc.service:17: Standard output type syslog is obsolete, automatically updating to journal. Please update your unit file, and consider removing the setting altogether.
   /usr/lib/systemd/system/lxc.service:18: Standard output type syslog is obsolete, automatically updating to journal. Please update your unit file, and consider removing the setting altogether.

What's the delta to v1 ?

Quoted 7 lines

This should be logged in the temporary section of the patch, that way I can track what is changing through a series.

That being said, I went to apply this patch, and it isn't against the lxc version that we have in master.

Can you update and resubmit ?

No problem, I can update the patch if need.

But the patch is created against the latest code on master for lxc after I checked. I don't quite understand what problem you encounter when merge this patch.

Thanks,

Quoted 128 lines

Bruce

Quoted 122 lines

The v1 only have one patch

    file://0001-remove-deprecated-options-in-lxc.service-fixes-3527.patch

And the v2 have the below two patch files.
file://0001-remove-deprecated-options-in-lxc.service-fixes-3527.patch file://0001-Remove-obsolete-setting-regarding-the-Standard-Outpu.patch

Thanks,

Quoted 112 lines

Bruce

Quoted 107 lines
---
   ...setting-regarding-the-Standard-Outpu.patch | 35 +++++++++++++++++++
   ...ed-options-in-lxc.service-fixes-3527.patch | 31 ++++++++++++++++
   recipes-containers/lxc/lxc_4.0.2.bb           |  2 ++
   3 files changed, 68 insertions(+)

create mode 100644 recipes-containers/lxc/files/0001-Remove-obsolete-setting-regarding-the-Standard-Outpu.patch create mode 100644 recipes-containers/lxc/files/0001-remove-deprecated-options-in-lxc.service-fixes-3527.patch

recipes-containers/lxc/files/0001-Remove-obsolete-setting-regarding-the-Standard-Outpu.patch new file +35 -0
new file mode 100644
index 0000000..ab97422
@@ -0,0 +1,35 @@
+From a7a92a06a47322dee45664db5c7bfa68b2b95edb Mon Sep 17 00:00:00 2001
+From: Mingli Yu <[email protected]>
+Date: Wed, 23 Sep 2020 07:03:02 +0000
+Subject: [PATCH] Remove obsolete setting regarding the Standard Output
+
+The Standard output type "syslog" is obsolete, causing a warning since systemd
+version 246 [1].
+
+Please consider using "journal" or "journal+console"
+
+[1] https://github.com/systemd/systemd/blob/master/NEWS#L202
+
+Upstream-Status: Submitted [https://github.com/lxc/lxc/pull/3541]
+
+Signed-off-by: Mingli Yu <[email protected]>
+---
+ config/init/systemd/[email protected]         | 2 --
+ 1 files changed, 2 deletions(-)
+
+diff --git a/config/init/systemd/[email protected] b/config/init/systemd/[email protected]
+index a2aa2211f..21ce64aef 100644
+--- a/config/init/systemd/[email protected]
++++ b/config/init/systemd/[email protected]
+@@ -14,8 +14,6 @@ ExecStop=@BINDIR@/lxc-stop -n %i
+ # Environment=BOOTUP=serial
+ # Environment=CONSOLETYPE=serial
+ Delegate=yes
+-StandardOutput=syslog
+-StandardError=syslog
+
+ [Install]
+ WantedBy=multi-user.target
+--
+2.26.2
+
recipes-containers/lxc/files/0001-remove-deprecated-options-in-lxc.service-fixes-3527.patch new file +31 -0
new file mode 100644
index 0000000..2957680
@@ -0,0 +1,31 @@
+From 0c4cd88d4a19d27ba9b5d2c8fa4d482d78211c35 Mon Sep 17 00:00:00 2001
+From: graysky <[email protected]>
+Date: Fri, 21 Aug 2020 06:33:49 -0400
+Subject: [PATCH] remove deprecated options in lxc.service fixes #3527
+
+Remove deprecated options in lxc.service fixes #3527
+
+Upstream-Status: Backport
+
+Signed-off-by: graysky <[email protected]>
+Signed-off-by: Mingli Yu <[email protected]>
+---
+ config/init/systemd/lxc.service.in | 2 --
+ 1 file changed, 2 deletions(-)
+
+diff --git a/config/init/systemd/lxc.service.in b/config/init/systemd/lxc.service.in
+index e3745dc2d..397a6c4d0 100644
+--- a/config/init/systemd/lxc.service.in
++++ b/config/init/systemd/lxc.service.in
+@@ -14,8 +14,6 @@ ExecReload=@LIBEXECDIR@/lxc/lxc-apparmor-load
+ # Environment=BOOTUP=serial
+ # Environment=CONSOLETYPE=serial
+ Delegate=yes
+-StandardOutput=syslog
+-StandardError=syslog
+
+ [Install]
+ WantedBy=multi-user.target
+--
+2.26.2
+
recipes-containers/lxc/lxc_4.0.2.bb +2 -1
index d0ead81..ead6bb2 100644
@@ -47,6 +47,8 @@ SRC_URI = "http://linuxcontainers.org/downloads/${BPN}-${PV}.tar.gz \
          file://templates-use-curl-instead-of-wget.patch \
          file://tests-our-init-is-not-busybox.patch \
          file://tests-add-no-validate-when-using-download-template.patch \
+       file://0001-remove-deprecated-options-in-lxc.service-fixes-3527.patch \
+       file://0001-Remove-obsolete-setting-regarding-the-Standard-Outpu.patch \
          file://dnsmasq.conf \
          file://lxc-net \
          "
--

2.26.2

#6 lore raw
Quoted 28 lines · Mingli

Hi Bruce,

Quoted 24 lines · Bruce Ashfield
Quoted 16 lines · Mingli

Hi Bruce,

Quoted 11 lines · Bruce Ashfield
Quoted 8 lines · Mingli

From: Mingli Yu <[email protected]>

Remove deprecated options in lxc*.service to silence below warning:

   # systemctl status lxc
   [snip]
   /usr/lib/systemd/system/lxc.service:17: Standard output type syslog is obsolete, automatically updating to journal. Please update your unit file, and consider removing the setting altogether.
   /usr/lib/systemd/system/lxc.service:18: Standard output type syslog is obsolete, automatically updating to journal. Please update your unit file, and consider removing the setting altogether.

What's the delta to v1 ?

This should be logged in the temporary section of the patch, that way I can track what is changing through a series.

That being said, I went to apply this patch, and it isn't against the lxc version that we have in master.

Quoted 7 lines
Quoted 1 line

Can you update and resubmit ?

No problem, I can update the patch if need.

But the patch is created against the latest code on master for lxc after I checked. I don't quite understand what problem you encounter when merge this patch.

In v2, I see:

(quoted diff) +0 -0

b/recipes-containers/lxc/lxc_4.0.2.bb
index d0ead81..ead6bb2 100644
--- a/recipes-containers/lxc/lxc_4.0.2.bb
+++ b/recipes-containers/lxc/lxc_4.0.2.bb

Are you not seeing lxc_4.0.4.bb in your master checkout ?

https://git.yoctoproject.org/cgit/cgit.cgi/meta-virtualization/tree/recipes-containers/lxc/lxc_4.0.4.bb

Bruce

Quoted 131 lines

Thanks,

Quoted 128 lines

Bruce

Quoted 122 lines

The v1 only have one patch

    file://0001-remove-deprecated-options-in-lxc.service-fixes-3527.patch

And the v2 have the below two patch files.
file://0001-remove-deprecated-options-in-lxc.service-fixes-3527.patch file://0001-Remove-obsolete-setting-regarding-the-Standard-Outpu.patch

Thanks,

Quoted 112 lines

Bruce

Quoted 107 lines
---
   ...setting-regarding-the-Standard-Outpu.patch | 35 +++++++++++++++++++
   ...ed-options-in-lxc.service-fixes-3527.patch | 31 ++++++++++++++++
   recipes-containers/lxc/lxc_4.0.2.bb           |  2 ++
   3 files changed, 68 insertions(+)

create mode 100644 recipes-containers/lxc/files/0001-Remove-obsolete-setting-regarding-the-Standard-Outpu.patch create mode 100644 recipes-containers/lxc/files/0001-remove-deprecated-options-in-lxc.service-fixes-3527.patch

recipes-containers/lxc/files/0001-Remove-obsolete-setting-regarding-the-Standard-Outpu.patch new file +35 -0
new file mode 100644
index 0000000..ab97422
@@ -0,0 +1,35 @@
+From a7a92a06a47322dee45664db5c7bfa68b2b95edb Mon Sep 17 00:00:00 2001
+From: Mingli Yu <[email protected]>
+Date: Wed, 23 Sep 2020 07:03:02 +0000
+Subject: [PATCH] Remove obsolete setting regarding the Standard Output
+
+The Standard output type "syslog" is obsolete, causing a warning since systemd
+version 246 [1].
+
+Please consider using "journal" or "journal+console"
+
+[1] https://github.com/systemd/systemd/blob/master/NEWS#L202
+
+Upstream-Status: Submitted [https://github.com/lxc/lxc/pull/3541]
+
+Signed-off-by: Mingli Yu <[email protected]>
+---
+ config/init/systemd/[email protected]         | 2 --
+ 1 files changed, 2 deletions(-)
+
+diff --git a/config/init/systemd/[email protected] b/config/init/systemd/[email protected]
+index a2aa2211f..21ce64aef 100644
+--- a/config/init/systemd/[email protected]
++++ b/config/init/systemd/[email protected]
+@@ -14,8 +14,6 @@ ExecStop=@BINDIR@/lxc-stop -n %i
+ # Environment=BOOTUP=serial
+ # Environment=CONSOLETYPE=serial
+ Delegate=yes
+-StandardOutput=syslog
+-StandardError=syslog
+
+ [Install]
+ WantedBy=multi-user.target
+--
+2.26.2
+
recipes-containers/lxc/files/0001-remove-deprecated-options-in-lxc.service-fixes-3527.patch new file +31 -0
new file mode 100644
index 0000000..2957680
@@ -0,0 +1,31 @@
+From 0c4cd88d4a19d27ba9b5d2c8fa4d482d78211c35 Mon Sep 17 00:00:00 2001
+From: graysky <[email protected]>
+Date: Fri, 21 Aug 2020 06:33:49 -0400
+Subject: [PATCH] remove deprecated options in lxc.service fixes #3527
+
+Remove deprecated options in lxc.service fixes #3527
+
+Upstream-Status: Backport
+
+Signed-off-by: graysky <[email protected]>
+Signed-off-by: Mingli Yu <[email protected]>
+---
+ config/init/systemd/lxc.service.in | 2 --
+ 1 file changed, 2 deletions(-)
+
+diff --git a/config/init/systemd/lxc.service.in b/config/init/systemd/lxc.service.in
+index e3745dc2d..397a6c4d0 100644
+--- a/config/init/systemd/lxc.service.in
++++ b/config/init/systemd/lxc.service.in
+@@ -14,8 +14,6 @@ ExecReload=@LIBEXECDIR@/lxc/lxc-apparmor-load
+ # Environment=BOOTUP=serial
+ # Environment=CONSOLETYPE=serial
+ Delegate=yes
+-StandardOutput=syslog
+-StandardError=syslog
+
+ [Install]
+ WantedBy=multi-user.target
+--
+2.26.2
+
recipes-containers/lxc/lxc_4.0.2.bb +2 -1
index d0ead81..ead6bb2 100644
@@ -47,6 +47,8 @@ SRC_URI = "http://linuxcontainers.org/downloads/${BPN}-${PV}.tar.gz \
          file://templates-use-curl-instead-of-wget.patch \
          file://tests-our-init-is-not-busybox.patch \
          file://tests-add-no-validate-when-using-download-template.patch \
+       file://0001-remove-deprecated-options-in-lxc.service-fixes-3527.patch \
+       file://0001-Remove-obsolete-setting-regarding-the-Standard-Outpu.patch \
          file://dnsmasq.conf \
          file://lxc-net \
          "
--

2.26.2

Signature · 3 lines
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II
author
#7 lore raw
Quoted 45 lines · Bruce Ashfield
Quoted 28 lines · Mingli

Hi Bruce,

Quoted 24 lines · Bruce Ashfield
Quoted 16 lines · Mingli

Hi Bruce,

Quoted 11 lines · Bruce Ashfield
Quoted 8 lines · Mingli

From: Mingli Yu <[email protected]>

Remove deprecated options in lxc*.service to silence below warning:

    # systemctl status lxc
    [snip]
    /usr/lib/systemd/system/lxc.service:17: Standard output type syslog is obsolete, automatically updating to journal. Please update your unit file, and consider removing the setting altogether.
    /usr/lib/systemd/system/lxc.service:18: Standard output type syslog is obsolete, automatically updating to journal. Please update your unit file, and consider removing the setting altogether.

What's the delta to v1 ?

This should be logged in the temporary section of the patch, that way I can track what is changing through a series.

That being said, I went to apply this patch, and it isn't against the lxc version that we have in master.

Quoted 7 lines
Quoted 1 line

Can you update and resubmit ?

No problem, I can update the patch if need.

But the patch is created against the latest code on master for lxc after I checked. I don't quite understand what problem you encounter when merge this patch.

In v2, I see:

recipes-containers/lxc/lxc_4.0.2.bb +0 -0
index d0ead81..ead6bb2 100644
Quoted 3 lines

Are you not seeing lxc_4.0.4.bb in your master checkout ?

https://git.yoctoproject.org/cgit/cgit.cgi/meta-virtualization/tree/recipes-containers/lxc/lxc_4.0.4.bb

Hi Bruce,

Thanks for your pointing, v3 is incoming.

Thanks,

Quoted 137 lines

Bruce

Quoted 131 lines

Thanks,

Quoted 128 lines

Bruce

Quoted 122 lines

The v1 only have one patch

     file://0001-remove-deprecated-options-in-lxc.service-fixes-3527.patch

And the v2 have the below two patch files.

    file://0001-remove-deprecated-options-in-lxc.service-fixes-3527.patch
    file://0001-Remove-obsolete-setting-regarding-the-Standard-Outpu.patch

Thanks,

Quoted 112 lines

Bruce

Quoted 107 lines
---
    ...setting-regarding-the-Standard-Outpu.patch | 35 +++++++++++++++++++
    ...ed-options-in-lxc.service-fixes-3527.patch | 31 ++++++++++++++++
    recipes-containers/lxc/lxc_4.0.2.bb           |  2 ++
    3 files changed, 68 insertions(+)

create mode 100644 recipes-containers/lxc/files/0001-Remove-obsolete-setting-regarding-the-Standard-Outpu.patch create mode 100644 recipes-containers/lxc/files/0001-remove-deprecated-options-in-lxc.service-fixes-3527.patch

recipes-containers/lxc/files/0001-Remove-obsolete-setting-regarding-the-Standard-Outpu.patch new file +35 -0
new file mode 100644
index 0000000..ab97422
@@ -0,0 +1,35 @@
+From a7a92a06a47322dee45664db5c7bfa68b2b95edb Mon Sep 17 00:00:00 2001
+From: Mingli Yu <[email protected]>
+Date: Wed, 23 Sep 2020 07:03:02 +0000
+Subject: [PATCH] Remove obsolete setting regarding the Standard Output
+
+The Standard output type "syslog" is obsolete, causing a warning since systemd
+version 246 [1].
+
+Please consider using "journal" or "journal+console"
+
+[1] https://github.com/systemd/systemd/blob/master/NEWS#L202
+
+Upstream-Status: Submitted [https://github.com/lxc/lxc/pull/3541]
+
+Signed-off-by: Mingli Yu <[email protected]>
+---
+ config/init/systemd/[email protected]         | 2 --
+ 1 files changed, 2 deletions(-)
+
+diff --git a/config/init/systemd/[email protected] b/config/init/systemd/[email protected]
+index a2aa2211f..21ce64aef 100644
+--- a/config/init/systemd/[email protected]
++++ b/config/init/systemd/[email protected]
+@@ -14,8 +14,6 @@ ExecStop=@BINDIR@/lxc-stop -n %i
+ # Environment=BOOTUP=serial
+ # Environment=CONSOLETYPE=serial
+ Delegate=yes
+-StandardOutput=syslog
+-StandardError=syslog
+
+ [Install]
+ WantedBy=multi-user.target
+--
+2.26.2
+
recipes-containers/lxc/files/0001-remove-deprecated-options-in-lxc.service-fixes-3527.patch new file +31 -0
new file mode 100644
index 0000000..2957680
@@ -0,0 +1,31 @@
+From 0c4cd88d4a19d27ba9b5d2c8fa4d482d78211c35 Mon Sep 17 00:00:00 2001
+From: graysky <[email protected]>
+Date: Fri, 21 Aug 2020 06:33:49 -0400
+Subject: [PATCH] remove deprecated options in lxc.service fixes #3527
+
+Remove deprecated options in lxc.service fixes #3527
+
+Upstream-Status: Backport
+
+Signed-off-by: graysky <[email protected]>
+Signed-off-by: Mingli Yu <[email protected]>
+---
+ config/init/systemd/lxc.service.in | 2 --
+ 1 file changed, 2 deletions(-)
+
+diff --git a/config/init/systemd/lxc.service.in b/config/init/systemd/lxc.service.in
+index e3745dc2d..397a6c4d0 100644
+--- a/config/init/systemd/lxc.service.in
++++ b/config/init/systemd/lxc.service.in
+@@ -14,8 +14,6 @@ ExecReload=@LIBEXECDIR@/lxc/lxc-apparmor-load
+ # Environment=BOOTUP=serial
+ # Environment=CONSOLETYPE=serial
+ Delegate=yes
+-StandardOutput=syslog
+-StandardError=syslog
+
+ [Install]
+ WantedBy=multi-user.target
+--
+2.26.2
+
recipes-containers/lxc/lxc_4.0.2.bb +2 -1
index d0ead81..ead6bb2 100644
@@ -47,6 +47,8 @@ SRC_URI = "http://linuxcontainers.org/downloads/${BPN}-${PV}.tar.gz \
           file://templates-use-curl-instead-of-wget.patch \
           file://tests-our-init-is-not-busybox.patch \
           file://tests-add-no-validate-when-using-download-template.patch \
+       file://0001-remove-deprecated-options-in-lxc.service-fixes-3527.patch \
+       file://0001-Remove-obsolete-setting-regarding-the-Standard-Outpu.patch \
           file://dnsmasq.conf \
           file://lxc-net \
           "
--

2.26.2

author
#8 lore raw

PATCH v3 1/1 lxc: remove deprecated options in lxc*.service

In reply to Bruce Ashfield

From: Mingli Yu <[email protected]>

Remove deprecated options in lxc*.service to silence below warning:

 # systemctl status lxc
 [snip]
 /usr/lib/systemd/system/lxc.service:17: Standard output type syslog is obsolete, automatically updating to journal. Please update your unit file, and consider removing the setting altogether.
 /usr/lib/systemd/system/lxc.service:18: Standard output type syslog is obsolete, automatically updating to journal. Please update your unit file, and consider removing the setting altogether.
---
 ...setting-regarding-the-Standard-Outpu.patch | 35 +++++++++++++++++++
 ...ed-options-in-lxc.service-fixes-3527.patch | 31 ++++++++++++++++
 recipes-containers/lxc/lxc_4.0.4.bb           |  2 ++
 3 files changed, 68 insertions(+)
 create mode 100644 recipes-containers/lxc/files/0001-Remove-obsolete-setting-regarding-the-Standard-Outpu.patch
 create mode 100644 recipes-containers/lxc/files/0001-remove-deprecated-options-in-lxc.service-fixes-3527.patch
recipes-containers/lxc/files/0001-Remove-obsolete-setting-regarding-the-Standard-Outpu.patch new file +35 -0
new file mode 100644
index 0000000..ab97422
@@ -0,0 +1,35 @@
+From a7a92a06a47322dee45664db5c7bfa68b2b95edb Mon Sep 17 00:00:00 2001
+From: Mingli Yu <[email protected]>
+Date: Wed, 23 Sep 2020 07:03:02 +0000
+Subject: [PATCH] Remove obsolete setting regarding the Standard Output
+
+The Standard output type "syslog" is obsolete, causing a warning since systemd
+version 246 [1].
+
+Please consider using "journal" or "journal+console"
+
+[1] https://github.com/systemd/systemd/blob/master/NEWS#L202
+
+Upstream-Status: Submitted [https://github.com/lxc/lxc/pull/3541]
+
+Signed-off-by: Mingli Yu <[email protected]>
+---
+ config/init/systemd/[email protected]         | 2 --
+ 1 files changed, 2 deletions(-)
+
+diff --git a/config/init/systemd/[email protected] b/config/init/systemd/[email protected]
+index a2aa2211f..21ce64aef 100644
+--- a/config/init/systemd/[email protected]
++++ b/config/init/systemd/[email protected]
+@@ -14,8 +14,6 @@ ExecStop=@BINDIR@/lxc-stop -n %i
+ # Environment=BOOTUP=serial
+ # Environment=CONSOLETYPE=serial
+ Delegate=yes
+-StandardOutput=syslog
+-StandardError=syslog
+ 
+ [Install]
+ WantedBy=multi-user.target
+-- 
+2.26.2
+
recipes-containers/lxc/files/0001-remove-deprecated-options-in-lxc.service-fixes-3527.patch new file +31 -0
new file mode 100644
index 0000000..2957680
@@ -0,0 +1,31 @@
+From 0c4cd88d4a19d27ba9b5d2c8fa4d482d78211c35 Mon Sep 17 00:00:00 2001
+From: graysky <[email protected]>
+Date: Fri, 21 Aug 2020 06:33:49 -0400
+Subject: [PATCH] remove deprecated options in lxc.service fixes #3527
+
+Remove deprecated options in lxc.service fixes #3527
+
+Upstream-Status: Backport
+
+Signed-off-by: graysky <[email protected]>
+Signed-off-by: Mingli Yu <[email protected]>
+---
+ config/init/systemd/lxc.service.in | 2 --
+ 1 file changed, 2 deletions(-)
+
+diff --git a/config/init/systemd/lxc.service.in b/config/init/systemd/lxc.service.in
+index e3745dc2d..397a6c4d0 100644
+--- a/config/init/systemd/lxc.service.in
++++ b/config/init/systemd/lxc.service.in
+@@ -14,8 +14,6 @@ ExecReload=@LIBEXECDIR@/lxc/lxc-apparmor-load
+ # Environment=BOOTUP=serial
+ # Environment=CONSOLETYPE=serial
+ Delegate=yes
+-StandardOutput=syslog
+-StandardError=syslog
+ 
+ [Install]
+ WantedBy=multi-user.target
+-- 
+2.26.2
+
recipes-containers/lxc/lxc_4.0.4.bb +2 -0
index f526ab9..4ef5fc0 100644
@@ -47,6 +47,8 @@ SRC_URI = "http://linuxcontainers.org/downloads/${BPN}-${PV}.tar.gz \
 	file://templates-use-curl-instead-of-wget.patch \
 	file://tests-our-init-is-not-busybox.patch \
 	file://tests-add-no-validate-when-using-download-template.patch \
+	file://0001-remove-deprecated-options-in-lxc.service-fixes-3527.patch \
+	file://0001-Remove-obsolete-setting-regarding-the-Standard-Outpu.patch \
 	file://dnsmasq.conf \
 	file://lxc-net \
 	"
Signature · 1 line
2.26.2