hw/vhost-user-blk: turn on VIRTIO_BLK_F_SIZE_MAX feature for virtio blk device
PATCH 1/1 hw/vhost-user-blk: turn on VIRTIO_BLK_F_SIZE_MAX feature for virtio blk device
Turn on pre-defined feature VIRTIO_BLK_F_SIZE_MAX virtio blk device to avoid guest DMA request size is too large to exceed hardware spec.
--- hw/block/vhost-user-blk.c | 1 + 1 file changed, 1 insertion(+)
hw/block/vhost-user-blk.c +1 -0
@@ -252,6 +252,7 @@ static uint64_t vhost_user_blk_get_features(VirtIODevice *vdev,VHostUserBlk *s =VHOST_USER_BLK (vdev);/* Turn on pre-defined features */ +virtio_add_feature (&features,VIRTIO_BLK_F_SIZE_MAX );virtio_add_feature (&features,VIRTIO_BLK_F_SEG_MAX );virtio_add_feature (&features,VIRTIO_BLK_F_GEOMETRY );virtio_add_feature (&features,VIRTIO_BLK_F_TOPOLOGY );
Signature · 1 line
1.8.3.1
Just a commit message nit. Otherwise I'm happy with this. OFC should not be queued for 6.2.
Quoted 2 lines · Andy Pei
Turn on pre-defined feature
VIRTIO_BLK_F_SIZE_MAXvirtio blk device to avoid guest DMA request size is too large to exceed hardware spec.
Grammar here. Should be something like "...DMA request sizes which are to large for the hardware spec".
Quoted 2 lines
Signed-off-by Andy Pei <[email protected]>
Quoted 19 lines
--- hw/block/vhost-user-blk.c | 1 + 1 file changed, 1 insertion(+)hw/block/vhost-user-blk.c +1
-0@@ -252,6 +252,7 @@ static uint64_t vhost_user_blk_get_features(VirtIODevice *vdev,VHostUserBlk *s =VHOST_USER_BLK (vdev);/* Turn on pre-defined features */ +virtio_add_feature (&features,VIRTIO_BLK_F_SIZE_MAX );virtio_add_feature (&features,VIRTIO_BLK_F_SEG_MAX );virtio_add_feature (&features,VIRTIO_BLK_F_GEOMETRY );virtio_add_feature (&features,VIRTIO_BLK_F_TOPOLOGY );Signature · 1 line
1.8.3.1
Pei, Andy
Acked-by Raphael NorwitzHi Raphael,
Thanks for your reply.
I will fix the grammar mistake in V2.
-----Original Message-----
From: Raphael Norwitz <[email protected]>
Sent: Tuesday, November 30, 2021 5:58 AM
To: Pei, Andy <[email protected]>
Cc: [email protected]; [email protected]; Liu, Changpeng <[email protected]>; Raphael Norwitz <[email protected]>; [email protected]; [email protected]; [email protected]
Subject: Re: [PATCH] hw/vhost-user-blk: turn on VIRTIO_BLK_F_SIZE_MAX feature for virtio blk device
Just a commit message nit. Otherwise I'm happy with this. OFC should not be queued for 6.2.
Quoted 2 lines · Andy Pei
Turn on pre-defined feature
VIRTIO_BLK_F_SIZE_MAXvirtio blk device to avoid guest DMA request size is too large to exceed hardware spec.
Grammar here. Should be something like "...DMA request sizes which are to large for the hardware spec".
Quoted 2 lines
Signed-off-by Andy Pei <[email protected]>
Quoted 19 lines
--- hw/block/vhost-user-blk.c | 1 + 1 file changed, 1 insertion(+)hw/block/vhost-user-blk.c +1
-1@@ -252,6 +252,7 @@ static uint64_t vhost_user_blk_get_features(VirtIODevice *vdev,VHostUserBlk *s =VHOST_USER_BLK (vdev);/* Turn on pre-defined features */ +virtio_add_feature (&features,VIRTIO_BLK_F_SIZE_MAX );virtio_add_feature (&features,VIRTIO_BLK_F_SEG_MAX );virtio_add_feature (&features,VIRTIO_BLK_F_GEOMETRY );virtio_add_feature (&features,VIRTIO_BLK_F_TOPOLOGY ); --1.8.3.1