FAILED: patch "[PATCH] HID: intel-ish-hid: ipc: only enable IRQ wakeup when" failed to apply to 4.19-stable tree
Subsystems (3)
[email protected]
maintainerThe patch below does not apply to the 4.19-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.
thanks,
greg k-h
------------------ original commit in Linus's tree ------------------
From 086e81f6b90e41a07a1a885bb11e93daa6915747 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Thomas=20Wei=C3=9Fschuh?= <[email protected]>
Date: Tue, 30 Nov 2021 07:01:17 +0100
Subject: [PATCH] HID: intel-ish-hid: ipc: only enable IRQ wakeup when
requested
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Fixes spurious wakeups from s0ix on Lenovo ThinkPad X1 Cargon Gen 9 on lid close.
These wakeups are generated by interrupts from the ISH on changes to the lid status.
By disabling the wake IRQ from the ISH we inhibit these spurious wakeups while keeping the resume from LID open through the ACPI interrupt.
Reports on the Lenovo forums indicate that Lenovo ThinkPad X1 Yoga Gen6 is also affected.
drivers/hid/intel-ish-hid/ipc/pci-ish.c +4 -2
@@ -266,7 +266,8 @@ static void __maybe_unused ish_resume_handler(struct work_struct *work)if (ish_should_leave_d0i3 (pdev) && !dev->suspend_flag &&IPC_IS_ISH_ILUP (fwsts)) { -disable_irq_wake (pdev->irq); +if (device_may_wakeup (&pdev->dev)) +disable_irq_wake (pdev->irq);ish_set_host_ready (dev);
@@ -337,7 +338,8 @@ static int __maybe_unused ish_suspend(struct device *device)*/ pci_save_state (pdev); -enable_irq_wake (pdev->irq); +if (device_may_wakeup (&pdev->dev)) +enable_irq_wake (pdev->irq); } }else {/*