FAILED: patch "[PATCH] hwmon: (dell-smm) Fix warning on /proc/i8k creation error" failed to apply to 4.9-stable tree
Subsystems (3)
[email protected]
maintainerThe patch below does not apply to the 4.9-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.
thanks,
greg k-h
------------------ original commit in Linus's tree ------------------
From dbd3e6eaf3d813939b28e8a66e29d81cdc836445 Mon Sep 17 00:00:00 2001
From: Armin Wolf <[email protected]>
Date: Fri, 12 Nov 2021 18:14:40 +0100
Subject: [PATCH] hwmon: (dell-smm) Fix warning on /proc/i8k creation error
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
The removal function is called regardless of whether /proc/i8k was created successfully or not, the later causing a WARN() on module removal.
Fix that by only registering the removal function if /proc/i8k was created successfully.
Tested on a Inspiron 3505.
drivers/hwmon/dell-smm-hwmon.c +3 -4
@@ -627,10 +627,9 @@ static void __init i8k_init_procfs(struct device *dev) {struct dell_smm_data *data =dev_get_drvdata (dev); -/* Register the proc entry */ -proc_create_data ("i8k" ,0 ,NULL , &i8k_proc_ops, data); - -devm_add_action_or_reset (dev, i8k_exit_procfs,NULL ); +/* Only register exit function if creation was successful */ +if (proc_create_data ("i8k" ,0 ,NULL , &i8k_proc_ops, data)) +devm_add_action_or_reset (dev, i8k_exit_procfs,NULL ); }#else