Skip to contentSkip to conversation

imagefeatures: New test case, test_empty_image, added

PATCH Jamaluddin, Khairul Rohaizzat 1 participant 1 message Nov 2, 2020 1 message not in the archive

lore
Share & tools
lore
#1 lore raw
In reply to a message not in the archive

Hi,

Just a gentle reminder, is anyone looking into this patch at all?

Thank you & Kind regards,
Khairul

-----Original Message-----
From: [email protected] <[email protected]> On Behalf Of Jamaluddin, Khairul Rohaizzat
Sent: Wednesday, October 21, 2020 4:55 PM
To: [email protected]
Cc: Jamaluddin, Khairul Rohaizzat <[email protected]>
Subject: [OE-core] [PATCH] imagefeatures: New test case, test_empty_image, added

From: Khairul Rohaizzat Jamaluddin <[email protected]>

An empty image build file exists under the meta-selftest folder, test-empty-image.bb, which builds an image with no additional packages. However, there were no further selftest created to verify its emptiness

This change consists of the selftest related to the said image to verify its emptiness and the 'import glob' moved as global import instead of local import.

The expected outcome of the test should be TRUE or 1 if the .manifest file content is empty.

[YOCTO #8455]

---
 meta/lib/oeqa/selftest/cases/imagefeatures.py | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)
meta/lib/oeqa/selftest/cases/imagefeatures.py +11 -1
index f7a2533..415e031 100644
@@ -5,6 +5,7 @@
 from oeqa.selftest.case import OESelftestTestCase  from oeqa.utils.commands import runCmd, bitbake, get_bb_var, runqemu  from oeqa.utils.sshcontrol import SSHControl
+import glob
 import os
 import json
 
@@ -347,7 +348,7 @@ UBOOT_ENTRYPOINT = "0x80080000"
         Author:      Humberto Ibarra <[email protected]>
                      Yeoh Ee Peng <[email protected]>
         """
-        import glob
+      
         image_name = 'core-image-minimal'
         features = 'IMAGE_GEN_DEBUGFS = "1"\n'
         features += 'IMAGE_FSTYPES_DEBUGFS = "tar.bz2"\n'
@@ -368,3 +369,12 @@ UBOOT_ENTRYPOINT = "0x80080000"
         for t in dbg_symbols_targets:
             result = runCmd('objdump --syms %s | grep debug' % t)
             self.assertTrue("debug" in result.output, msg='Failed to find debug symbol: %s' % result.output)
+
+    def test_empty_image(self):
+        """Test creation of image with no packages"""
+        bitbake('test-empty-image')
+        res_dir = get_bb_var('DEPLOY_DIR_IMAGE')
+        images = os.path.join(res_dir, "test-empty-image-*.manifest")
+        result = glob.glob(images)
+        with open(result[1],"r") as f:
+                self.assertEqual(len(f.read().strip()),0)

--
2.7.4