nilfs2: remove redundant pointer sbufs
Ryusuke Konishi
maintainerPATCH 1/1 nilfs2: remove redundant pointer sbufs
From: Colin Ian King <[email protected]>
Pointer sbufs is being assigned a value but it's not being used later on. The pointer is redundant and can be removed. Cleans up scan-build static analysis warning:
fs/nilfs2/page.c:203:8: warning: Although the value stored to 'sbufs' is used in the enclosing expression, the value is never actually read from 'sbufs' [deadcode.DeadStores]
sbh = sbufs = page_buffers(src);
--- fs/nilfs2/page.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
fs/nilfs2/page.c +2 -2
@@ -195,12 +195,12 @@ void nilfs_page_bug(struct page *page)*/ static void nilfs_copy_page (struct page *dst,struct page *src,int copy_dirty) { -struct buffer_head *dbh, *dbufs, *sbh, *sbufs; +struct buffer_head *dbh, *dbufs, *sbh;unsigned long mask =NILFS_BUFFER_INHERENT_BITS ;BUG_ON (PageWriteback (dst)); - sbh = sbufs =page_buffers (src); + sbh =page_buffers (src);if (!page_has_buffers (dst))create_empty_buffers (dst, sbh->b_size,0 );
Signature · 1 line
1.8.3.1
Ryusuke Konishi
maintainerHi Andrew,
Please queue this for the next merge window.
Thank you,
Ryusuke Konishi
Quoted 41 lines · Ryusuke Konishi
From: Colin Ian King <[email protected]>
Pointer sbufs is being assigned a value but it's not being used later on. The pointer is redundant and can be removed. Cleans up scan-build static analysis warning:
fs/nilfs2/page.c:203:8: warning: Although the value stored to 'sbufs' is used in the enclosing expression, the value is never actually read from 'sbufs' [deadcode.DeadStores]sbh = sbufs = page_buffers(src);Signed-off-by Colin Ian King <[email protected]>Signed-off-by Ryusuke Konishi <[email protected]>--- fs/nilfs2/page.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)fs/nilfs2/page.c +2
-3@@ -195,12 +195,12 @@ void nilfs_page_bug(struct page *page)*/ static void nilfs_copy_page (struct page *dst,struct page *src,int copy_dirty) { -struct buffer_head *dbh, *dbufs, *sbh, *sbufs; +struct buffer_head *dbh, *dbufs, *sbh;unsigned long mask =NILFS_BUFFER_INHERENT_BITS ;BUG_ON (PageWriteback (dst)); - sbh = sbufs =page_buffers (src); + sbh =page_buffers (src);if (!page_has_buffers (dst))create_empty_buffers (dst, sbh->b_size,0 ); --1.8.3.1