media: qcom: use div64_u64() instead of do_div()
Subsystems (4)
PATCH 1/1 media: qcom: use div64_u64() instead of do_div()
From: Wang Qing <[email protected]>
do_div() does a 64-by-32 division.
When the divisor is u64, do_div() truncates it to 32 bits, this means it can test non-zero and be truncated to zero for division.
fix do_div.cocci warning:do_div() does a 64-by-32 division, please consider using div64_u64 instead.
--- drivers/media/platform/qcom/venus/vdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/platform/qcom/venus/vdec.c +1 -1
@@ -435,7 +435,7 @@ static int vdec_s_parm(struct file *file, void *fh, struct v4l2_streamparm *a)return -EINVAL ; fps = (u64 )USEC_PER_SEC ; -do_div (fps, us_per_frame); +div64_u64 (fps, us_per_frame); inst->fps = fps; inst->timeperframe = *timeperframe;
Signature · 1 line
2.7.4
Dmitry Baryshkov
NAKQuoted 8 lines · Qing Wang
From: Wang Qing <[email protected]>
do_div()does a 64-by-32 division.
When the divisor is u64,do_div()truncates it to 32 bits, this means it can test non-zero and be truncated to zero for division.fix
do_div.cocciwarning:do_div()does a 64-by-32 division, please consider usingdiv64_u64instead.
NAK
The div64_u64 is not equivalent to do_div. It returns the quotient rather than modifying the first arg. Moreover it is unoptimal on 32-bit arches.
Quoted 19 lines
Signed-off-by Wang Qing <[email protected]>--- drivers/media/platform/qcom/venus/vdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/media/platform/qcom/venus/vdec.c +1
-1@@ -435,7 +435,7 @@ static int vdec_s_parm(struct file *file, void *fh, struct v4l2_streamparm *a)return -EINVAL ; fps = (u64 )USEC_PER_SEC ; -do_div (fps, us_per_frame); +div64_u64 (fps, us_per_frame); inst->fps = fps; inst->timeperframe = *timeperframe;
Signature · 2 lines
With best wishes Dmitry
From: Dmitry Baryshkov
Quoted 32 lines
Sent: 10 February 2022 10:17
Quoted 8 lines · Qing Wang
From: Wang Qing <[email protected]>
do_div()does a 64-by-32 division.
When the divisor is u64,do_div()truncates it to 32 bits, this means it can test non-zero and be truncated to zero for division.fix
do_div.cocciwarning:do_div()does a 64-by-32 division, please consider usingdiv64_u64instead.NAK
The
div64_u64is not equivalent todo_div. It returns the quotient rather than modifying the first arg. Moreover it is unoptimal on 32-bit arches.Quoted 13 lines
Signed-off-by Wang Qing <[email protected]>--- drivers/media/platform/qcom/venus/vdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/media/platform/qcom/venus/vdec.c +0
-0@@ -435,7 +435,7 @@ static int vdec_s_parm(struct file *file, void *fh, struct v4l2_streamparm *a)return -EINVAL ;
Quoted 3 lines
drivers/media/platform/qcom/venus/vdec.c static int vdec_s_parm(struct file *file, void *fh, struct v4l2_streamparm *a) · line 438
Quoted 3 lines
drivers/media/platform/qcom/venus/vdec.c +1
-1fps = (u64 )USEC_PER_SEC ; -do_div (fps, us_per_frame); +div64_u64 (fps, us_per_frame);
That one is particularly insane to begin with.
Why was it even do_div()?
I guess because:
fps = USEC_PER_SEC / us_per_frame;
caused the compiler to call the 64bit divide function because the 'us_per_frame' is 64bit - even though the code only makes sense if it is small.
The correct fix here is probably to change the type of us_per_frame to 32bit or just do:
fps = USEC_PER_FRAM / (unsigned int)us_per_frame.
Oh, and fps definitely doesn't need to be 64bit either.
IMHO all (and I mean ALL) of these patches to change do_div() to div64_u64() need dropping.
Maybe one or two are real problems, but the surrounding code needs correctly examining.
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)