patch "iio: adc: tsc2046: fix memory corruption by preventing array overflow" added to char-misc-linus
Subsystems (3)
This is a note to let you know that I've just added the patch titled
iio: adc: tsc2046: fix memory corruption by preventing array overflow
to my char-misc git tree which can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git
in the char-misc-linus branch.
The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.)
The patch will hopefully also be merged in Linus's tree for the next -rc kernel release.
If you have any questions about this process, please let me know.
From b7a78a8adaa8849c02f174d707aead0f85dca0da Mon Sep 17 00:00:00 2001
From: Oleksij Rempel <[email protected]>
Date: Fri, 7 Jan 2022 09:14:01 +0100
Subject: iio: adc: tsc2046: fix memory corruption by preventing array overflow
On one side we have indio_dev->num_channels includes all physical channels + timestamp channel. On other side we have an array allocated only for physical channels. So, fix memory corruption by ARRAY_SIZE() instead of num_channels variable.
Note the first case is a cleanup rather than a fix as the software timestamp channel bit in active_scanmask is never set by the IIO core.
--- drivers/iio/adc/ti-tsc2046.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/iio/adc/ti-tsc2046.c +2 -2
@@ -388,7 +388,7 @@ static int tsc2046_adc_update_scan_mode(struct iio_dev *indio_dev,mutex_lock (&priv->slock); size =0 ; -for_each_set_bit (ch_idx, active_scan_mask, indio_dev->num_channels) { +for_each_set_bit (ch_idx, active_scan_mask,ARRAY_SIZE (priv->l)) { size +=tsc2046_adc_group_set_layout (priv, group, ch_idx);tsc2046_adc_group_set_cmd (priv, group, ch_idx); group++;
@@ -548,7 +548,7 @@ static int tsc2046_adc_setup_spi_msg(struct tsc2046_adc_priv *priv)* enabled. */ size =0 ; -for (ch_idx =0 ; ch_idx < priv->dcfg->num_channels; ch_idx++) +for (ch_idx =0 ; ch_idx <ARRAY_SIZE (priv->l); ch_idx++) size +=tsc2046_adc_group_set_layout (priv, ch_idx, ch_idx); priv->tx =devm_kzalloc (&priv->spi->dev, size,GFP_KERNEL );
Signature · 1 line
2.35.1